review-tools

Code review comment for ~jslarraz/review-tools:container-size-checks

  1. Git
  2. lp:~jslarraz/review-tools
  3. container-size-checks
  4. Merge into master
Revision history for this message
Jorge Sancho Larraz (jslarraz) wrote :

Comments addressed in https://git.launchpad.net/~jslarraz/review-tools/commit/?id=de2de8651408f287c5c1b0a27787e2e3511b6057

Fix for container size not being checked in SnapContainer in https://git.launchpad.net/~jslarraz/review-tools/commit/?id=0cd400e35ad2b1637c02fd5463e5ca9bfaf559d9

> "I assume all containers would want to check their format - as such, should this be done in the BaseContainer constructor instead?"

I fully agree with you but it will require some non-obvious changes in test_base_container, thus I would prefer to do it in a followup MR

« Back to merge proposal