review-tools

Merge ~jslarraz/review-tools:schema-add-type into review-tools:master

  1. Git
  2. lp:~jslarraz/review-tools
  3. schema-add-type
  4. Merge into master
Proposed by Jorge Sancho Larraz
Status: Merged
Merged at revision: c9fbd37860f7cab134142578eb48ca6c89c8f864
Proposed branch: ~jslarraz/review-tools:schema-add-type
Merge into: review-tools:master
Diff against target: 2536 lines (+36/-903)
9 files modified
check-names.list (+0/-1)
reviewtools/schemas/schema_validator.py (+7/-1)
reviewtools/schemas/snap.json (+6/-0)
reviewtools/sr_common.py (+0/-9)
reviewtools/sr_declaration.py (+4/-2)
reviewtools/sr_lint.py (+0/-10)
reviewtools/tests/schemas/test_schema_snap.py (+19/-0)
reviewtools/tests/test_sr_lint.py (+0/-36)
tests/test.sh.expected (+0/-844)
Reviewer Review Type Date Requested Status
Alex Murray Approve
Review via email: mp+466454@code.launchpad.net

Commit message

many: check type via schema

To post a comment you must log in.
Revision history for this message
Alex Murray (alexmurray) wrote :

LGTM but one minor suggestion to see if we can avoid hardcoding the snap types in sr_declaration.py

review: Needs Information
Revision history for this message
Jorge Sancho Larraz (jslarraz) wrote :

Done in https://git.launchpad.net/~jslarraz/review-tools/commit/?id=22827dce8143d4e685f992c049a2935a744285ba

Revision history for this message
Alex Murray (alexmurray) wrote :

Thanks, LGTM!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/check-names.list b/check-names.list
2index 1498e85..cbe0bdc 100644
3--- a/check-names.list
4+++ b/check-names.list
5@@ -125,7 +125,6 @@ lint-snap-v2:slots_required_attributes|
6 lint-snap-v2:slots|
7 lint-snap-v2:snap_manifest|
8 lint-snap-v2:snap_type_redflag|
9-lint-snap-v2:snap_type_valid|
10 lint-snap-v2:sockets_listen_stream|
11 lint-snap-v2:sockets_socket-mode|
12 lint-snap-v2:sockets_type|
13diff --git a/reviewtools/schemas/schema_validator.py b/reviewtools/schemas/schema_validator.py
14index d9803c3..9889d20 100644
15--- a/reviewtools/schemas/schema_validator.py
16+++ b/reviewtools/schemas/schema_validator.py
17@@ -4,7 +4,7 @@ import jsonschema
18 from pkg_resources import resource_filename
19
20
21-def validate(yaml, schema_name):
22+def load_schema(schema_name: str) -> dict:
23 # prefer local copy if it exists, otherwise, use one shipped in the
24 # package
25 schema_fn = "./reviewtools/schemas/%s" % schema_name
26@@ -16,6 +16,12 @@ def validate(yaml, schema_name):
27 with open(schema_fn) as fd:
28 schema = json.loads(fd.read())
29
30+ return schema
31+
32+
33+def validate(yaml, schema_name):
34+ schema = load_schema(schema_name)
35+
36 resolver = jsonschema.RefResolver(
37 "file://%s/" % os.path.abspath(os.path.dirname(__file__)), None
38 )
39diff --git a/reviewtools/schemas/snap.json b/reviewtools/schemas/snap.json
40index 8d9c6bd..7051faa 100644
41--- a/reviewtools/schemas/snap.json
42+++ b/reviewtools/schemas/snap.json
43@@ -16,6 +16,12 @@
44 "pattern": "^[a-zA-Z0-9](?:[a-zA-Z0-9:.+~-]*[a-zA-Z0-9+~])?$",
45 "maxLength": 32
46 },
47+ "type": {
48+ "description": "The type of snap.",
49+ "type": "string",
50+ "enum": ["app", "base", "core", "kernel", "gadget", "os", "snapd"],
51+ "default": "app"
52+ },
53 "architectures": {
54 "description": "List of architectures.",
55 "type": "array",
56diff --git a/reviewtools/sr_common.py b/reviewtools/sr_common.py
57index 5ded6d8..e39a68a 100644
58--- a/reviewtools/sr_common.py
59+++ b/reviewtools/sr_common.py
60@@ -138,15 +138,6 @@ class SnapReview(ReviewBase):
61 hooks_required = []
62 hooks_optional = ["command-chain", "environment", "plugs", "slots"]
63
64- # Valid values for 'type' in packaging yaml
65- # - app
66- # - core
67- # - kernel
68- # - gadget
69- # - os (deprecated)
70- # - snapd
71- valid_snap_types = ["app", "base", "core", "kernel", "gadget", "os", "snapd"]
72-
73 # snap/hooktypes.go
74 valid_hook_types = [
75 "check-health",
76diff --git a/reviewtools/sr_declaration.py b/reviewtools/sr_declaration.py
77index 5af713a..edfe023 100644
78--- a/reviewtools/sr_declaration.py
79+++ b/reviewtools/sr_declaration.py
80@@ -18,6 +18,7 @@ from __future__ import print_function
81 from reviewtools.sr_common import SnapReview, SnapReviewException
82 from reviewtools.common import error, ReviewBase, read_snapd_base_declaration
83 from reviewtools.overrides import sec_iface_ref_overrides
84+from reviewtools.schemas.schema_validator import load_schema
85 import copy
86 import re
87
88@@ -456,7 +457,9 @@ class SnapReviewDeclaration(SnapReview):
89 cstr_key == "plug-snap-type" or cstr_key == "slot-snap-type"
90 ):
91 for snap_type in cstr[cstr_key]:
92- if snap_type not in self.valid_snap_types:
93+ # TODO: Check it via declaration.json schema :)
94+ snap_schema = load_schema("snap.json")
95+ if snap_type not in snap_schema["properties"]["type"]["enum"]:
96 malformed(n, "invalid snap type '%s'" % snap_type)
97 found_errors = True
98 break
99@@ -1511,7 +1514,6 @@ def verify_snap_declaration(snap_decl, base_decl=None):
100
101 # Setup everything needed by _verify_declaration()
102 review.interfaces_attribs = SnapReview.interfaces_attribs
103- review.valid_snap_types = SnapReview.valid_snap_types
104
105 # Read in and verify the base declaration
106 if base_decl is None:
107diff --git a/reviewtools/sr_lint.py b/reviewtools/sr_lint.py
108index 83a9dfa..17c8e3a 100644
109--- a/reviewtools/sr_lint.py
110+++ b/reviewtools/sr_lint.py
111@@ -160,16 +160,6 @@ class SnapReviewLint(SnapReview):
112 # snap/validate.go
113 self._check_description_summary_title("title", 40)
114
115- def check_type(self):
116- """Check type"""
117- t = "info"
118- n = self._get_check_name("snap_type_valid")
119- s = "OK"
120- if self.snap_yaml["type"] not in self.valid_snap_types:
121- t = "error"
122- s = "unknown 'type': '%s'" % self.snap_yaml["type"]
123- self._add_result(t, n, s)
124-
125 def check_type_redflagged(self):
126 """Check if type is redflagged"""
127 t = "info"
128diff --git a/reviewtools/tests/schemas/test_schema_snap.py b/reviewtools/tests/schemas/test_schema_snap.py
129index ed4853d..3530892 100644
130--- a/reviewtools/tests/schemas/test_schema_snap.py
131+++ b/reviewtools/tests/schemas/test_schema_snap.py
132@@ -121,6 +121,25 @@ class TestSchemaSnap(TestSchemaBase):
133 error = error.replace("{value}", str(value)) if error else error
134 self._test_value("version", value, error)
135
136+ def test_type(self):
137+ for value, error in [
138+ # test_check_type - unspecified
139+ (None, None),
140+ # test_check_type_app
141+ ("app", None),
142+ # test_check_type_framework
143+ ("framework", "'{value}' is not one of "),
144+ # test_check_type_unknown
145+ ("nonexistent", "'{value}' is not one of "),
146+ # ### integer
147+ (2, "{value} is not of type 'string'"),
148+ # ### list
149+ ([], "{value} is not of type 'string'"),
150+ ]:
151+ with self.subTest(value=value):
152+ error = error.replace("{value}", str(value)) if error else error
153+ self._test_value("type", value, error)
154+
155 def test_architecture(self):
156 for value, error in [
157 # test_check_architectures_bad
158diff --git a/reviewtools/tests/test_sr_lint.py b/reviewtools/tests/test_sr_lint.py
159index 50499fd..e530ab7 100644
160--- a/reviewtools/tests/test_sr_lint.py
161+++ b/reviewtools/tests/test_sr_lint.py
162@@ -143,33 +143,6 @@ class TestSnapReviewLint(sr_tests.TestSnapReview):
163 sum += len(c.review_report[i])
164 self.assertTrue(sum != 0)
165
166- def test_check_type(self):
167- """Test check_type - unspecified"""
168- self.set_test_snap_yaml("type", None)
169- c = SnapReviewLint(self.test_name)
170- c.check_type()
171- r = c.review_report
172- expected_counts = {"info": 1, "warn": 0, "error": 0}
173- self.check_results(r, expected_counts)
174-
175- def test_check_type_app(self):
176- """Test check_type - app"""
177- self.set_test_snap_yaml("type", "app")
178- c = SnapReviewLint(self.test_name)
179- c.check_type()
180- r = c.review_report
181- expected_counts = {"info": 1, "warn": 0, "error": 0}
182- self.check_results(r, expected_counts)
183-
184- def test_check_type_framework(self):
185- """Test check_type - framework"""
186- self.set_test_snap_yaml("type", "framework")
187- c = SnapReviewLint(self.test_name)
188- c.check_type()
189- r = c.review_report
190- expected_counts = {"info": 0, "warn": 0, "error": 1}
191- self.check_results(r, expected_counts)
192-
193 def test_check_type_redflagged(self):
194 """Test check_type_redflagged - unspecified"""
195 self.set_test_snap_yaml("type", None)
196@@ -335,15 +308,6 @@ class TestSnapReviewLint(sr_tests.TestSnapReview):
197 name = c._get_check_name("snap_type_redflag")
198 self.check_manual_review(r, name)
199
200- def test_check_type_unknown(self):
201- """Test check_type - unknown"""
202- self.set_test_snap_yaml("type", "nonexistent")
203- c = SnapReviewLint(self.test_name)
204- c.check_type()
205- r = c.review_report
206- expected_counts = {"info": None, "warn": 0, "error": 1}
207- self.check_results(r, expected_counts)
208-
209 def test_check_icon(self):
210 """Test check_icon()"""
211 self.set_test_snap_yaml("icon", "someicon")
212diff --git a/tests/test.sh.expected b/tests/test.sh.expected
213index 04cbb7a..b677857 100644
214--- a/tests/test.sh.expected
215+++ b/tests/test.sh.expected
216@@ -55,10 +55,6 @@ bare_1.0_all.snap: pass
217 "manual_review": false,
218 "text": "OK (override 'bare' for 'type: base')"
219 },
220- "lint-snap-v2:snap_type_valid": {
221- "manual_review": false,
222- "text": "OK"
223- },
224 "lint-snap-v2:summary": {
225 "manual_review": false,
226 "text": "OK"
227@@ -158,10 +154,6 @@ bare_1.0_all.snap: pass
228 "manual_review": false,
229 "text": "OK (override 'bare' for 'type: base')"
230 },
231- "lint-snap-v2:snap_type_valid": {
232- "manual_review": false,
233- "text": "OK"
234- },
235 "lint-snap-v2:summary": {
236 "manual_review": false,
237 "text": "OK"
238@@ -298,10 +290,6 @@ busybox-static-mvo_2.snap: pass
239 "manual_review": false,
240 "text": "OK"
241 },
242- "lint-snap-v2:snap_type_valid": {
243- "manual_review": false,
244- "text": "OK"
245- },
246 "lint-snap-v2:summary": {
247 "manual_review": false,
248 "text": "OK"
249@@ -445,10 +433,6 @@ busybox-static-mvo_2.snap: pass
250 "manual_review": false,
251 "text": "OK"
252 },
253- "lint-snap-v2:snap_type_valid": {
254- "manual_review": false,
255- "text": "OK"
256- },
257 "lint-snap-v2:summary": {
258 "manual_review": false,
259 "text": "OK"
260@@ -723,10 +707,6 @@ chrome-test_52.0.2743.116-1+test1_amd64.snap: FAIL
261 "manual_review": false,
262 "text": "OK"
263 },
264- "lint-snap-v2:snap_type_valid": {
265- "manual_review": false,
266- "text": "OK"
267- },
268 "lint-snap-v2:summary": {
269 "manual_review": false,
270 "text": "OK"
271@@ -992,10 +972,6 @@ chrome-test_52.0.2743.116-1+test1_amd64.snap: FAIL
272 "manual_review": false,
273 "text": "OK"
274 },
275- "lint-snap-v2:snap_type_valid": {
276- "manual_review": false,
277- "text": "OK"
278- },
279 "lint-snap-v2:summary": {
280 "manual_review": false,
281 "text": "OK"
282@@ -1140,10 +1116,6 @@ chromium-lzo_1.snap: pass
283 "manual_review": false,
284 "text": "OK"
285 },
286- "lint-snap-v2:snap_type_valid": {
287- "manual_review": false,
288- "text": "OK"
289- },
290 "lint-snap-v2:summary": {
291 "manual_review": false,
292 "text": "OK"
293@@ -1287,10 +1259,6 @@ chromium-lzo_1.snap: pass
294 "manual_review": false,
295 "text": "OK"
296 },
297- "lint-snap-v2:snap_type_valid": {
298- "manual_review": false,
299- "text": "OK"
300- },
301 "lint-snap-v2:summary": {
302 "manual_review": false,
303 "text": "OK"
304@@ -1504,10 +1472,6 @@ classic_16.04+test1_all.snap: FAIL
305 "manual_review": false,
306 "text": "OK"
307 },
308- "lint-snap-v2:snap_type_valid": {
309- "manual_review": false,
310- "text": "OK"
311- },
312 "lint-snap-v2:summary": {
313 "manual_review": false,
314 "text": "OK"
315@@ -1720,10 +1684,6 @@ classic_16.04+test1_all.snap: FAIL
316 "manual_review": false,
317 "text": "OK"
318 },
319- "lint-snap-v2:snap_type_valid": {
320- "manual_review": false,
321- "text": "OK"
322- },
323 "lint-snap-v2:summary": {
324 "manual_review": false,
325 "text": "OK"
326@@ -1901,10 +1861,6 @@ devmode-home_0.1_amd64.snap: pass
327 "manual_review": false,
328 "text": "OK"
329 },
330- "lint-snap-v2:snap_type_valid": {
331- "manual_review": false,
332- "text": "OK"
333- },
334 "lint-snap-v2:summary": {
335 "manual_review": false,
336 "text": "OK"
337@@ -2065,10 +2021,6 @@ devmode-home_0.1_amd64.snap: pass
338 "manual_review": false,
339 "text": "OK"
340 },
341- "lint-snap-v2:snap_type_valid": {
342- "manual_review": false,
343- "text": "OK"
344- },
345 "lint-snap-v2:summary": {
346 "manual_review": false,
347 "text": "OK"
348@@ -2427,10 +2379,6 @@ firefox_48.0+build2-0ubuntu0.16.04.1+_amd64.snap: FAIL
349 "manual_review": false,
350 "text": "OK"
351 },
352- "lint-snap-v2:snap_type_valid": {
353- "manual_review": false,
354- "text": "OK"
355- },
356 "lint-snap-v2:summary": {
357 "manual_review": false,
358 "text": "OK"
359@@ -2784,10 +2732,6 @@ firefox_48.0+build2-0ubuntu0.16.04.1+_amd64.snap: FAIL
360 "manual_review": false,
361 "text": "OK"
362 },
363- "lint-snap-v2:snap_type_valid": {
364- "manual_review": false,
365- "text": "OK"
366- },
367 "lint-snap-v2:summary": {
368 "manual_review": false,
369 "text": "OK"
370@@ -2915,10 +2859,6 @@ gke-kernel_4.15.0-1027.28~16.04.1_amd64.snap: pass
371 "manual_review": false,
372 "text": "OK (override 'gke-kernel' for 'type: kernel')"
373 },
374- "lint-snap-v2:snap_type_valid": {
375- "manual_review": false,
376- "text": "OK"
377- },
378 "lint-snap-v2:summary": {
379 "manual_review": false,
380 "text": "OK"
381@@ -3021,10 +2961,6 @@ gke-kernel_4.15.0-1027.28~16.04.1_amd64.snap: pass
382 "manual_review": false,
383 "text": "OK (override 'gke-kernel' for 'type: kernel')"
384 },
385- "lint-snap-v2:snap_type_valid": {
386- "manual_review": false,
387- "text": "OK"
388- },
389 "lint-snap-v2:summary": {
390 "manual_review": false,
391 "text": "OK"
392@@ -3132,10 +3068,6 @@ gke-kernel_4.15.0-1069.72_amd64.snap: pass
393 "manual_review": false,
394 "text": "OK (override 'gke-kernel' for 'type: kernel')"
395 },
396- "lint-snap-v2:snap_type_valid": {
397- "manual_review": false,
398- "text": "OK"
399- },
400 "lint-snap-v2:summary": {
401 "manual_review": false,
402 "text": "OK"
403@@ -3238,10 +3170,6 @@ gke-kernel_4.15.0-1069.72_amd64.snap: pass
404 "manual_review": false,
405 "text": "OK (override 'gke-kernel' for 'type: kernel')"
406 },
407- "lint-snap-v2:snap_type_valid": {
408- "manual_review": false,
409- "text": "OK"
410- },
411 "lint-snap-v2:summary": {
412 "manual_review": false,
413 "text": "OK"
414@@ -3500,10 +3428,6 @@ glance_ocata_amd64.snap: pass
415 "manual_review": false,
416 "text": "OK"
417 },
418- "lint-snap-v2:snap_type_valid": {
419- "manual_review": false,
420- "text": "OK"
421- },
422 "lint-snap-v2:summary": {
423 "manual_review": false,
424 "text": "OK"
425@@ -3781,10 +3705,6 @@ glance_ocata_amd64.snap: pass
426 "manual_review": false,
427 "text": "OK"
428 },
429- "lint-snap-v2:snap_type_valid": {
430- "manual_review": false,
431- "text": "OK"
432- },
433 "lint-snap-v2:summary": {
434 "manual_review": false,
435 "text": "OK"
436@@ -4099,10 +4019,6 @@ hello-world_25.snap: pass
437 "manual_review": false,
438 "text": "OK"
439 },
440- "lint-snap-v2:snap_type_valid": {
441- "manual_review": false,
442- "text": "OK"
443- },
444 "lint-snap-v2:summary": {
445 "manual_review": false,
446 "text": "OK"
447@@ -4386,10 +4302,6 @@ hello-world_25.snap: pass
448 "manual_review": false,
449 "text": "OK"
450 },
451- "lint-snap-v2:snap_type_valid": {
452- "manual_review": false,
453- "text": "OK"
454- },
455 "lint-snap-v2:summary": {
456 "manual_review": false,
457 "text": "OK"
458@@ -4537,10 +4449,6 @@ linux-generic-bbb_4.4.0-140-1_armhf.snap: pass
459 "manual_review": false,
460 "text": "OK (override 'linux-generic-bbb' for 'type: kernel')"
461 },
462- "lint-snap-v2:snap_type_valid": {
463- "manual_review": false,
464- "text": "OK"
465- },
466 "lint-snap-v2:summary": {
467 "manual_review": false,
468 "text": "OK"
469@@ -4643,10 +4551,6 @@ linux-generic-bbb_4.4.0-140-1_armhf.snap: pass
470 "manual_review": false,
471 "text": "OK (override 'linux-generic-bbb' for 'type: kernel')"
472 },
473- "lint-snap-v2:snap_type_valid": {
474- "manual_review": false,
475- "text": "OK"
476- },
477 "lint-snap-v2:summary": {
478 "manual_review": false,
479 "text": "OK"
480@@ -4783,10 +4687,6 @@ minimumsize_0.1_amd64.snap: pass
481 "manual_review": false,
482 "text": "OK"
483 },
484- "lint-snap-v2:snap_type_valid": {
485- "manual_review": false,
486- "text": "OK"
487- },
488 "lint-snap-v2:summary": {
489 "manual_review": false,
490 "text": "OK"
491@@ -4918,10 +4818,6 @@ minimumsize_0.1_amd64.snap: pass
492 "manual_review": false,
493 "text": "OK"
494 },
495- "lint-snap-v2:snap_type_valid": {
496- "manual_review": false,
497- "text": "OK"
498- },
499 "lint-snap-v2:summary": {
500 "manual_review": false,
501 "text": "OK"
502@@ -5070,10 +4966,6 @@ network-manager_1.10.6-2ubuntu1.0+dbce8fd2_amd64.snap: pass
503 "manual_review": false,
504 "text": "OK"
505 },
506- "lint-snap-v2:snap_type_valid": {
507- "manual_review": false,
508- "text": "OK"
509- },
510 "lint-snap-v2:summary": {
511 "manual_review": false,
512 "text": "OK"
513@@ -5233,10 +5125,6 @@ network-manager_1.10.6-2ubuntu1.0+dbce8fd2_amd64.snap: pass
514 "manual_review": false,
515 "text": "OK"
516 },
517- "lint-snap-v2:snap_type_valid": {
518- "manual_review": false,
519- "text": "OK"
520- },
521 "lint-snap-v2:summary": {
522 "manual_review": false,
523 "text": "OK"
524@@ -5466,10 +5354,6 @@ network-manager_1.2.2-1+test1_amd64.snap: FAIL
525 "manual_review": false,
526 "text": "OK"
527 },
528- "lint-snap-v2:snap_type_valid": {
529- "manual_review": false,
530- "text": "OK"
531- },
532 "lint-snap-v2:summary": {
533 "manual_review": false,
534 "text": "OK"
535@@ -5692,10 +5576,6 @@ network-manager_1.2.2-1+test1_amd64.snap: FAIL
536 "manual_review": false,
537 "text": "OK"
538 },
539- "lint-snap-v2:snap_type_valid": {
540- "manual_review": false,
541- "text": "OK"
542- },
543 "lint-snap-v2:summary": {
544 "manual_review": false,
545 "text": "OK"
546@@ -5892,10 +5772,6 @@ nix-example-jormungandr_f7xva0vh9fzv20vhyr121yd6ahplqh9v_amd64.snap: pass
547 "manual_review": false,
548 "text": "OK"
549 },
550- "lint-snap-v2:snap_type_valid": {
551- "manual_review": false,
552- "text": "OK"
553- },
554 "lint-snap-v2:summary": {
555 "manual_review": false,
556 "text": "summary is too short: 'jormungandr'"
557@@ -6087,10 +5963,6 @@ nix-example-jormungandr_f7xva0vh9fzv20vhyr121yd6ahplqh9v_amd64.snap: pass
558 "manual_review": false,
559 "text": "OK"
560 },
561- "lint-snap-v2:snap_type_valid": {
562- "manual_review": false,
563- "text": "OK"
564- },
565 "lint-snap-v2:summary": {
566 "manual_review": false,
567 "text": "summary is too short: 'jormungandr'"
568@@ -6376,10 +6248,6 @@ nix-example_g7qmi8r4qwws6fhwschfb8aib5wl0x1q_amd64.snap: pass
569 "manual_review": false,
570 "text": "OK"
571 },
572- "lint-snap-v2:snap_type_valid": {
573- "manual_review": false,
574- "text": "OK"
575- },
576 "lint-snap-v2:summary": {
577 "manual_review": false,
578 "text": "OK"
579@@ -6656,10 +6524,6 @@ nix-example_g7qmi8r4qwws6fhwschfb8aib5wl0x1q_amd64.snap: pass
580 "manual_review": false,
581 "text": "OK"
582 },
583- "lint-snap-v2:snap_type_valid": {
584- "manual_review": false,
585- "text": "OK"
586- },
587 "lint-snap-v2:summary": {
588 "manual_review": false,
589 "text": "OK"
590@@ -6833,10 +6697,6 @@ notify-send_1_amd64.snap: pass
591 "manual_review": false,
592 "text": "OK"
593 },
594- "lint-snap-v2:snap_type_valid": {
595- "manual_review": false,
596- "text": "OK"
597- },
598 "lint-snap-v2:summary": {
599 "manual_review": false,
600 "text": "OK"
601@@ -7005,10 +6865,6 @@ notify-send_1_amd64.snap: pass
602 "manual_review": false,
603 "text": "OK"
604 },
605- "lint-snap-v2:snap_type_valid": {
606- "manual_review": false,
607- "text": "OK"
608- },
609 "lint-snap-v2:summary": {
610 "manual_review": false,
611 "text": "OK"
612@@ -7132,10 +6988,6 @@ pc-kernel_4.15.0-44.46_i386.snap: pass
613 "manual_review": false,
614 "text": "OK (override 'pc-kernel' for 'type: kernel')"
615 },
616- "lint-snap-v2:snap_type_valid": {
617- "manual_review": false,
618- "text": "OK"
619- },
620 "lint-snap-v2:summary": {
621 "manual_review": false,
622 "text": "OK"
623@@ -7238,10 +7090,6 @@ pc-kernel_4.15.0-44.46_i386.snap: pass
624 "manual_review": false,
625 "text": "OK (override 'pc-kernel' for 'type: kernel')"
626 },
627- "lint-snap-v2:snap_type_valid": {
628- "manual_review": false,
629- "text": "OK"
630- },
631 "lint-snap-v2:summary": {
632 "manual_review": false,
633 "text": "OK"
634@@ -7349,10 +7197,6 @@ pc-kernel_4.4.0-141.167_amd64.snap: pass
635 "manual_review": false,
636 "text": "OK (override 'pc-kernel' for 'type: kernel')"
637 },
638- "lint-snap-v2:snap_type_valid": {
639- "manual_review": false,
640- "text": "OK"
641- },
642 "lint-snap-v2:summary": {
643 "manual_review": false,
644 "text": "OK"
645@@ -7455,10 +7299,6 @@ pc-kernel_4.4.0-141.167_amd64.snap: pass
646 "manual_review": false,
647 "text": "OK (override 'pc-kernel' for 'type: kernel')"
648 },
649- "lint-snap-v2:snap_type_valid": {
650- "manual_review": false,
651- "text": "OK"
652- },
653 "lint-snap-v2:summary": {
654 "manual_review": false,
655 "text": "OK"
656@@ -7554,10 +7394,6 @@ pc.canonical_5.snap: pass
657 "manual_review": false,
658 "text": "OK (override 'pc' for 'type: gadget')"
659 },
660- "lint-snap-v2:snap_type_valid": {
661- "manual_review": false,
662- "text": "OK"
663- },
664 "lint-snap-v2:summary": {
665 "manual_review": false,
666 "text": "OK"
667@@ -7652,10 +7488,6 @@ pc.canonical_5.snap: pass
668 "manual_review": false,
669 "text": "OK (override 'pc' for 'type: gadget')"
670 },
671- "lint-snap-v2:snap_type_valid": {
672- "manual_review": false,
673- "text": "OK"
674- },
675 "lint-snap-v2:summary": {
676 "manual_review": false,
677 "text": "OK"
678@@ -8849,10 +8681,6 @@ quagga_1.0.20160315-alpha2-git.c6fadc4+_amd64.snap: pass
679 "manual_review": false,
680 "text": "OK"
681 },
682- "lint-snap-v2:snap_type_valid": {
683- "manual_review": false,
684- "text": "OK"
685- },
686 "lint-snap-v2:summary": {
687 "manual_review": false,
688 "text": "OK"
689@@ -10121,10 +9949,6 @@ quagga_1.0.20160315-alpha2-git.c6fadc4+_amd64.snap: pass
690 "manual_review": false,
691 "text": "OK"
692 },
693- "lint-snap-v2:snap_type_valid": {
694- "manual_review": false,
695- "text": "OK"
696- },
697 "lint-snap-v2:summary": {
698 "manual_review": false,
699 "text": "OK"
700@@ -10354,10 +10178,6 @@ snap-test-arch-all-warning_1_all.snap: FAIL
701 "manual_review": false,
702 "text": "OK"
703 },
704- "lint-snap-v2:snap_type_valid": {
705- "manual_review": false,
706- "text": "OK"
707- },
708 "lint-snap-v2:summary": {
709 "manual_review": false,
710 "text": "summary is too short: 'my summary'"
711@@ -10510,10 +10330,6 @@ snap-test-arch-all-warning_1_all.snap: FAIL
712 "manual_review": false,
713 "text": "OK"
714 },
715- "lint-snap-v2:snap_type_valid": {
716- "manual_review": false,
717- "text": "OK"
718- },
719 "lint-snap-v2:summary": {
720 "manual_review": false,
721 "text": "summary is too short: 'my summary'"
722@@ -10671,10 +10487,6 @@ snappy-debug_20.snap: pass
723 "manual_review": false,
724 "text": "OK"
725 },
726- "lint-snap-v2:snap_type_valid": {
727- "manual_review": false,
728- "text": "OK"
729- },
730 "lint-snap-v2:summary": {
731 "manual_review": false,
732 "text": "OK"
733@@ -10831,10 +10643,6 @@ snappy-debug_20.snap: pass
734 "manual_review": false,
735 "text": "OK"
736 },
737- "lint-snap-v2:snap_type_valid": {
738- "manual_review": false,
739- "text": "OK"
740- },
741 "lint-snap-v2:summary": {
742 "manual_review": false,
743 "text": "OK"
744@@ -11040,10 +10848,6 @@ snappy-test-iface-attribs_0.1_all.snap: pass
745 "manual_review": false,
746 "text": "OK"
747 },
748- "lint-snap-v2:snap_type_valid": {
749- "manual_review": false,
750- "text": "OK"
751- },
752 "lint-snap-v2:summary": {
753 "manual_review": false,
754 "text": "summary is too short: 'This is a test snap'"
755@@ -11244,10 +11048,6 @@ snappy-test-iface-attribs_0.1_all.snap: pass
756 "manual_review": false,
757 "text": "OK"
758 },
759- "lint-snap-v2:snap_type_valid": {
760- "manual_review": false,
761- "text": "OK"
762- },
763 "lint-snap-v2:summary": {
764 "manual_review": false,
765 "text": "summary is too short: 'This is a test snap'"
766@@ -13990,10 +13790,6 @@ test-all-app_1_all.snap: FAIL
767 "manual_review": false,
768 "text": "OK"
769 },
770- "lint-snap-v2:snap_type_valid": {
771- "manual_review": false,
772- "text": "OK"
773- },
774 "lint-snap-v2:summary": {
775 "manual_review": false,
776 "text": "OK"
777@@ -16955,10 +16751,6 @@ test-all-app_1_all.snap: FAIL
778 "manual_review": false,
779 "text": "OK"
780 },
781- "lint-snap-v2:snap_type_valid": {
782- "manual_review": false,
783- "text": "OK"
784- },
785 "lint-snap-v2:summary": {
786 "manual_review": false,
787 "text": "OK"
788@@ -17788,10 +17580,6 @@ test-all-core_1_all.snap: FAIL
789 "manual_review": false,
790 "text": "OK"
791 },
792- "lint-snap-v2:snap_type_valid": {
793- "manual_review": false,
794- "text": "OK"
795- },
796 "lint-snap-v2:summary": {
797 "manual_review": false,
798 "text": "OK"
799@@ -18336,10 +18124,6 @@ test-all-core_1_all.snap: FAIL
800 "manual_review": false,
801 "text": "OK"
802 },
803- "lint-snap-v2:snap_type_valid": {
804- "manual_review": false,
805- "text": "OK"
806- },
807 "lint-snap-v2:summary": {
808 "manual_review": false,
809 "text": "OK"
810@@ -18641,10 +18425,6 @@ test-all-gadget_3_all.snap: FAIL
811 "manual_review": false,
812 "text": "OK"
813 },
814- "lint-snap-v2:snap_type_valid": {
815- "manual_review": false,
816- "text": "OK"
817- },
818 "lint-snap-v2:summary": {
819 "manual_review": false,
820 "text": "OK"
821@@ -18937,10 +18717,6 @@ test-all-gadget_3_all.snap: FAIL
822 "manual_review": false,
823 "text": "OK"
824 },
825- "lint-snap-v2:snap_type_valid": {
826- "manual_review": false,
827- "text": "OK"
828- },
829 "lint-snap-v2:summary": {
830 "manual_review": false,
831 "text": "OK"
832@@ -19084,10 +18860,6 @@ test-app-devnull_1.0_all.snap: FAIL
833 "manual_review": false,
834 "text": "OK"
835 },
836- "lint-snap-v2:snap_type_valid": {
837- "manual_review": false,
838- "text": "OK"
839- },
840 "lint-snap-v2:summary": {
841 "manual_review": false,
842 "text": "OK"
843@@ -19237,10 +19009,6 @@ test-app-devnull_1.0_all.snap: FAIL
844 "manual_review": false,
845 "text": "OK"
846 },
847- "lint-snap-v2:snap_type_valid": {
848- "manual_review": false,
849- "text": "OK"
850- },
851 "lint-snap-v2:summary": {
852 "manual_review": false,
853 "text": "OK"
854@@ -19433,10 +19201,6 @@ test-bad-desktop-file-icon_1_all.snap: FAIL
855 "manual_review": false,
856 "text": "OK"
857 },
858- "lint-snap-v2:snap_type_valid": {
859- "manual_review": false,
860- "text": "OK"
861- },
862 "lint-snap-v2:summary": {
863 "manual_review": false,
864 "text": "summary is too short: 'my summary'"
865@@ -19618,10 +19382,6 @@ test-bad-desktop-file-icon_1_all.snap: FAIL
866 "manual_review": false,
867 "text": "OK"
868 },
869- "lint-snap-v2:snap_type_valid": {
870- "manual_review": false,
871- "text": "OK"
872- },
873 "lint-snap-v2:summary": {
874 "manual_review": false,
875 "text": "summary is too short: 'my summary'"
876@@ -19880,10 +19640,6 @@ test-bad-unicode_0_all.snap: FAIL
877 "manual_review": false,
878 "text": "OK"
879 },
880- "lint-snap-v2:snap_type_valid": {
881- "manual_review": false,
882- "text": "OK"
883- },
884 "lint-snap-v2:summary": {
885 "manual_review": false,
886 "text": "summary is too short: 'invalid \u200b'"
887@@ -20060,10 +19816,6 @@ test-bad-unicode_0_all.snap: FAIL
888 "manual_review": false,
889 "text": "OK"
890 },
891- "lint-snap-v2:snap_type_valid": {
892- "manual_review": false,
893- "text": "OK"
894- },
895 "lint-snap-v2:summary": {
896 "manual_review": false,
897 "text": "summary is too short: 'invalid \u200b'"
898@@ -20195,10 +19947,6 @@ test-base-devnull_1.0_all.snap: FAIL
899 "manual_review": false,
900 "text": "OK"
901 },
902- "lint-snap-v2:snap_type_valid": {
903- "manual_review": false,
904- "text": "OK"
905- },
906 "lint-snap-v2:summary": {
907 "manual_review": false,
908 "text": "OK"
909@@ -20304,10 +20052,6 @@ test-base-devnull_1.0_all.snap: FAIL
910 "manual_review": false,
911 "text": "OK"
912 },
913- "lint-snap-v2:snap_type_valid": {
914- "manual_review": false,
915- "text": "OK"
916- },
917 "lint-snap-v2:summary": {
918 "manual_review": false,
919 "text": "OK"
920@@ -20462,10 +20206,6 @@ test-base-disallowed_0_all.snap: FAIL
921 "manual_review": false,
922 "text": "OK"
923 },
924- "lint-snap-v2:snap_type_valid": {
925- "manual_review": false,
926- "text": "OK"
927- },
928 "lint-snap-v2:summary": {
929 "manual_review": false,
930 "text": "summary is too short: 'my summary'"
931@@ -20626,10 +20366,6 @@ test-base-disallowed_0_all.snap: FAIL
932 "manual_review": false,
933 "text": "OK"
934 },
935- "lint-snap-v2:snap_type_valid": {
936- "manual_review": false,
937- "text": "OK"
938- },
939 "lint-snap-v2:summary": {
940 "manual_review": false,
941 "text": "summary is too short: 'my summary'"
942@@ -20757,10 +20493,6 @@ test-base-missing-mountpoint_1.0_all.snap: FAIL
943 "manual_review": false,
944 "text": "OK"
945 },
946- "lint-snap-v2:snap_type_valid": {
947- "manual_review": false,
948- "text": "OK"
949- },
950 "lint-snap-v2:summary": {
951 "manual_review": false,
952 "text": "OK"
953@@ -20861,10 +20593,6 @@ test-base-missing-mountpoint_1.0_all.snap: FAIL
954 "manual_review": false,
955 "text": "OK"
956 },
957- "lint-snap-v2:snap_type_valid": {
958- "manual_review": false,
959- "text": "OK"
960- },
961 "lint-snap-v2:summary": {
962 "manual_review": false,
963 "text": "OK"
964@@ -21060,10 +20788,6 @@ test-base-slots-plugs_1.0_all.snap: FAIL
965 "manual_review": false,
966 "text": "OK"
967 },
968- "lint-snap-v2:snap_type_valid": {
969- "manual_review": false,
970- "text": "OK"
971- },
972 "lint-snap-v2:summary": {
973 "manual_review": false,
974 "text": "OK"
975@@ -21258,10 +20982,6 @@ test-base-slots-plugs_1.0_all.snap: FAIL
976 "manual_review": false,
977 "text": "OK"
978 },
979- "lint-snap-v2:snap_type_valid": {
980- "manual_review": false,
981- "text": "OK"
982- },
983 "lint-snap-v2:summary": {
984 "manual_review": false,
985 "text": "OK"
986@@ -21430,10 +21150,6 @@ test-check-notices-esm-apps_0.1_amd64.snap: pass
987 "manual_review": false,
988 "text": "OK"
989 },
990- "lint-snap-v2:snap_type_valid": {
991- "manual_review": false,
992- "text": "OK"
993- },
994 "lint-snap-v2:summary": {
995 "manual_review": false,
996 "text": "OK"
997@@ -21593,10 +21309,6 @@ test-check-notices-esm-apps_0.1_amd64.snap: pass
998 "manual_review": false,
999 "text": "OK"
1000 },
1001- "lint-snap-v2:snap_type_valid": {
1002- "manual_review": false,
1003- "text": "OK"
1004- },
1005 "lint-snap-v2:summary": {
1006 "manual_review": false,
1007 "text": "OK"
1008@@ -21761,10 +21473,6 @@ test-check-notices-needed_0.1_amd64.snap: pass
1009 "manual_review": false,
1010 "text": "OK"
1011 },
1012- "lint-snap-v2:snap_type_valid": {
1013- "manual_review": false,
1014- "text": "OK"
1015- },
1016 "lint-snap-v2:summary": {
1017 "manual_review": false,
1018 "text": "OK"
1019@@ -21924,10 +21632,6 @@ test-check-notices-needed_0.1_amd64.snap: pass
1020 "manual_review": false,
1021 "text": "OK"
1022 },
1023- "lint-snap-v2:snap_type_valid": {
1024- "manual_review": false,
1025- "text": "OK"
1026- },
1027 "lint-snap-v2:summary": {
1028 "manual_review": false,
1029 "text": "OK"
1030@@ -22101,10 +21805,6 @@ test-check-notices-primed-stage-packages-needed_0.1_amd64.snap: FAIL
1031 "manual_review": false,
1032 "text": "OK"
1033 },
1034- "lint-snap-v2:snap_type_valid": {
1035- "manual_review": false,
1036- "text": "OK"
1037- },
1038 "lint-snap-v2:summary": {
1039 "manual_review": false,
1040 "text": "OK"
1041@@ -22269,10 +21969,6 @@ test-check-notices-primed-stage-packages-needed_0.1_amd64.snap: FAIL
1042 "manual_review": false,
1043 "text": "OK"
1044 },
1045- "lint-snap-v2:snap_type_valid": {
1046- "manual_review": false,
1047- "text": "OK"
1048- },
1049 "lint-snap-v2:summary": {
1050 "manual_review": false,
1051 "text": "OK"
1052@@ -22446,10 +22142,6 @@ test-check-notices-primed-stage-packages-needed_0.2_amd64.snap: FAIL
1053 "manual_review": false,
1054 "text": "OK"
1055 },
1056- "lint-snap-v2:snap_type_valid": {
1057- "manual_review": false,
1058- "text": "OK"
1059- },
1060 "lint-snap-v2:summary": {
1061 "manual_review": false,
1062 "text": "OK"
1063@@ -22614,10 +22306,6 @@ test-check-notices-primed-stage-packages-needed_0.2_amd64.snap: FAIL
1064 "manual_review": false,
1065 "text": "OK"
1066 },
1067- "lint-snap-v2:snap_type_valid": {
1068- "manual_review": false,
1069- "text": "OK"
1070- },
1071 "lint-snap-v2:summary": {
1072 "manual_review": false,
1073 "text": "OK"
1074@@ -22782,10 +22470,6 @@ test-check-notices-primed-stage-packages_0.1_amd64.snap: pass
1075 "manual_review": false,
1076 "text": "OK"
1077 },
1078- "lint-snap-v2:snap_type_valid": {
1079- "manual_review": false,
1080- "text": "OK"
1081- },
1082 "lint-snap-v2:summary": {
1083 "manual_review": false,
1084 "text": "OK"
1085@@ -22945,10 +22629,6 @@ test-check-notices-primed-stage-packages_0.1_amd64.snap: pass
1086 "manual_review": false,
1087 "text": "OK"
1088 },
1089- "lint-snap-v2:snap_type_valid": {
1090- "manual_review": false,
1091- "text": "OK"
1092- },
1093 "lint-snap-v2:summary": {
1094 "manual_review": false,
1095 "text": "OK"
1096@@ -23113,10 +22793,6 @@ test-check-notices_0.1_amd64.snap: pass
1097 "manual_review": false,
1098 "text": "OK"
1099 },
1100- "lint-snap-v2:snap_type_valid": {
1101- "manual_review": false,
1102- "text": "OK"
1103- },
1104 "lint-snap-v2:summary": {
1105 "manual_review": false,
1106 "text": "OK"
1107@@ -23276,10 +22952,6 @@ test-check-notices_0.1_amd64.snap: pass
1108 "manual_review": false,
1109 "text": "OK"
1110 },
1111- "lint-snap-v2:snap_type_valid": {
1112- "manual_review": false,
1113- "text": "OK"
1114- },
1115 "lint-snap-v2:summary": {
1116 "manual_review": false,
1117 "text": "OK"
1118@@ -23471,10 +23143,6 @@ test-classic_0_all.snap: FAIL
1119 "manual_review": false,
1120 "text": "OK"
1121 },
1122- "lint-snap-v2:snap_type_valid": {
1123- "manual_review": false,
1124- "text": "OK"
1125- },
1126 "lint-snap-v2:summary": {
1127 "manual_review": false,
1128 "text": "summary is too short: 'my summary'"
1129@@ -23664,10 +23332,6 @@ test-classic_0_all.snap: FAIL
1130 "manual_review": false,
1131 "text": "OK"
1132 },
1133- "lint-snap-v2:snap_type_valid": {
1134- "manual_review": false,
1135- "text": "OK"
1136- },
1137 "lint-snap-v2:summary": {
1138 "manual_review": false,
1139 "text": "summary is too short: 'my summary'"
1140@@ -23852,10 +23516,6 @@ test-command-with-args_0_all.snap: pass
1141 "manual_review": false,
1142 "text": "OK"
1143 },
1144- "lint-snap-v2:snap_type_valid": {
1145- "manual_review": false,
1146- "text": "OK"
1147- },
1148 "lint-snap-v2:summary": {
1149 "manual_review": false,
1150 "text": "summary is too short: 'my summary'"
1151@@ -24035,10 +23695,6 @@ test-command-with-args_0_all.snap: pass
1152 "manual_review": false,
1153 "text": "OK"
1154 },
1155- "lint-snap-v2:snap_type_valid": {
1156- "manual_review": false,
1157- "text": "OK"
1158- },
1159 "lint-snap-v2:summary": {
1160 "manual_review": false,
1161 "text": "summary is too short: 'my summary'"
1162@@ -24235,10 +23891,6 @@ test-common-id_0_all.snap: pass
1163 "manual_review": false,
1164 "text": "OK"
1165 },
1166- "lint-snap-v2:snap_type_valid": {
1167- "manual_review": false,
1168- "text": "OK"
1169- },
1170 "lint-snap-v2:summary": {
1171 "manual_review": false,
1172 "text": "summary is too short: 'my summary'"
1173@@ -24430,10 +24082,6 @@ test-common-id_0_all.snap: pass
1174 "manual_review": false,
1175 "text": "OK"
1176 },
1177- "lint-snap-v2:snap_type_valid": {
1178- "manual_review": false,
1179- "text": "OK"
1180- },
1181 "lint-snap-v2:summary": {
1182 "manual_review": false,
1183 "text": "summary is too short: 'my summary'"
1184@@ -24639,10 +24287,6 @@ test-completion_1.0_all.snap: pass
1185 "manual_review": false,
1186 "text": "OK"
1187 },
1188- "lint-snap-v2:snap_type_valid": {
1189- "manual_review": false,
1190- "text": "OK"
1191- },
1192 "lint-snap-v2:summary_present": {
1193 "manual_review": false,
1194 "text": "OK (optional summary field not specified)"
1195@@ -24839,10 +24483,6 @@ test-completion_1.0_all.snap: pass
1196 "manual_review": false,
1197 "text": "OK"
1198 },
1199- "lint-snap-v2:snap_type_valid": {
1200- "manual_review": false,
1201- "text": "OK"
1202- },
1203 "lint-snap-v2:summary_present": {
1204 "manual_review": false,
1205 "text": "OK (optional summary field not specified)"
1206@@ -25172,10 +24812,6 @@ test-content_0.1_all.snap: pass
1207 "manual_review": false,
1208 "text": "OK"
1209 },
1210- "lint-snap-v2:snap_type_valid": {
1211- "manual_review": false,
1212- "text": "OK"
1213- },
1214 "lint-snap-v2:summary": {
1215 "manual_review": false,
1216 "text": "OK"
1217@@ -25500,10 +25136,6 @@ test-content_0.1_all.snap: pass
1218 "manual_review": false,
1219 "text": "OK"
1220 },
1221- "lint-snap-v2:snap_type_valid": {
1222- "manual_review": false,
1223- "text": "OK"
1224- },
1225 "lint-snap-v2:summary": {
1226 "manual_review": false,
1227 "text": "OK"
1228@@ -25640,10 +25272,6 @@ test-core-with-primed-staged_16-2.37.2_amd64.snap: FAIL
1229 "manual_review": false,
1230 "text": "OK"
1231 },
1232- "lint-snap-v2:snap_type_valid": {
1233- "manual_review": false,
1234- "text": "OK"
1235- },
1236 "lint-snap-v2:summary": {
1237 "manual_review": false,
1238 "text": "OK"
1239@@ -25755,10 +25383,6 @@ test-core-with-primed-staged_16-2.37.2_amd64.snap: FAIL
1240 "manual_review": false,
1241 "text": "OK"
1242 },
1243- "lint-snap-v2:snap_type_valid": {
1244- "manual_review": false,
1245- "text": "OK"
1246- },
1247 "lint-snap-v2:summary": {
1248 "manual_review": false,
1249 "text": "OK"
1250@@ -25879,10 +25503,6 @@ test-core_16-2.37.2_amd64.snap: FAIL
1251 "manual_review": false,
1252 "text": "OK"
1253 },
1254- "lint-snap-v2:snap_type_valid": {
1255- "manual_review": false,
1256- "text": "OK"
1257- },
1258 "lint-snap-v2:summary": {
1259 "manual_review": false,
1260 "text": "OK"
1261@@ -25994,10 +25614,6 @@ test-core_16-2.37.2_amd64.snap: FAIL
1262 "manual_review": false,
1263 "text": "OK"
1264 },
1265- "lint-snap-v2:snap_type_valid": {
1266- "manual_review": false,
1267- "text": "OK"
1268- },
1269 "lint-snap-v2:summary": {
1270 "manual_review": false,
1271 "text": "OK"
1272@@ -26191,10 +25807,6 @@ test-desktop-file_1_all.snap: pass
1273 "manual_review": false,
1274 "text": "OK"
1275 },
1276- "lint-snap-v2:snap_type_valid": {
1277- "manual_review": false,
1278- "text": "OK"
1279- },
1280 "lint-snap-v2:summary": {
1281 "manual_review": false,
1282 "text": "summary is too short: 'my summary'"
1283@@ -26399,10 +26011,6 @@ test-desktop-file_1_all.snap: pass
1284 "manual_review": false,
1285 "text": "OK"
1286 },
1287- "lint-snap-v2:snap_type_valid": {
1288- "manual_review": false,
1289- "text": "OK"
1290- },
1291 "lint-snap-v2:summary": {
1292 "manual_review": false,
1293 "text": "summary is too short: 'my summary'"
1294@@ -26568,10 +26176,6 @@ test-dir-perms_0_amd64.snap: FAIL
1295 "manual_review": false,
1296 "text": "OK"
1297 },
1298- "lint-snap-v2:snap_type_valid": {
1299- "manual_review": false,
1300- "text": "OK"
1301- },
1302 "lint-snap-v2:summary": {
1303 "manual_review": false,
1304 "text": "summary is too short: 'my summary'"
1305@@ -26725,10 +26329,6 @@ test-dir-perms_0_amd64.snap: FAIL
1306 "manual_review": false,
1307 "text": "OK"
1308 },
1309- "lint-snap-v2:snap_type_valid": {
1310- "manual_review": false,
1311- "text": "OK"
1312- },
1313 "lint-snap-v2:summary": {
1314 "manual_review": false,
1315 "text": "summary is too short: 'my summary'"
1316@@ -26867,10 +26467,6 @@ test-dpkg-list-app_1.0_amd64.snap: pass
1317 "manual_review": false,
1318 "text": "OK"
1319 },
1320- "lint-snap-v2:snap_type_valid": {
1321- "manual_review": false,
1322- "text": "OK"
1323- },
1324 "lint-snap-v2:summary": {
1325 "manual_review": false,
1326 "text": "OK"
1327@@ -26990,10 +26586,6 @@ test-dpkg-list-app_1.0_amd64.snap: pass
1328 "manual_review": false,
1329 "text": "OK"
1330 },
1331- "lint-snap-v2:snap_type_valid": {
1332- "manual_review": false,
1333- "text": "OK"
1334- },
1335 "lint-snap-v2:summary": {
1336 "manual_review": false,
1337 "text": "OK"
1338@@ -27246,10 +26838,6 @@ test-env_0.1_all.snap: pass
1339 "manual_review": false,
1340 "text": "OK"
1341 },
1342- "lint-snap-v2:snap_type_valid": {
1343- "manual_review": false,
1344- "text": "OK"
1345- },
1346 "lint-snap-v2:summary": {
1347 "manual_review": false,
1348 "text": "OK"
1349@@ -27525,10 +27113,6 @@ test-env_0.1_all.snap: pass
1350 "manual_review": false,
1351 "text": "OK"
1352 },
1353- "lint-snap-v2:snap_type_valid": {
1354- "manual_review": false,
1355- "text": "OK"
1356- },
1357 "lint-snap-v2:summary": {
1358 "manual_review": false,
1359 "text": "OK"
1360@@ -27707,10 +27291,6 @@ test-execstack_0_amd64.snap: FAIL
1361 "manual_review": false,
1362 "text": "OK"
1363 },
1364- "lint-snap-v2:snap_type_valid": {
1365- "manual_review": false,
1366- "text": "OK"
1367- },
1368 "lint-snap-v2:summary": {
1369 "manual_review": false,
1370 "text": "summary is too short: 'my summary'"
1371@@ -27863,10 +27443,6 @@ test-execstack_0_amd64.snap: FAIL
1372 "manual_review": false,
1373 "text": "OK"
1374 },
1375- "lint-snap-v2:snap_type_valid": {
1376- "manual_review": false,
1377- "text": "OK"
1378- },
1379 "lint-snap-v2:summary": {
1380 "manual_review": false,
1381 "text": "summary is too short: 'my summary'"
1382@@ -28019,10 +27595,6 @@ test-grade-and-confinement_0.1_all.snap: pass
1383 "manual_review": false,
1384 "text": "OK"
1385 },
1386- "lint-snap-v2:snap_type_valid": {
1387- "manual_review": false,
1388- "text": "OK"
1389- },
1390 "lint-snap-v2:summary": {
1391 "manual_review": false,
1392 "text": "OK"
1393@@ -28174,10 +27746,6 @@ test-grade-and-confinement_0.1_all.snap: pass
1394 "manual_review": false,
1395 "text": "OK"
1396 },
1397- "lint-snap-v2:snap_type_valid": {
1398- "manual_review": false,
1399- "text": "OK"
1400- },
1401 "lint-snap-v2:summary": {
1402 "manual_review": false,
1403 "text": "OK"
1404@@ -28330,10 +27898,6 @@ test-gzip_1.snap: FAIL
1405 "manual_review": false,
1406 "text": "OK"
1407 },
1408- "lint-snap-v2:snap_type_valid": {
1409- "manual_review": false,
1410- "text": "OK"
1411- },
1412 "lint-snap-v2:summary": {
1413 "manual_review": false,
1414 "text": "OK"
1415@@ -28478,10 +28042,6 @@ test-gzip_1.snap: FAIL
1416 "manual_review": false,
1417 "text": "OK"
1418 },
1419- "lint-snap-v2:snap_type_valid": {
1420- "manual_review": false,
1421- "text": "OK"
1422- },
1423 "lint-snap-v2:summary": {
1424 "manual_review": false,
1425 "text": "OK"
1426@@ -28903,10 +28463,6 @@ test-hello-dbus_2_amd64.snap: FAIL
1427 "manual_review": false,
1428 "text": "OK"
1429 },
1430- "lint-snap-v2:snap_type_valid": {
1431- "manual_review": false,
1432- "text": "OK"
1433- },
1434 "lint-snap-v2:summary": {
1435 "manual_review": false,
1436 "text": "OK"
1437@@ -29328,10 +28884,6 @@ test-hello-dbus_2_amd64.snap: FAIL
1438 "manual_review": false,
1439 "text": "OK"
1440 },
1441- "lint-snap-v2:snap_type_valid": {
1442- "manual_review": false,
1443- "text": "OK"
1444- },
1445 "lint-snap-v2:summary": {
1446 "manual_review": false,
1447 "text": "OK"
1448@@ -29566,10 +29118,6 @@ test-home-read-attrib_0.1_amd64.snap: FAIL
1449 "manual_review": false,
1450 "text": "OK"
1451 },
1452- "lint-snap-v2:snap_type_valid": {
1453- "manual_review": false,
1454- "text": "OK"
1455- },
1456 "lint-snap-v2:summary": {
1457 "manual_review": false,
1458 "text": "summary is too short: 'This is a test snap'"
1459@@ -29783,10 +29331,6 @@ test-home-read-attrib_0.1_amd64.snap: FAIL
1460 "manual_review": false,
1461 "text": "OK"
1462 },
1463- "lint-snap-v2:snap_type_valid": {
1464- "manual_review": false,
1465- "text": "OK"
1466- },
1467 "lint-snap-v2:summary": {
1468 "manual_review": false,
1469 "text": "summary is too short: 'This is a test snap'"
1470@@ -30196,10 +29740,6 @@ test-hooks_0_all.snap: pass
1471 "manual_review": false,
1472 "text": "OK"
1473 },
1474- "lint-snap-v2:snap_type_valid": {
1475- "manual_review": false,
1476- "text": "OK"
1477- },
1478 "lint-snap-v2:summary": {
1479 "manual_review": false,
1480 "text": "OK"
1481@@ -30608,10 +30148,6 @@ test-hooks_0_all.snap: pass
1482 "manual_review": false,
1483 "text": "OK"
1484 },
1485- "lint-snap-v2:snap_type_valid": {
1486- "manual_review": false,
1487- "text": "OK"
1488- },
1489 "lint-snap-v2:summary": {
1490 "manual_review": false,
1491 "text": "OK"
1492@@ -30832,10 +30368,6 @@ test-install-stop-and-refresh-modes_0.1_all.snap: pass
1493 "manual_review": false,
1494 "text": "OK"
1495 },
1496- "lint-snap-v2:snap_type_valid": {
1497- "manual_review": false,
1498- "text": "OK"
1499- },
1500 "lint-snap-v2:stop-mode:sigterm": {
1501 "manual_review": false,
1502 "text": "OK"
1503@@ -31059,10 +30591,6 @@ test-install-stop-and-refresh-modes_0.1_all.snap: pass
1504 "manual_review": false,
1505 "text": "OK"
1506 },
1507- "lint-snap-v2:snap_type_valid": {
1508- "manual_review": false,
1509- "text": "OK"
1510- },
1511 "lint-snap-v2:stop-mode:sigterm": {
1512 "manual_review": false,
1513 "text": "OK"
1514@@ -31207,10 +30735,6 @@ test-link_0.1_all.snap: pass
1515 "manual_review": false,
1516 "text": "OK"
1517 },
1518- "lint-snap-v2:snap_type_valid": {
1519- "manual_review": false,
1520- "text": "OK"
1521- },
1522 "lint-snap-v2:summary": {
1523 "manual_review": false,
1524 "text": "OK"
1525@@ -31322,10 +30846,6 @@ test-link_0.1_all.snap: pass
1526 "manual_review": false,
1527 "text": "OK"
1528 },
1529- "lint-snap-v2:snap_type_valid": {
1530- "manual_review": false,
1531- "text": "OK"
1532- },
1533 "lint-snap-v2:summary": {
1534 "manual_review": false,
1535 "text": "OK"
1536@@ -31458,10 +30978,6 @@ test-lzo_1.snap: pass
1537 "manual_review": false,
1538 "text": "OK"
1539 },
1540- "lint-snap-v2:snap_type_valid": {
1541- "manual_review": false,
1542- "text": "OK"
1543- },
1544 "lint-snap-v2:summary": {
1545 "manual_review": false,
1546 "text": "OK"
1547@@ -31605,10 +31121,6 @@ test-lzo_1.snap: pass
1548 "manual_review": false,
1549 "text": "OK"
1550 },
1551- "lint-snap-v2:snap_type_valid": {
1552- "manual_review": false,
1553- "text": "OK"
1554- },
1555 "lint-snap-v2:summary": {
1556 "manual_review": false,
1557 "text": "OK"
1558@@ -31859,10 +31371,6 @@ test-mir-xwayland_0_all.snap: FAIL
1559 "manual_review": false,
1560 "text": "OK"
1561 },
1562- "lint-snap-v2:snap_type_valid": {
1563- "manual_review": false,
1564- "text": "OK"
1565- },
1566 "lint-snap-v2:summary": {
1567 "manual_review": false,
1568 "text": "summary is too short: 'my summary'"
1569@@ -32108,10 +31616,6 @@ test-mir-xwayland_0_all.snap: FAIL
1570 "manual_review": false,
1571 "text": "OK"
1572 },
1573- "lint-snap-v2:snap_type_valid": {
1574- "manual_review": false,
1575- "text": "OK"
1576- },
1577 "lint-snap-v2:summary": {
1578 "manual_review": false,
1579 "text": "summary is too short: 'my summary'"
1580@@ -32343,10 +31847,6 @@ test-missing-required-attributes_0_all.snap: FAIL
1581 "manual_review": false,
1582 "text": "OK"
1583 },
1584- "lint-snap-v2:snap_type_valid": {
1585- "manual_review": false,
1586- "text": "OK"
1587- },
1588 "lint-snap-v2:summary": {
1589 "manual_review": false,
1590 "text": "summary is too short: 'my summary'"
1591@@ -32561,10 +32061,6 @@ test-missing-required-attributes_0_all.snap: FAIL
1592 "manual_review": false,
1593 "text": "OK"
1594 },
1595- "lint-snap-v2:snap_type_valid": {
1596- "manual_review": false,
1597- "text": "OK"
1598- },
1599 "lint-snap-v2:summary": {
1600 "manual_review": false,
1601 "text": "summary is too short: 'my summary'"
1602@@ -32758,10 +32254,6 @@ test-mpris-name-matches_0_amd64.snap: FAIL
1603 "manual_review": false,
1604 "text": "OK"
1605 },
1606- "lint-snap-v2:snap_type_valid": {
1607- "manual_review": false,
1608- "text": "OK"
1609- },
1610 "lint-snap-v2:summary": {
1611 "manual_review": false,
1612 "text": "summary is too short: 'my summary'"
1613@@ -32942,10 +32434,6 @@ test-mpris-name-matches_0_amd64.snap: FAIL
1614 "manual_review": false,
1615 "text": "OK"
1616 },
1617- "lint-snap-v2:snap_type_valid": {
1618- "manual_review": false,
1619- "text": "OK"
1620- },
1621 "lint-snap-v2:summary": {
1622 "manual_review": false,
1623 "text": "summary is too short: 'my summary'"
1624@@ -33135,10 +32623,6 @@ test-mpris-name-mismatch_0_amd64.snap: FAIL
1625 "manual_review": false,
1626 "text": "OK"
1627 },
1628- "lint-snap-v2:snap_type_valid": {
1629- "manual_review": false,
1630- "text": "OK"
1631- },
1632 "lint-snap-v2:summary": {
1633 "manual_review": false,
1634 "text": "summary is too short: 'my summary'"
1635@@ -33319,10 +32803,6 @@ test-mpris-name-mismatch_0_amd64.snap: FAIL
1636 "manual_review": false,
1637 "text": "OK"
1638 },
1639- "lint-snap-v2:snap_type_valid": {
1640- "manual_review": false,
1641- "text": "OK"
1642- },
1643 "lint-snap-v2:summary": {
1644 "manual_review": false,
1645 "text": "summary is too short: 'my summary'"
1646@@ -33492,10 +32972,6 @@ test-mpris_0_amd64.snap: pass
1647 "manual_review": false,
1648 "text": "OK"
1649 },
1650- "lint-snap-v2:snap_type_valid": {
1651- "manual_review": false,
1652- "text": "OK"
1653- },
1654 "lint-snap-v2:summary": {
1655 "manual_review": false,
1656 "text": "OK"
1657@@ -33660,10 +33136,6 @@ test-mpris_0_amd64.snap: pass
1658 "manual_review": false,
1659 "text": "OK"
1660 },
1661- "lint-snap-v2:snap_type_valid": {
1662- "manual_review": false,
1663- "text": "OK"
1664- },
1665 "lint-snap-v2:summary": {
1666 "manual_review": false,
1667 "text": "OK"
1668@@ -33824,10 +33296,6 @@ test-no-fragments_4.snap: FAIL
1669 "manual_review": false,
1670 "text": "OK"
1671 },
1672- "lint-snap-v2:snap_type_valid": {
1673- "manual_review": false,
1674- "text": "OK"
1675- },
1676 "lint-snap-v2:summary": {
1677 "manual_review": false,
1678 "text": "OK"
1679@@ -33980,10 +33448,6 @@ test-no-fragments_4.snap: FAIL
1680 "manual_review": false,
1681 "text": "OK"
1682 },
1683- "lint-snap-v2:snap_type_valid": {
1684- "manual_review": false,
1685- "text": "OK"
1686- },
1687 "lint-snap-v2:summary": {
1688 "manual_review": false,
1689 "text": "OK"
1690@@ -34166,10 +33630,6 @@ test-personal-files_1_all.snap: FAIL
1691 "manual_review": false,
1692 "text": "OK"
1693 },
1694- "lint-snap-v2:snap_type_valid": {
1695- "manual_review": false,
1696- "text": "OK"
1697- },
1698 "lint-snap-v2:summary": {
1699 "manual_review": false,
1700 "text": "OK"
1701@@ -34346,10 +33806,6 @@ test-personal-files_1_all.snap: FAIL
1702 "manual_review": false,
1703 "text": "OK"
1704 },
1705- "lint-snap-v2:snap_type_valid": {
1706- "manual_review": false,
1707- "text": "OK"
1708- },
1709 "lint-snap-v2:summary": {
1710 "manual_review": false,
1711 "text": "OK"
1712@@ -34523,10 +33979,6 @@ test-plug-cmd_1_all.snap: FAIL
1713 "manual_review": false,
1714 "text": "OK"
1715 },
1716- "lint-snap-v2:snap_type_valid": {
1717- "manual_review": false,
1718- "text": "OK"
1719- },
1720 "lint-snap-v2:summary": {
1721 "manual_review": false,
1722 "text": "OK"
1723@@ -34691,10 +34143,6 @@ test-plug-cmd_1_all.snap: FAIL
1724 "manual_review": false,
1725 "text": "OK"
1726 },
1727- "lint-snap-v2:snap_type_valid": {
1728- "manual_review": false,
1729- "text": "OK"
1730- },
1731 "lint-snap-v2:summary": {
1732 "manual_review": false,
1733 "text": "OK"
1734@@ -34850,10 +34298,6 @@ test-plug-hook-gadget_1_all.snap: FAIL
1735 "manual_review": false,
1736 "text": "OK"
1737 },
1738- "lint-snap-v2:snap_type_valid": {
1739- "manual_review": false,
1740- "text": "OK"
1741- },
1742 "lint-snap-v2:summary": {
1743 "manual_review": false,
1744 "text": "OK"
1745@@ -34982,10 +34426,6 @@ test-plug-hook-gadget_1_all.snap: FAIL
1746 "manual_review": false,
1747 "text": "OK"
1748 },
1749- "lint-snap-v2:snap_type_valid": {
1750- "manual_review": false,
1751- "text": "OK"
1752- },
1753 "lint-snap-v2:summary": {
1754 "manual_review": false,
1755 "text": "OK"
1756@@ -35155,10 +34595,6 @@ test-plug-hook_1_all.snap: FAIL
1757 "manual_review": false,
1758 "text": "OK"
1759 },
1760- "lint-snap-v2:snap_type_valid": {
1761- "manual_review": false,
1762- "text": "OK"
1763- },
1764 "lint-snap-v2:summary": {
1765 "manual_review": false,
1766 "text": "OK"
1767@@ -35335,10 +34771,6 @@ test-plug-hook_1_all.snap: FAIL
1768 "manual_review": false,
1769 "text": "OK"
1770 },
1771- "lint-snap-v2:snap_type_valid": {
1772- "manual_review": false,
1773- "text": "OK"
1774- },
1775 "lint-snap-v2:summary": {
1776 "manual_review": false,
1777 "text": "OK"
1778@@ -35502,10 +34934,6 @@ test-plug-reference-hook-gadget_1_all.snap: FAIL
1779 "manual_review": false,
1780 "text": "OK"
1781 },
1782- "lint-snap-v2:snap_type_valid": {
1783- "manual_review": false,
1784- "text": "OK"
1785- },
1786 "lint-snap-v2:summary": {
1787 "manual_review": false,
1788 "text": "OK"
1789@@ -35642,10 +35070,6 @@ test-plug-reference-hook-gadget_1_all.snap: FAIL
1790 "manual_review": false,
1791 "text": "OK"
1792 },
1793- "lint-snap-v2:snap_type_valid": {
1794- "manual_review": false,
1795- "text": "OK"
1796- },
1797 "lint-snap-v2:summary": {
1798 "manual_review": false,
1799 "text": "OK"
1800@@ -35823,10 +35247,6 @@ test-plug-reference-hook_1_all.snap: FAIL
1801 "manual_review": false,
1802 "text": "OK"
1803 },
1804- "lint-snap-v2:snap_type_valid": {
1805- "manual_review": false,
1806- "text": "OK"
1807- },
1808 "lint-snap-v2:summary": {
1809 "manual_review": false,
1810 "text": "OK"
1811@@ -36011,10 +35431,6 @@ test-plug-reference-hook_1_all.snap: FAIL
1812 "manual_review": false,
1813 "text": "OK"
1814 },
1815- "lint-snap-v2:snap_type_valid": {
1816- "manual_review": false,
1817- "text": "OK"
1818- },
1819 "lint-snap-v2:summary": {
1820 "manual_review": false,
1821 "text": "OK"
1822@@ -36196,10 +35612,6 @@ test-plug-reference_1_all.snap: FAIL
1823 "manual_review": false,
1824 "text": "OK"
1825 },
1826- "lint-snap-v2:snap_type_valid": {
1827- "manual_review": false,
1828- "text": "OK"
1829- },
1830 "lint-snap-v2:summary": {
1831 "manual_review": false,
1832 "text": "OK"
1833@@ -36372,10 +35784,6 @@ test-plug-reference_1_all.snap: FAIL
1834 "manual_review": false,
1835 "text": "OK"
1836 },
1837- "lint-snap-v2:snap_type_valid": {
1838- "manual_review": false,
1839- "text": "OK"
1840- },
1841 "lint-snap-v2:summary": {
1842 "manual_review": false,
1843 "text": "OK"
1844@@ -36549,10 +35957,6 @@ test-refresh-schedule_0.1_all.snap: FAIL
1845 "manual_review": false,
1846 "text": "OK"
1847 },
1848- "lint-snap-v2:snap_type_valid": {
1849- "manual_review": false,
1850- "text": "OK"
1851- },
1852 "lint-snap-v2:summary": {
1853 "manual_review": false,
1854 "text": "OK"
1855@@ -36717,10 +36121,6 @@ test-refresh-schedule_0.1_all.snap: FAIL
1856 "manual_review": false,
1857 "text": "OK"
1858 },
1859- "lint-snap-v2:snap_type_valid": {
1860- "manual_review": false,
1861- "text": "OK"
1862- },
1863 "lint-snap-v2:summary": {
1864 "manual_review": false,
1865 "text": "OK"
1866@@ -36912,10 +36312,6 @@ test-resquash-minimal_0.snap: FAIL
1867 "manual_review": false,
1868 "text": "OK"
1869 },
1870- "lint-snap-v2:snap_type_valid": {
1871- "manual_review": false,
1872- "text": "OK"
1873- },
1874 "lint-snap-v2:summary": {
1875 "manual_review": false,
1876 "text": "OK"
1877@@ -37093,10 +36489,6 @@ test-resquash-minimal_0.snap: FAIL
1878 "manual_review": false,
1879 "text": "OK"
1880 },
1881- "lint-snap-v2:snap_type_valid": {
1882- "manual_review": false,
1883- "text": "OK"
1884- },
1885 "lint-snap-v2:summary": {
1886 "manual_review": false,
1887 "text": "OK"
1888@@ -37267,10 +36659,6 @@ test-slot-cmd_1_all.snap: FAIL
1889 "manual_review": false,
1890 "text": "OK"
1891 },
1892- "lint-snap-v2:snap_type_valid": {
1893- "manual_review": false,
1894- "text": "OK"
1895- },
1896 "lint-snap-v2:summary": {
1897 "manual_review": false,
1898 "text": "OK"
1899@@ -37435,10 +36823,6 @@ test-slot-cmd_1_all.snap: FAIL
1900 "manual_review": false,
1901 "text": "OK"
1902 },
1903- "lint-snap-v2:snap_type_valid": {
1904- "manual_review": false,
1905- "text": "OK"
1906- },
1907 "lint-snap-v2:summary": {
1908 "manual_review": false,
1909 "text": "OK"
1910@@ -37624,10 +37008,6 @@ test-slot-hook_1_all.snap: FAIL
1911 "manual_review": false,
1912 "text": "OK"
1913 },
1914- "lint-snap-v2:snap_type_valid": {
1915- "manual_review": false,
1916- "text": "OK"
1917- },
1918 "lint-snap-v2:summary": {
1919 "manual_review": false,
1920 "text": "OK"
1921@@ -37804,10 +37184,6 @@ test-slot-hook_1_all.snap: FAIL
1922 "manual_review": false,
1923 "text": "OK"
1924 },
1925- "lint-snap-v2:snap_type_valid": {
1926- "manual_review": false,
1927- "text": "OK"
1928- },
1929 "lint-snap-v2:summary": {
1930 "manual_review": false,
1931 "text": "OK"
1932@@ -38001,10 +37377,6 @@ test-slot-reference-hook_1_all.snap: FAIL
1933 "manual_review": false,
1934 "text": "OK"
1935 },
1936- "lint-snap-v2:snap_type_valid": {
1937- "manual_review": false,
1938- "text": "OK"
1939- },
1940 "lint-snap-v2:summary": {
1941 "manual_review": false,
1942 "text": "OK"
1943@@ -38189,10 +37561,6 @@ test-slot-reference-hook_1_all.snap: FAIL
1944 "manual_review": false,
1945 "text": "OK"
1946 },
1947- "lint-snap-v2:snap_type_valid": {
1948- "manual_review": false,
1949- "text": "OK"
1950- },
1951 "lint-snap-v2:summary": {
1952 "manual_review": false,
1953 "text": "OK"
1954@@ -38374,10 +37742,6 @@ test-slot-reference_1_all.snap: FAIL
1955 "manual_review": false,
1956 "text": "OK"
1957 },
1958- "lint-snap-v2:snap_type_valid": {
1959- "manual_review": false,
1960- "text": "OK"
1961- },
1962 "lint-snap-v2:summary": {
1963 "manual_review": false,
1964 "text": "OK"
1965@@ -38550,10 +37914,6 @@ test-slot-reference_1_all.snap: FAIL
1966 "manual_review": false,
1967 "text": "OK"
1968 },
1969- "lint-snap-v2:snap_type_valid": {
1970- "manual_review": false,
1971- "text": "OK"
1972- },
1973 "lint-snap-v2:summary": {
1974 "manual_review": false,
1975 "text": "OK"
1976@@ -38731,10 +38091,6 @@ test-slot-toplevel_1_all.snap: FAIL
1977 "manual_review": false,
1978 "text": "OK"
1979 },
1980- "lint-snap-v2:snap_type_valid": {
1981- "manual_review": false,
1982- "text": "OK"
1983- },
1984 "lint-snap-v2:summary": {
1985 "manual_review": false,
1986 "text": "OK"
1987@@ -38903,10 +38259,6 @@ test-slot-toplevel_1_all.snap: FAIL
1988 "manual_review": false,
1989 "text": "OK"
1990 },
1991- "lint-snap-v2:snap_type_valid": {
1992- "manual_review": false,
1993- "text": "OK"
1994- },
1995 "lint-snap-v2:summary": {
1996 "manual_review": false,
1997 "text": "OK"
1998@@ -39071,10 +38423,6 @@ test-snapcraft-manifest-package-in-installed-snaps_0_amd64.snap: pass
1999 "manual_review": false,
2000 "text": "OK"
2001 },
2002- "lint-snap-v2:snap_type_valid": {
2003- "manual_review": false,
2004- "text": "OK"
2005- },
2006 "lint-snap-v2:summary": {
2007 "manual_review": false,
2008 "text": "summary is too short: 'my summary'"
2009@@ -39230,10 +38578,6 @@ test-snapcraft-manifest-package-in-installed-snaps_0_amd64.snap: pass
2010 "manual_review": false,
2011 "text": "OK"
2012 },
2013- "lint-snap-v2:snap_type_valid": {
2014- "manual_review": false,
2015- "text": "OK"
2016- },
2017 "lint-snap-v2:summary": {
2018 "manual_review": false,
2019 "text": "summary is too short: 'my summary'"
2020@@ -39394,10 +38738,6 @@ test-snapcraft-manifest-snapcraft-updated_0_amd64.snap: pass
2021 "manual_review": false,
2022 "text": "OK"
2023 },
2024- "lint-snap-v2:snap_type_valid": {
2025- "manual_review": false,
2026- "text": "OK"
2027- },
2028 "lint-snap-v2:summary": {
2029 "manual_review": false,
2030 "text": "summary is too short: 'my summary'"
2031@@ -39553,10 +38893,6 @@ test-snapcraft-manifest-snapcraft-updated_0_amd64.snap: pass
2032 "manual_review": false,
2033 "text": "OK"
2034 },
2035- "lint-snap-v2:snap_type_valid": {
2036- "manual_review": false,
2037- "text": "OK"
2038- },
2039 "lint-snap-v2:summary": {
2040 "manual_review": false,
2041 "text": "summary is too short: 'my summary'"
2042@@ -39717,10 +39053,6 @@ test-snapcraft-manifest-snapcraft-version-needed_0_amd64.snap: pass
2043 "manual_review": false,
2044 "text": "OK"
2045 },
2046- "lint-snap-v2:snap_type_valid": {
2047- "manual_review": false,
2048- "text": "OK"
2049- },
2050 "lint-snap-v2:summary": {
2051 "manual_review": false,
2052 "text": "summary is too short: 'my summary'"
2053@@ -39876,10 +39208,6 @@ test-snapcraft-manifest-snapcraft-version-needed_0_amd64.snap: pass
2054 "manual_review": false,
2055 "text": "OK"
2056 },
2057- "lint-snap-v2:snap_type_valid": {
2058- "manual_review": false,
2059- "text": "OK"
2060- },
2061 "lint-snap-v2:summary": {
2062 "manual_review": false,
2063 "text": "summary is too short: 'my summary'"
2064@@ -40040,10 +39368,6 @@ test-snapcraft-manifest-snapcraft-version_0_amd64.snap: pass
2065 "manual_review": false,
2066 "text": "OK"
2067 },
2068- "lint-snap-v2:snap_type_valid": {
2069- "manual_review": false,
2070- "text": "OK"
2071- },
2072 "lint-snap-v2:summary": {
2073 "manual_review": false,
2074 "text": "summary is too short: 'my summary'"
2075@@ -40199,10 +39523,6 @@ test-snapcraft-manifest-snapcraft-version_0_amd64.snap: pass
2076 "manual_review": false,
2077 "text": "OK"
2078 },
2079- "lint-snap-v2:snap_type_valid": {
2080- "manual_review": false,
2081- "text": "OK"
2082- },
2083 "lint-snap-v2:summary": {
2084 "manual_review": false,
2085 "text": "summary is too short: 'my summary'"
2086@@ -40363,10 +39683,6 @@ test-snapcraft-manifest-unittest_0_amd64.snap: pass
2087 "manual_review": false,
2088 "text": "OK"
2089 },
2090- "lint-snap-v2:snap_type_valid": {
2091- "manual_review": false,
2092- "text": "OK"
2093- },
2094 "lint-snap-v2:summary": {
2095 "manual_review": false,
2096 "text": "summary is too short: 'my summary'"
2097@@ -40522,10 +39838,6 @@ test-snapcraft-manifest-unittest_0_amd64.snap: pass
2098 "manual_review": false,
2099 "text": "OK"
2100 },
2101- "lint-snap-v2:snap_type_valid": {
2102- "manual_review": false,
2103- "text": "OK"
2104- },
2105 "lint-snap-v2:summary": {
2106 "manual_review": false,
2107 "text": "summary is too short: 'my summary'"
2108@@ -40686,10 +39998,6 @@ test-snapcraft-manifest_0_amd64.snap: pass
2109 "manual_review": false,
2110 "text": "OK"
2111 },
2112- "lint-snap-v2:snap_type_valid": {
2113- "manual_review": false,
2114- "text": "OK"
2115- },
2116 "lint-snap-v2:summary": {
2117 "manual_review": false,
2118 "text": "summary is too short: 'my summary'"
2119@@ -40845,10 +40153,6 @@ test-snapcraft-manifest_0_amd64.snap: pass
2120 "manual_review": false,
2121 "text": "OK"
2122 },
2123- "lint-snap-v2:snap_type_valid": {
2124- "manual_review": false,
2125- "text": "OK"
2126- },
2127 "lint-snap-v2:summary": {
2128 "manual_review": false,
2129 "text": "summary is too short: 'my summary'"
2130@@ -41061,10 +40365,6 @@ test-snapd-layout_1.0_all.snap: pass
2131 "manual_review": false,
2132 "text": "OK"
2133 },
2134- "lint-snap-v2:snap_type_valid": {
2135- "manual_review": false,
2136- "text": "OK"
2137- },
2138 "lint-snap-v2:summary": {
2139 "manual_review": false,
2140 "text": "OK"
2141@@ -41276,10 +40576,6 @@ test-snapd-layout_1.0_all.snap: pass
2142 "manual_review": false,
2143 "text": "OK"
2144 },
2145- "lint-snap-v2:snap_type_valid": {
2146- "manual_review": false,
2147- "text": "OK"
2148- },
2149 "lint-snap-v2:summary": {
2150 "manual_review": false,
2151 "text": "OK"
2152@@ -41444,10 +40740,6 @@ test-snapd-with-default-configure_3.snap: pass
2153 "manual_review": false,
2154 "text": "OK"
2155 },
2156- "lint-snap-v2:snap_type_valid": {
2157- "manual_review": false,
2158- "text": "OK"
2159- },
2160 "lint-snap-v2:summary": {
2161 "manual_review": false,
2162 "text": "OK"
2163@@ -41611,10 +40903,6 @@ test-snapd-with-default-configure_3.snap: pass
2164 "manual_review": false,
2165 "text": "OK"
2166 },
2167- "lint-snap-v2:snap_type_valid": {
2168- "manual_review": false,
2169- "text": "OK"
2170- },
2171 "lint-snap-v2:summary": {
2172 "manual_review": false,
2173 "text": "OK"
2174@@ -41756,10 +41044,6 @@ test-state-base_1_amd64.snap: FAIL
2175 "manual_review": false,
2176 "text": "OK"
2177 },
2178- "lint-snap-v2:snap_type_valid": {
2179- "manual_review": false,
2180- "text": "OK"
2181- },
2182 "lint-snap-v2:summary": {
2183 "manual_review": false,
2184 "text": "OK"
2185@@ -41868,10 +41152,6 @@ test-state-base_1_amd64.snap: FAIL
2186 "manual_review": false,
2187 "text": "OK"
2188 },
2189- "lint-snap-v2:snap_type_valid": {
2190- "manual_review": false,
2191- "text": "OK"
2192- },
2193 "lint-snap-v2:summary": {
2194 "manual_review": false,
2195 "text": "OK"
2196@@ -42025,10 +41305,6 @@ test-superprivileged-cmd_1_all.snap: FAIL
2197 "manual_review": false,
2198 "text": "OK"
2199 },
2200- "lint-snap-v2:snap_type_valid": {
2201- "manual_review": false,
2202- "text": "OK"
2203- },
2204 "lint-snap-v2:summary": {
2205 "manual_review": false,
2206 "text": "OK"
2207@@ -42193,10 +41469,6 @@ test-superprivileged-cmd_1_all.snap: FAIL
2208 "manual_review": false,
2209 "text": "OK"
2210 },
2211- "lint-snap-v2:snap_type_valid": {
2212- "manual_review": false,
2213- "text": "OK"
2214- },
2215 "lint-snap-v2:summary": {
2216 "manual_review": false,
2217 "text": "OK"
2218@@ -42378,10 +41650,6 @@ test-superprivileged-reference_1_all.snap: FAIL
2219 "manual_review": false,
2220 "text": "OK"
2221 },
2222- "lint-snap-v2:snap_type_valid": {
2223- "manual_review": false,
2224- "text": "OK"
2225- },
2226 "lint-snap-v2:summary": {
2227 "manual_review": false,
2228 "text": "OK"
2229@@ -42554,10 +41822,6 @@ test-superprivileged-reference_1_all.snap: FAIL
2230 "manual_review": false,
2231 "text": "OK"
2232 },
2233- "lint-snap-v2:snap_type_valid": {
2234- "manual_review": false,
2235- "text": "OK"
2236- },
2237 "lint-snap-v2:summary": {
2238 "manual_review": false,
2239 "text": "OK"
2240@@ -42743,10 +42007,6 @@ test-superprivileged-sneaky_1_all.snap: FAIL
2241 "manual_review": false,
2242 "text": "OK"
2243 },
2244- "lint-snap-v2:snap_type_valid": {
2245- "manual_review": false,
2246- "text": "OK"
2247- },
2248 "lint-snap-v2:summary": {
2249 "manual_review": false,
2250 "text": "OK"
2251@@ -42924,10 +42184,6 @@ test-superprivileged-sneaky_1_all.snap: FAIL
2252 "manual_review": false,
2253 "text": "OK"
2254 },
2255- "lint-snap-v2:snap_type_valid": {
2256- "manual_review": false,
2257- "text": "OK"
2258- },
2259 "lint-snap-v2:summary": {
2260 "manual_review": false,
2261 "text": "OK"
2262@@ -43114,10 +42370,6 @@ test-superprivileged-toplevel_1_all.snap: FAIL
2263 "manual_review": false,
2264 "text": "OK"
2265 },
2266- "lint-snap-v2:snap_type_valid": {
2267- "manual_review": false,
2268- "text": "OK"
2269- },
2270 "lint-snap-v2:summary": {
2271 "manual_review": false,
2272 "text": "OK"
2273@@ -43290,10 +42542,6 @@ test-superprivileged-toplevel_1_all.snap: FAIL
2274 "manual_review": false,
2275 "text": "OK"
2276 },
2277- "lint-snap-v2:snap_type_valid": {
2278- "manual_review": false,
2279- "text": "OK"
2280- },
2281 "lint-snap-v2:summary": {
2282 "manual_review": false,
2283 "text": "OK"
2284@@ -43450,10 +42698,6 @@ test-system-usernames_0_all.snap: pass
2285 "manual_review": false,
2286 "text": "OK"
2287 },
2288- "lint-snap-v2:snap_type_valid": {
2289- "manual_review": false,
2290- "text": "OK"
2291- },
2292 "lint-snap-v2:summary": {
2293 "manual_review": false,
2294 "text": "OK"
2295@@ -43613,10 +42857,6 @@ test-system-usernames_0_all.snap: pass
2296 "manual_review": false,
2297 "text": "OK"
2298 },
2299- "lint-snap-v2:snap_type_valid": {
2300- "manual_review": false,
2301- "text": "OK"
2302- },
2303 "lint-snap-v2:summary": {
2304 "manual_review": false,
2305 "text": "OK"
2306@@ -43876,10 +43116,6 @@ test-top-level-dbus-slot_1_amd64.snap: FAIL
2307 "manual_review": false,
2308 "text": "OK"
2309 },
2310- "lint-snap-v2:snap_type_valid": {
2311- "manual_review": false,
2312- "text": "OK"
2313- },
2314 "lint-snap-v2:summary": {
2315 "manual_review": false,
2316 "text": "OK"
2317@@ -44120,10 +43356,6 @@ test-top-level-dbus-slot_1_amd64.snap: FAIL
2318 "manual_review": false,
2319 "text": "OK"
2320 },
2321- "lint-snap-v2:snap_type_valid": {
2322- "manual_review": false,
2323- "text": "OK"
2324- },
2325 "lint-snap-v2:summary": {
2326 "manual_review": false,
2327 "text": "OK"
2328@@ -44244,10 +43476,6 @@ test-topdir-ro_1.0_all.snap: pass
2329 "manual_review": false,
2330 "text": "OK"
2331 },
2332- "lint-snap-v2:snap_type_valid": {
2333- "manual_review": false,
2334- "text": "OK"
2335- },
2336 "lint-snap-v2:summary": {
2337 "manual_review": false,
2338 "text": "OK"
2339@@ -44347,10 +43575,6 @@ test-topdir-ro_1.0_all.snap: pass
2340 "manual_review": false,
2341 "text": "OK"
2342 },
2343- "lint-snap-v2:snap_type_valid": {
2344- "manual_review": false,
2345- "text": "OK"
2346- },
2347 "lint-snap-v2:summary": {
2348 "manual_review": false,
2349 "text": "OK"
2350@@ -44516,10 +43740,6 @@ test-unity7-home_0.1_all.snap: pass
2351 "manual_review": false,
2352 "text": "OK"
2353 },
2354- "lint-snap-v2:snap_type_valid": {
2355- "manual_review": false,
2356- "text": "OK"
2357- },
2358 "lint-snap-v2:summary": {
2359 "manual_review": false,
2360 "text": "summary is too short: 'foo'"
2361@@ -44696,10 +43916,6 @@ test-unity7-home_0.1_all.snap: pass
2362 "manual_review": false,
2363 "text": "OK"
2364 },
2365- "lint-snap-v2:snap_type_valid": {
2366- "manual_review": false,
2367- "text": "OK"
2368- },
2369 "lint-snap-v2:summary": {
2370 "manual_review": false,
2371 "text": "summary is too short: 'foo'"
2372@@ -44853,10 +44069,6 @@ test-void-dir_0.1_all.snap: FAIL
2373 "manual_review": false,
2374 "text": "OK"
2375 },
2376- "lint-snap-v2:snap_type_valid": {
2377- "manual_review": false,
2378- "text": "OK"
2379- },
2380 "lint-snap-v2:summary": {
2381 "manual_review": false,
2382 "text": "summary is too short: 'foo'"
2383@@ -45002,10 +44214,6 @@ test-void-dir_0.1_all.snap: FAIL
2384 "manual_review": false,
2385 "text": "OK"
2386 },
2387- "lint-snap-v2:snap_type_valid": {
2388- "manual_review": false,
2389- "text": "OK"
2390- },
2391 "lint-snap-v2:summary": {
2392 "manual_review": false,
2393 "text": "summary is too short: 'foo'"
2394@@ -45185,10 +44393,6 @@ test-x11-home_0.1_all.snap: pass
2395 "manual_review": false,
2396 "text": "OK"
2397 },
2398- "lint-snap-v2:snap_type_valid": {
2399- "manual_review": false,
2400- "text": "OK"
2401- },
2402 "lint-snap-v2:summary": {
2403 "manual_review": false,
2404 "text": "summary is too short: 'foo'"
2405@@ -45361,10 +44565,6 @@ test-x11-home_0.1_all.snap: pass
2406 "manual_review": false,
2407 "text": "OK"
2408 },
2409- "lint-snap-v2:snap_type_valid": {
2410- "manual_review": false,
2411- "text": "OK"
2412- },
2413 "lint-snap-v2:summary": {
2414 "manual_review": false,
2415 "text": "summary is too short: 'foo'"
2416@@ -45526,10 +44726,6 @@ test-x11-no-desktop_0.1_all.snap: pass
2417 "manual_review": false,
2418 "text": "OK"
2419 },
2420- "lint-snap-v2:snap_type_valid": {
2421- "manual_review": false,
2422- "text": "OK"
2423- },
2424 "lint-snap-v2:summary": {
2425 "manual_review": false,
2426 "text": "summary is too short: 'foo'"
2427@@ -45686,10 +44882,6 @@ test-x11-no-desktop_0.1_all.snap: pass
2428 "manual_review": false,
2429 "text": "OK"
2430 },
2431- "lint-snap-v2:snap_type_valid": {
2432- "manual_review": false,
2433- "text": "OK"
2434- },
2435 "lint-snap-v2:summary": {
2436 "manual_review": false,
2437 "text": "summary is too short: 'foo'"
2438@@ -45809,10 +45001,6 @@ ubuntu-core_16.04.1+test1_amd64.snap: pass
2439 "manual_review": false,
2440 "text": "OK (override 'ubuntu-core' for 'type: os')"
2441 },
2442- "lint-snap-v2:snap_type_valid": {
2443- "manual_review": false,
2444- "text": "OK"
2445- },
2446 "lint-snap-v2:summary": {
2447 "manual_review": false,
2448 "text": "OK"
2449@@ -45907,10 +45095,6 @@ ubuntu-core_16.04.1+test1_amd64.snap: pass
2450 "manual_review": false,
2451 "text": "OK (override 'ubuntu-core' for 'type: os')"
2452 },
2453- "lint-snap-v2:snap_type_valid": {
2454- "manual_review": false,
2455- "text": "OK"
2456- },
2457 "lint-snap-v2:summary": {
2458 "manual_review": false,
2459 "text": "OK"
2460@@ -46156,10 +45340,6 @@ vlc_daily+test1_amd64.snap: pass
2461 "manual_review": false,
2462 "text": "OK"
2463 },
2464- "lint-snap-v2:snap_type_valid": {
2465- "manual_review": false,
2466- "text": "OK"
2467- },
2468 "lint-snap-v2:summary": {
2469 "manual_review": false,
2470 "text": "OK"
2471@@ -46416,10 +45596,6 @@ vlc_daily+test1_amd64.snap: pass
2472 "manual_review": false,
2473 "text": "OK"
2474 },
2475- "lint-snap-v2:snap_type_valid": {
2476- "manual_review": false,
2477- "text": "OK"
2478- },
2479 "lint-snap-v2:summary": {
2480 "manual_review": false,
2481 "text": "OK"
2482@@ -46604,10 +45780,6 @@ test-classic_0_all.snap: pass
2483 "manual_review": false,
2484 "text": "OK"
2485 },
2486- "lint-snap-v2:snap_type_valid": {
2487- "manual_review": false,
2488- "text": "OK"
2489- },
2490 "lint-snap-v2:summary": {
2491 "manual_review": false,
2492 "text": "summary is too short: 'my summary'"
2493@@ -46795,10 +45967,6 @@ test-classic_0_all.snap: pass
2494 "manual_review": false,
2495 "text": "OK"
2496 },
2497- "lint-snap-v2:snap_type_valid": {
2498- "manual_review": false,
2499- "text": "OK"
2500- },
2501 "lint-snap-v2:summary": {
2502 "manual_review": false,
2503 "text": "summary is too short: 'my summary'"
2504@@ -46983,10 +46151,6 @@ test-classic_0_all.snap: pass
2505 "manual_review": false,
2506 "text": "OK"
2507 },
2508- "lint-snap-v2:snap_type_valid": {
2509- "manual_review": false,
2510- "text": "OK"
2511- },
2512 "lint-snap-v2:summary": {
2513 "manual_review": false,
2514 "text": "OK"
2515@@ -124079,10 +123243,6 @@ hello-world_25.snap: FAIL
2516 "manual_review": false,
2517 "text": "OK"
2518 },
2519- "lint-snap-v2:snap_type_valid": {
2520- "manual_review": false,
2521- "text": "OK"
2522- },
2523 "lint-snap-v2:summary": {
2524 "manual_review": false,
2525 "text": "OK"
2526@@ -124386,10 +123546,6 @@ hello-world_25.snap: FAIL
2527 "manual_review": false,
2528 "text": "OK"
2529 },
2530- "lint-snap-v2:snap_type_valid": {
2531- "manual_review": false,
2532- "text": "OK"
2533- },
2534 "lint-snap-v2:summary": {
2535 "manual_review": false,
2536 "text": "OK"

Subscribers

People subscribed via source and target branches