Code review comment for ~jslarraz/review-tools:add-container-exceptions-and-tests-framework

Revision history for this message
Alex Murray (alexmurray) wrote :

Thanks for this - one comment though, normally exceptions have a class or type - so I would expect this to be called 'InvalidContainerExtension' say rather than just 'ContainerException' - or perhaps 'BaseContainerException' - just wondering whether you think the name should be changed?

« Back to merge proposal