review-tools

Merge ~jslarraz/review-tools:schema-add-version into review-tools:master

  1. Git
  2. lp:~jslarraz/review-tools
  3. schema-add-version
  4. Merge into master
Proposed by Jorge Sancho Larraz
Status: Merged
Merged at revision: c3a28787e76c59484ea433a10cca1dc114a3ca16
Proposed branch: ~jslarraz/review-tools:schema-add-version
Merge into: review-tools:master
Diff against target: 2675 lines (+64/-1049)
8 files modified
check-names.list (+0/-1)
reviewtools/schemas/snap.json (+8/-1)
reviewtools/sr_common.py (+0/-15)
reviewtools/sr_lint.py (+0/-22)
reviewtools/tests/schemas/test_schema_snap.py (+56/-1)
reviewtools/tests/test_sr_common.py (+0/-30)
reviewtools/tests/test_sr_lint.py (+0/-135)
tests/test.sh.expected (+0/-844)
Reviewer Review Type Date Requested Status
Alex Murray Approve
Review via email: mp+466176@code.launchpad.net

Commit message

many: perform snap version validation via schema

To post a comment you must log in.
Revision history for this message
Jorge Sancho Larraz (jslarraz) wrote :

reviewtools/tests/schemas/test_schema_against_store.py validates the current snap.yaml schema against all snaps in the store. No additional errors have been found in this version

Revision history for this message
Jorge Sancho Larraz (jslarraz) wrote (last edit ):

Add inline comment

Revision history for this message
Alex Murray (alexmurray) wrote :

LGTM - thanks @jslarraz.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/check-names.list b/check-names.list
2index f8491a6..8b3b789 100644
3--- a/check-names.list
4+++ b/check-names.list
5@@ -153,7 +153,6 @@ lint-snap-v2:unknown_stop_mode|
6 lint-snap-v2:valid_contents_for_architecture|
7 lint-snap-v2:valid_unicode|
8 lint-snap-v2:vcs_files|
9-lint-snap-v2:version_valid|
10 lint-snap-v2:watchdog-timeout_range|
11 lint-snap-v2:watchdog-timeout|
12 security-snap-v2:daemon_with_browser-support|
13diff --git a/reviewtools/schemas/snap.json b/reviewtools/schemas/snap.json
14index 3c239c4..471202e 100644
15--- a/reviewtools/schemas/snap.json
16+++ b/reviewtools/schemas/snap.json
17@@ -8,7 +8,14 @@
18 "pattern": "^(?:[a-z0-9]|(?<=[a-z0-9])-)*[a-z](?:[a-z0-9]|-(?=[a-z0-9]))*$",
19 "minLength": 2,
20 "maxLength": 40
21+ },
22+ "version": {
23+ "description": "A user facing version to display.",
24+ "$comment": "See https://forum.snapcraft.io/t/3974",
25+ "type": ["string", "number"],
26+ "pattern": "^[a-zA-Z0-9](?:[a-zA-Z0-9:.+~-]*[a-zA-Z0-9+~])?$",
27+ "maxLength": 32
28 }
29 },
30- "required": ["name"]
31+ "required": ["name", "version"]
32 }
33diff --git a/reviewtools/sr_common.py b/reviewtools/sr_common.py
34index fbd0472..a3a1132 100644
35--- a/reviewtools/sr_common.py
36+++ b/reviewtools/sr_common.py
37@@ -575,21 +575,6 @@ class SnapReview(Review):
38 return False
39 return True
40
41- def _verify_pkgversion(self, v):
42- """Verify package version"""
43- if not isinstance(v, (str, int, float)):
44- return False
45-
46- # see https://forum.snapcraft.io/t/3974, or
47- # http://people.canonical.com/~john/snap_version_validator_regexp.svg
48- _re_valid_version = re.compile(
49- r"^[a-zA-Z0-9](?:[a-zA-Z0-9:.+~-]{0,30}[a-zA-Z0-9+~])?$"
50- )
51- if _re_valid_version.match(str(v)):
52- return True
53-
54- return False
55-
56 def _verify_appname(self, n):
57 """Verify app name"""
58 pat = re.compile(r"^[a-zA-Z0-9](?:-?[a-zA-Z0-9])*$")
59diff --git a/reviewtools/sr_lint.py b/reviewtools/sr_lint.py
60index 3ddaf3f..87d02c6 100644
61--- a/reviewtools/sr_lint.py
62+++ b/reviewtools/sr_lint.py
63@@ -224,28 +224,6 @@ class SnapReviewLint(SnapReview):
64 manual_review = True
65 self._add_result(t, n, s, manual_review=manual_review)
66
67- def check_version(self):
68- """Check package version"""
69- t = "info"
70- n = self._get_check_name("version_valid")
71- s = "OK"
72- if "version" not in self.snap_yaml:
73- t = "error"
74- s = "could not find 'version' in yaml"
75- elif (
76- isinstance(self.snap_yaml["version"], (str, int, float))
77- and len(str(self.snap_yaml["version"])) > 32
78- ):
79- t = "error"
80- s = (
81- "malformed 'version': '%s' (should be < 32 characters)"
82- % self.snap_yaml["version"]
83- )
84- elif not self._verify_pkgversion(self.snap_yaml["version"]):
85- t = "error"
86- s = "malformed 'version': '%s'" % self.snap_yaml["version"]
87- self._add_result(t, n, s)
88-
89 def check_valid_hook(self):
90 """Check valid hook"""
91 hooks = glob.glob("%s/meta/hooks/*" % self._get_unpack_dir())
92diff --git a/reviewtools/tests/schemas/test_schema_snap.py b/reviewtools/tests/schemas/test_schema_snap.py
93index 315b278..bcc55da 100644
94--- a/reviewtools/tests/schemas/test_schema_snap.py
95+++ b/reviewtools/tests/schemas/test_schema_snap.py
96@@ -2,7 +2,6 @@ from reviewtools.tests.schemas.test_schema_base import TestSchemaBase
97
98
99 class TestSchemaSnap(TestSchemaBase):
100-
101 schema_file = "reviewtools/schemas/snap.json"
102
103 def setUp(self):
104@@ -65,3 +64,59 @@ class TestSchemaSnap(TestSchemaBase):
105 with self.subTest(value=value):
106 error = error.replace("{value}", str(value)) if error else error
107 self._test_value("name", value, error)
108+
109+ def test_version(self):
110+ for value, error in [
111+ # test_check_version TODO: shouldn't we limit it to strings?
112+ (1, None),
113+ # test_check_version1 - integer TODO: should we limit it to strings?
114+ (1, None),
115+ # test_check_version2 - float
116+ (1.1, None),
117+ # test_check_version3 - MAJOR.MINOR.MICRO
118+ ("1.0.1", None),
119+ # test_check_version4 - str
120+ ("1.0a", None),
121+ # test_check_version5 - alpha
122+ ("a.b", None),
123+ # test_check_version_bad - bad
124+ ("foo?bar", "'{value}' does not match "),
125+ # test_check_version_bad2 - empty
126+ ("", "'{value}' does not match "),
127+ # test_check_version_bad3 - list
128+ ([], "{value} is not of type 'string', 'number'"),
129+ # test_check_version_bad4 - dict
130+ ({}, "{value} is not of type 'string', 'number'"),
131+ # test_check_version_bad5 - too long
132+ ("1.0.20160315-alpha2-git.c6fadc4+test1", "'{value}' is too long"),
133+ # test_check_version_missing
134+ (None, "'version' is a required property"),
135+ # ### startswith -
136+ ("-aaa", "'{value}' does not match "),
137+ # test_verify_pkgversion OK
138+ ("0", None),
139+ ("v1.0", None),
140+ ("0.12+16.04.20160126-0ubuntu1", None),
141+ ("1:6.0.1+r16-3", None),
142+ ("1.0~", None),
143+ ("1.0+", None),
144+ ("README.~1~", None),
145+ ("a+++++++++++++++++++++++++++++++", None),
146+ ("AZaz:.+~-123", None),
147+ # test_verify_pkgversion NOK
148+ ("~foo", "'{value}' does not match "),
149+ ("+foo", "'{value}' does not match "),
150+ ("foo:", "'{value}' does not match "),
151+ ("foo.", "'{value}' does not match "),
152+ ("foo-", "'{value}' does not match "),
153+ ("horrible_underscores", "'{value}' does not match "),
154+ ("foo($bar^baz$)meep", "'{value}' does not match "),
155+ ("árbol", "'{value}' does not match "),
156+ ("日本語", "'{value}' does not match "),
157+ ("한글", "'{value}' does not match "),
158+ ("ру́сский язы́к", "'{value}' does not match "),
159+ ("~foo$bar:", "'{value}' does not match "),
160+ ]:
161+ with self.subTest(value=value):
162+ error = error.replace("{value}", str(value)) if error else error
163+ self._test_value("version", value, error)
164diff --git a/reviewtools/tests/test_sr_common.py b/reviewtools/tests/test_sr_common.py
165index 4a95809..541cea9 100644
166--- a/reviewtools/tests/test_sr_common.py
167+++ b/reviewtools/tests/test_sr_common.py
168@@ -23,36 +23,6 @@ class TestSnapReviewCommon(sr_tests.TestSnapReview):
169 super().setUp()
170 self.review = SnapReview("app.snap", "sr_common_review_type")
171
172- def test_verify_pkgversion(self):
173- """Check _verify_pkgversion"""
174- for ok in [
175- "0",
176- "v1.0",
177- "0.12+16.04.20160126-0ubuntu1",
178- "1:6.0.1+r16-3",
179- "1.0~",
180- "1.0+",
181- "README.~1~",
182- "a+++++++++++++++++++++++++++++++",
183- "AZaz:.+~-123",
184- ]:
185- self.assertTrue(self.review._verify_pkgversion(ok))
186- for nok in [
187- "~foo",
188- "+foo",
189- "foo:",
190- "foo.",
191- "foo-",
192- "horrible_underscores",
193- "foo($bar^baz$)meep",
194- "árbol",
195- "日本語",
196- "한글",
197- "ру́сский язы́к",
198- "~foo$bar:",
199- ]:
200- self.assertFalse(self.review._verify_pkgversion(nok))
201-
202 def test_no_duplicated_yaml_keys(self):
203 """Check _no_duplicated_yaml_keys"""
204 b1 = """
205diff --git a/reviewtools/tests/test_sr_lint.py b/reviewtools/tests/test_sr_lint.py
206index 78f84a8..44f72dc 100644
207--- a/reviewtools/tests/test_sr_lint.py
208+++ b/reviewtools/tests/test_sr_lint.py
209@@ -143,141 +143,6 @@ class TestSnapReviewLint(sr_tests.TestSnapReview):
210 sum += len(c.review_report[i])
211 self.assertTrue(sum != 0)
212
213- def test_check_version(self):
214- """Test check_version"""
215- self.set_test_snap_yaml("version", 1)
216- c = SnapReviewLint(self.test_name)
217- c.check_version()
218- r = c.review_report
219- expected_counts = {"info": 1, "warn": 0, "error": 0}
220- self.check_results(r, expected_counts)
221-
222- def test_check_version1(self):
223- """Test check_version - integer"""
224- self.set_test_snap_yaml("version", 1)
225- c = SnapReviewLint(self.test_name)
226- c.check_version()
227- r = c.review_report
228- expected_counts = {"info": 1, "warn": 0, "error": 0}
229- self.check_results(r, expected_counts)
230-
231- def test_check_version2(self):
232- """Test check_version - float"""
233- self.set_test_snap_yaml("version", 1.0)
234- c = SnapReviewLint(self.test_name)
235- c.check_version()
236- r = c.review_report
237- expected_counts = {"info": 1, "warn": 0, "error": 0}
238- self.check_results(r, expected_counts)
239-
240- def test_check_version3(self):
241- """Test check_version - MAJOR.MINOR.MICRO"""
242- self.set_test_snap_yaml("version", "1.0.1")
243- c = SnapReviewLint(self.test_name)
244- c.check_version()
245- r = c.review_report
246- expected_counts = {"info": 1, "warn": 0, "error": 0}
247- self.check_results(r, expected_counts)
248-
249- def test_check_version4(self):
250- """Test check_version - str"""
251- self.set_test_snap_yaml("version", "1.0a")
252- c = SnapReviewLint(self.test_name)
253- c.check_version()
254- r = c.review_report
255- expected_counts = {"info": 1, "warn": 0, "error": 0}
256- self.check_results(r, expected_counts)
257-
258- def test_check_version5(self):
259- """Test check_version - alpha"""
260- self.set_test_snap_yaml("version", "a.b")
261- c = SnapReviewLint(self.test_name)
262- c.check_version()
263- r = c.review_report
264- expected_counts = {"info": 1, "warn": 0, "error": 0}
265- self.check_results(r, expected_counts)
266-
267- def test_check_version_bad(self):
268- """Test check_version - bad"""
269- self.set_test_snap_yaml("version", "foo?bar")
270- c = SnapReviewLint(self.test_name)
271- c.check_version()
272- r = c.review_report
273- expected_counts = {"info": None, "warn": 0, "error": 1}
274- self.check_results(r, expected_counts)
275-
276- def test_check_version_bad2(self):
277- """Test check_version - empty"""
278- self.set_test_snap_yaml("version", "")
279- c = SnapReviewLint(self.test_name)
280- c.check_version()
281- r = c.review_report
282- expected_counts = {"info": None, "warn": 0, "error": 1}
283- self.check_results(r, expected_counts)
284-
285- def test_check_version_bad3(self):
286- """Test check_version - list"""
287- self.set_test_snap_yaml("version", [])
288- c = SnapReviewLint(self.test_name)
289- c.check_version()
290- r = c.review_report
291- expected_counts = {"info": None, "warn": 0, "error": 1}
292- self.check_results(r, expected_counts)
293-
294- def test_check_version_bad4(self):
295- """Test check_version - dict"""
296- self.set_test_snap_yaml("version", {})
297- c = SnapReviewLint(self.test_name)
298- c.check_version()
299- r = c.review_report
300- expected_counts = {"info": None, "warn": 0, "error": 1}
301- self.check_results(r, expected_counts)
302-
303- def test_check_version_bad5(self):
304- """Test check_version - too long"""
305- self.set_test_snap_yaml("version", "1.0.20160315-alpha2-git.c6fadc4+test1")
306- c = SnapReviewLint(self.test_name)
307- c.check_version()
308- r = c.review_report
309- expected_counts = {"info": None, "warn": 0, "error": 1}
310- self.check_results(r, expected_counts)
311-
312- def test_check_version_missing(self):
313- """Test check_version - missing"""
314- self.set_test_snap_yaml("version", None)
315- c = SnapReviewLint(self.test_name)
316- c.check_version()
317- r = c.review_report
318- expected_counts = {"info": None, "warn": 0, "error": 1}
319- self.check_results(r, expected_counts)
320-
321- def test_check_type(self):
322- """Test check_type - unspecified"""
323- self.set_test_snap_yaml("type", None)
324- c = SnapReviewLint(self.test_name)
325- c.check_type()
326- r = c.review_report
327- expected_counts = {"info": 1, "warn": 0, "error": 0}
328- self.check_results(r, expected_counts)
329-
330- def test_check_type_app(self):
331- """Test check_type - app"""
332- self.set_test_snap_yaml("type", "app")
333- c = SnapReviewLint(self.test_name)
334- c.check_type()
335- r = c.review_report
336- expected_counts = {"info": 1, "warn": 0, "error": 0}
337- self.check_results(r, expected_counts)
338-
339- def test_check_type_framework(self):
340- """Test check_type - framework"""
341- self.set_test_snap_yaml("type", "framework")
342- c = SnapReviewLint(self.test_name)
343- c.check_type()
344- r = c.review_report
345- expected_counts = {"info": 0, "warn": 0, "error": 1}
346- self.check_results(r, expected_counts)
347-
348 def test_check_type_redflagged(self):
349 """Test check_type_redflagged - unspecified"""
350 self.set_test_snap_yaml("type", None)
351diff --git a/tests/test.sh.expected b/tests/test.sh.expected
352index 8c7535c..f11f507 100644
353--- a/tests/test.sh.expected
354+++ b/tests/test.sh.expected
355@@ -90,10 +90,6 @@ bare_1.0_all.snap: pass
356 "lint-snap-v2:vcs_files": {
357 "manual_review": false,
358 "text": "OK"
359- },
360- "lint-snap-v2:version_valid": {
361- "manual_review": false,
362- "text": "OK"
363 }
364 },
365 "warn": {}
366@@ -201,10 +197,6 @@ bare_1.0_all.snap: pass
367 "lint-snap-v2:vcs_files": {
368 "manual_review": false,
369 "text": "OK"
370- },
371- "lint-snap-v2:version_valid": {
372- "manual_review": false,
373- "text": "OK"
374 }
375 },
376 "warn": {}
377@@ -357,10 +349,6 @@ busybox-static-mvo_2.snap: pass
378 "lint-snap-v2:vcs_files": {
379 "manual_review": false,
380 "text": "OK"
381- },
382- "lint-snap-v2:version_valid": {
383- "manual_review": false,
384- "text": "OK"
385 }
386 },
387 "warn": {}
388@@ -512,10 +500,6 @@ busybox-static-mvo_2.snap: pass
389 "lint-snap-v2:vcs_files": {
390 "manual_review": false,
391 "text": "OK"
392- },
393- "lint-snap-v2:version_valid": {
394- "manual_review": false,
395- "text": "OK"
396 }
397 },
398 "warn": {}
399@@ -798,10 +782,6 @@ chrome-test_52.0.2743.116-1+test1_amd64.snap: FAIL
400 "lint-snap-v2:vcs_files": {
401 "manual_review": false,
402 "text": "OK"
403- },
404- "lint-snap-v2:version_valid": {
405- "manual_review": false,
406- "text": "OK"
407 }
408 },
409 "warn": {}
410@@ -1075,10 +1055,6 @@ chrome-test_52.0.2743.116-1+test1_amd64.snap: FAIL
411 "lint-snap-v2:vcs_files": {
412 "manual_review": false,
413 "text": "OK"
414- },
415- "lint-snap-v2:version_valid": {
416- "manual_review": false,
417- "text": "OK"
418 }
419 },
420 "warn": {}
421@@ -1235,10 +1211,6 @@ chromium-lzo_1.snap: pass
422 "lint-snap-v2:vcs_files": {
423 "manual_review": false,
424 "text": "OK"
425- },
426- "lint-snap-v2:version_valid": {
427- "manual_review": false,
428- "text": "OK"
429 }
430 },
431 "warn": {}
432@@ -1390,10 +1362,6 @@ chromium-lzo_1.snap: pass
433 "lint-snap-v2:vcs_files": {
434 "manual_review": false,
435 "text": "OK"
436- },
437- "lint-snap-v2:version_valid": {
438- "manual_review": false,
439- "text": "OK"
440 }
441 },
442 "warn": {}
443@@ -1615,10 +1583,6 @@ classic_16.04+test1_all.snap: FAIL
444 "lint-snap-v2:vcs_files": {
445 "manual_review": false,
446 "text": "OK"
447- },
448- "lint-snap-v2:version_valid": {
449- "manual_review": false,
450- "text": "OK"
451 }
452 },
453 "warn": {}
454@@ -1839,10 +1803,6 @@ classic_16.04+test1_all.snap: FAIL
455 "lint-snap-v2:vcs_files": {
456 "manual_review": false,
457 "text": "OK"
458- },
459- "lint-snap-v2:version_valid": {
460- "manual_review": false,
461- "text": "OK"
462 }
463 },
464 "warn": {}
465@@ -2024,10 +1984,6 @@ devmode-home_0.1_amd64.snap: pass
466 "lint-snap-v2:vcs_files": {
467 "manual_review": false,
468 "text": "OK"
469- },
470- "lint-snap-v2:version_valid": {
471- "manual_review": false,
472- "text": "OK"
473 }
474 },
475 "warn": {}
476@@ -2196,10 +2152,6 @@ devmode-home_0.1_amd64.snap: pass
477 "lint-snap-v2:vcs_files": {
478 "manual_review": false,
479 "text": "OK"
480- },
481- "lint-snap-v2:version_valid": {
482- "manual_review": false,
483- "text": "OK"
484 }
485 },
486 "warn": {}
487@@ -2566,10 +2518,6 @@ firefox_48.0+build2-0ubuntu0.16.04.1+_amd64.snap: FAIL
488 "lint-snap-v2:vcs_files": {
489 "manual_review": false,
490 "text": "OK"
491- },
492- "lint-snap-v2:version_valid": {
493- "manual_review": false,
494- "text": "OK"
495 }
496 },
497 "warn": {}
498@@ -2931,10 +2879,6 @@ firefox_48.0+build2-0ubuntu0.16.04.1+_amd64.snap: FAIL
499 "lint-snap-v2:vcs_files": {
500 "manual_review": false,
501 "text": "OK"
502- },
503- "lint-snap-v2:version_valid": {
504- "manual_review": false,
505- "text": "OK"
506 }
507 },
508 "warn": {}
509@@ -3058,10 +3002,6 @@ gke-kernel_4.15.0-1027.28~16.04.1_amd64.snap: pass
510 "lint-snap-v2:vcs_files": {
511 "manual_review": false,
512 "text": "OK"
513- },
514- "lint-snap-v2:version_valid": {
515- "manual_review": false,
516- "text": "OK"
517 }
518 },
519 "warn": {}
520@@ -3172,10 +3112,6 @@ gke-kernel_4.15.0-1027.28~16.04.1_amd64.snap: pass
521 "lint-snap-v2:vcs_files": {
522 "manual_review": false,
523 "text": "OK"
524- },
525- "lint-snap-v2:version_valid": {
526- "manual_review": false,
527- "text": "OK"
528 }
529 },
530 "warn": {}
531@@ -3291,10 +3227,6 @@ gke-kernel_4.15.0-1069.72_amd64.snap: pass
532 "lint-snap-v2:vcs_files": {
533 "manual_review": false,
534 "text": "OK"
535- },
536- "lint-snap-v2:version_valid": {
537- "manual_review": false,
538- "text": "OK"
539 }
540 },
541 "warn": {}
542@@ -3405,10 +3337,6 @@ gke-kernel_4.15.0-1069.72_amd64.snap: pass
543 "lint-snap-v2:vcs_files": {
544 "manual_review": false,
545 "text": "OK"
546- },
547- "lint-snap-v2:version_valid": {
548- "manual_review": false,
549- "text": "OK"
550 }
551 },
552 "warn": {}
553@@ -3687,10 +3615,6 @@ glance_ocata_amd64.snap: pass
554 "lint-snap-v2:vcs_files": {
555 "manual_review": false,
556 "text": "OK"
557- },
558- "lint-snap-v2:version_valid": {
559- "manual_review": false,
560- "text": "OK"
561 }
562 },
563 "warn": {}
564@@ -3976,10 +3900,6 @@ glance_ocata_amd64.snap: pass
565 "lint-snap-v2:vcs_files": {
566 "manual_review": false,
567 "text": "OK"
568- },
569- "lint-snap-v2:version_valid": {
570- "manual_review": false,
571- "text": "OK"
572 }
573 },
574 "warn": {}
575@@ -4306,10 +4226,6 @@ hello-world_25.snap: pass
576 "lint-snap-v2:vcs_files": {
577 "manual_review": false,
578 "text": "OK"
579- },
580- "lint-snap-v2:version_valid": {
581- "manual_review": false,
582- "text": "OK"
583 }
584 },
585 "warn": {}
586@@ -4601,10 +4517,6 @@ hello-world_25.snap: pass
587 "lint-snap-v2:vcs_files": {
588 "manual_review": false,
589 "text": "OK"
590- },
591- "lint-snap-v2:version_valid": {
592- "manual_review": false,
593- "text": "OK"
594 }
595 },
596 "warn": {}
597@@ -4744,10 +4656,6 @@ linux-generic-bbb_4.4.0-140-1_armhf.snap: pass
598 "lint-snap-v2:vcs_files": {
599 "manual_review": false,
600 "text": "OK"
601- },
602- "lint-snap-v2:version_valid": {
603- "manual_review": false,
604- "text": "OK"
605 }
606 },
607 "warn": {}
608@@ -4858,10 +4766,6 @@ linux-generic-bbb_4.4.0-140-1_armhf.snap: pass
609 "lint-snap-v2:vcs_files": {
610 "manual_review": false,
611 "text": "OK"
612- },
613- "lint-snap-v2:version_valid": {
614- "manual_review": false,
615- "text": "OK"
616 }
617 },
618 "warn": {}
619@@ -5006,10 +4910,6 @@ minimumsize_0.1_amd64.snap: pass
620 "lint-snap-v2:vcs_files": {
621 "manual_review": false,
622 "text": "OK"
623- },
624- "lint-snap-v2:version_valid": {
625- "manual_review": false,
626- "text": "OK"
627 }
628 },
629 "warn": {}
630@@ -5149,10 +5049,6 @@ minimumsize_0.1_amd64.snap: pass
631 "lint-snap-v2:vcs_files": {
632 "manual_review": false,
633 "text": "OK"
634- },
635- "lint-snap-v2:version_valid": {
636- "manual_review": false,
637- "text": "OK"
638 }
639 },
640 "warn": {}
641@@ -5321,10 +5217,6 @@ network-manager_1.10.6-2ubuntu1.0+dbce8fd2_amd64.snap: pass
642 "lint-snap-v2:vcs_files": {
643 "manual_review": false,
644 "text": "OK"
645- },
646- "lint-snap-v2:version_valid": {
647- "manual_review": false,
648- "text": "OK"
649 }
650 },
651 "warn": {}
652@@ -5492,10 +5384,6 @@ network-manager_1.10.6-2ubuntu1.0+dbce8fd2_amd64.snap: pass
653 "lint-snap-v2:vcs_files": {
654 "manual_review": false,
655 "text": "OK"
656- },
657- "lint-snap-v2:version_valid": {
658- "manual_review": false,
659- "text": "OK"
660 }
661 },
662 "warn": {}
663@@ -5733,10 +5621,6 @@ network-manager_1.2.2-1+test1_amd64.snap: FAIL
664 "lint-snap-v2:vcs_files": {
665 "manual_review": false,
666 "text": "OK"
667- },
668- "lint-snap-v2:version_valid": {
669- "manual_review": false,
670- "text": "OK"
671 }
672 },
673 "warn": {}
674@@ -5967,10 +5851,6 @@ network-manager_1.2.2-1+test1_amd64.snap: FAIL
675 "lint-snap-v2:vcs_files": {
676 "manual_review": false,
677 "text": "OK"
678- },
679- "lint-snap-v2:version_valid": {
680- "manual_review": false,
681- "text": "OK"
682 }
683 },
684 "warn": {}
685@@ -6175,10 +6055,6 @@ nix-example-jormungandr_f7xva0vh9fzv20vhyr121yd6ahplqh9v_amd64.snap: pass
686 "lint-snap-v2:vcs_files": {
687 "manual_review": false,
688 "text": "OK"
689- },
690- "lint-snap-v2:version_valid": {
691- "manual_review": false,
692- "text": "OK"
693 }
694 },
695 "warn": {}
696@@ -6378,10 +6254,6 @@ nix-example-jormungandr_f7xva0vh9fzv20vhyr121yd6ahplqh9v_amd64.snap: pass
697 "lint-snap-v2:vcs_files": {
698 "manual_review": false,
699 "text": "OK"
700- },
701- "lint-snap-v2:version_valid": {
702- "manual_review": false,
703- "text": "OK"
704 }
705 },
706 "warn": {}
707@@ -6675,10 +6547,6 @@ nix-example_g7qmi8r4qwws6fhwschfb8aib5wl0x1q_amd64.snap: pass
708 "lint-snap-v2:vcs_files": {
709 "manual_review": false,
710 "text": "OK"
711- },
712- "lint-snap-v2:version_valid": {
713- "manual_review": false,
714- "text": "OK"
715 }
716 },
717 "warn": {}
718@@ -6963,10 +6831,6 @@ nix-example_g7qmi8r4qwws6fhwschfb8aib5wl0x1q_amd64.snap: pass
719 "lint-snap-v2:vcs_files": {
720 "manual_review": false,
721 "text": "OK"
722- },
723- "lint-snap-v2:version_valid": {
724- "manual_review": false,
725- "text": "OK"
726 }
727 },
728 "warn": {}
729@@ -7148,10 +7012,6 @@ notify-send_1_amd64.snap: pass
730 "lint-snap-v2:vcs_files": {
731 "manual_review": false,
732 "text": "OK"
733- },
734- "lint-snap-v2:version_valid": {
735- "manual_review": false,
736- "text": "OK"
737 }
738 },
739 "warn": {}
740@@ -7328,10 +7188,6 @@ notify-send_1_amd64.snap: pass
741 "lint-snap-v2:vcs_files": {
742 "manual_review": false,
743 "text": "OK"
744- },
745- "lint-snap-v2:version_valid": {
746- "manual_review": false,
747- "text": "OK"
748 }
749 },
750 "warn": {}
751@@ -7451,10 +7307,6 @@ pc-kernel_4.15.0-44.46_i386.snap: pass
752 "lint-snap-v2:vcs_files": {
753 "manual_review": false,
754 "text": "OK"
755- },
756- "lint-snap-v2:version_valid": {
757- "manual_review": false,
758- "text": "OK"
759 }
760 },
761 "warn": {}
762@@ -7565,10 +7417,6 @@ pc-kernel_4.15.0-44.46_i386.snap: pass
763 "lint-snap-v2:vcs_files": {
764 "manual_review": false,
765 "text": "OK"
766- },
767- "lint-snap-v2:version_valid": {
768- "manual_review": false,
769- "text": "OK"
770 }
771 },
772 "warn": {}
773@@ -7684,10 +7532,6 @@ pc-kernel_4.4.0-141.167_amd64.snap: pass
774 "lint-snap-v2:vcs_files": {
775 "manual_review": false,
776 "text": "OK"
777- },
778- "lint-snap-v2:version_valid": {
779- "manual_review": false,
780- "text": "OK"
781 }
782 },
783 "warn": {}
784@@ -7798,10 +7642,6 @@ pc-kernel_4.4.0-141.167_amd64.snap: pass
785 "lint-snap-v2:vcs_files": {
786 "manual_review": false,
787 "text": "OK"
788- },
789- "lint-snap-v2:version_valid": {
790- "manual_review": false,
791- "text": "OK"
792 }
793 },
794 "warn": {}
795@@ -7909,10 +7749,6 @@ pc.canonical_5.snap: pass
796 "lint-snap-v2:vcs_files": {
797 "manual_review": false,
798 "text": "OK"
799- },
800- "lint-snap-v2:version_valid": {
801- "manual_review": false,
802- "text": "OK"
803 }
804 },
805 "warn": {}
806@@ -8015,10 +7851,6 @@ pc.canonical_5.snap: pass
807 "lint-snap-v2:vcs_files": {
808 "manual_review": false,
809 "text": "OK"
810- },
811- "lint-snap-v2:version_valid": {
812- "manual_review": false,
813- "text": "OK"
814 }
815 },
816 "warn": {}
817@@ -9228,10 +9060,6 @@ quagga_1.0.20160315-alpha2-git.c6fadc4+_amd64.snap: pass
818 "lint-snap-v2:vcs_files": {
819 "manual_review": false,
820 "text": "OK"
821- },
822- "lint-snap-v2:version_valid": {
823- "manual_review": false,
824- "text": "OK"
825 }
826 },
827 "warn": {}
828@@ -10508,10 +10336,6 @@ quagga_1.0.20160315-alpha2-git.c6fadc4+_amd64.snap: pass
829 "lint-snap-v2:vcs_files": {
830 "manual_review": false,
831 "text": "OK"
832- },
833- "lint-snap-v2:version_valid": {
834- "manual_review": false,
835- "text": "OK"
836 }
837 },
838 "warn": {}
839@@ -10749,10 +10573,6 @@ snap-test-arch-all-warning_1_all.snap: FAIL
840 "lint-snap-v2:vcs_files": {
841 "manual_review": false,
842 "text": "OK"
843- },
844- "lint-snap-v2:version_valid": {
845- "manual_review": false,
846- "text": "OK"
847 }
848 },
849 "warn": {}
850@@ -10913,10 +10733,6 @@ snap-test-arch-all-warning_1_all.snap: FAIL
851 "lint-snap-v2:vcs_files": {
852 "manual_review": false,
853 "text": "OK"
854- },
855- "lint-snap-v2:version_valid": {
856- "manual_review": false,
857- "text": "OK"
858 }
859 },
860 "warn": {}
861@@ -11086,10 +10902,6 @@ snappy-debug_20.snap: pass
862 "lint-snap-v2:vcs_files": {
863 "manual_review": false,
864 "text": "OK"
865- },
866- "lint-snap-v2:version_valid": {
867- "manual_review": false,
868- "text": "OK"
869 }
870 },
871 "warn": {}
872@@ -11254,10 +11066,6 @@ snappy-debug_20.snap: pass
873 "lint-snap-v2:vcs_files": {
874 "manual_review": false,
875 "text": "OK"
876- },
877- "lint-snap-v2:version_valid": {
878- "manual_review": false,
879- "text": "OK"
880 }
881 },
882 "warn": {}
883@@ -11471,10 +11279,6 @@ snappy-test-iface-attribs_0.1_all.snap: pass
884 "lint-snap-v2:vcs_files": {
885 "manual_review": false,
886 "text": "OK"
887- },
888- "lint-snap-v2:version_valid": {
889- "manual_review": false,
890- "text": "OK"
891 }
892 },
893 "warn": {}
894@@ -11683,10 +11487,6 @@ snappy-test-iface-attribs_0.1_all.snap: pass
895 "lint-snap-v2:vcs_files": {
896 "manual_review": false,
897 "text": "OK"
898- },
899- "lint-snap-v2:version_valid": {
900- "manual_review": false,
901- "text": "OK"
902 }
903 },
904 "warn": {}
905@@ -14437,10 +14237,6 @@ test-all-app_1_all.snap: FAIL
906 "lint-snap-v2:vcs_files": {
907 "manual_review": false,
908 "text": "OK"
909- },
910- "lint-snap-v2:version_valid": {
911- "manual_review": false,
912- "text": "OK"
913 }
914 },
915 "warn": {}
916@@ -17410,10 +17206,6 @@ test-all-app_1_all.snap: FAIL
917 "lint-snap-v2:vcs_files": {
918 "manual_review": false,
919 "text": "OK"
920- },
921- "lint-snap-v2:version_valid": {
922- "manual_review": false,
923- "text": "OK"
924 }
925 },
926 "warn": {}
927@@ -18239,10 +18031,6 @@ test-all-core_1_all.snap: FAIL
928 "lint-snap-v2:vcs_files": {
929 "manual_review": false,
930 "text": "OK"
931- },
932- "lint-snap-v2:version_valid": {
933- "manual_review": false,
934- "text": "OK"
935 }
936 },
937 "warn": {}
938@@ -18795,10 +18583,6 @@ test-all-core_1_all.snap: FAIL
939 "lint-snap-v2:vcs_files": {
940 "manual_review": false,
941 "text": "OK"
942- },
943- "lint-snap-v2:version_valid": {
944- "manual_review": false,
945- "text": "OK"
946 }
947 },
948 "warn": {}
949@@ -19108,10 +18892,6 @@ test-all-gadget_3_all.snap: FAIL
950 "lint-snap-v2:vcs_files": {
951 "manual_review": false,
952 "text": "OK"
953- },
954- "lint-snap-v2:version_valid": {
955- "manual_review": false,
956- "text": "OK"
957 }
958 },
959 "warn": {}
960@@ -19412,10 +19192,6 @@ test-all-gadget_3_all.snap: FAIL
961 "lint-snap-v2:vcs_files": {
962 "manual_review": false,
963 "text": "OK"
964- },
965- "lint-snap-v2:version_valid": {
966- "manual_review": false,
967- "text": "OK"
968 }
969 },
970 "warn": {}
971@@ -19579,10 +19355,6 @@ test-app-devnull_1.0_all.snap: FAIL
972 "lint-snap-v2:vcs_files": {
973 "manual_review": false,
974 "text": "OK"
975- },
976- "lint-snap-v2:version_valid": {
977- "manual_review": false,
978- "text": "OK"
979 }
980 },
981 "warn": {}
982@@ -19740,10 +19512,6 @@ test-app-devnull_1.0_all.snap: FAIL
983 "lint-snap-v2:vcs_files": {
984 "manual_review": false,
985 "text": "OK"
986- },
987- "lint-snap-v2:version_valid": {
988- "manual_review": false,
989- "text": "OK"
990 }
991 },
992 "warn": {}
993@@ -19944,10 +19712,6 @@ test-bad-desktop-file-icon_1_all.snap: FAIL
994 "lint-snap-v2:vcs_files": {
995 "manual_review": false,
996 "text": "OK"
997- },
998- "lint-snap-v2:version_valid": {
999- "manual_review": false,
1000- "text": "OK"
1001 }
1002 },
1003 "warn": {}
1004@@ -20137,10 +19901,6 @@ test-bad-desktop-file-icon_1_all.snap: FAIL
1005 "lint-snap-v2:vcs_files": {
1006 "manual_review": false,
1007 "text": "OK"
1008- },
1009- "lint-snap-v2:version_valid": {
1010- "manual_review": false,
1011- "text": "OK"
1012 }
1013 },
1014 "warn": {}
1015@@ -20403,10 +20163,6 @@ test-bad-unicode_0_all.snap: FAIL
1016 "lint-snap-v2:vcs_files": {
1017 "manual_review": false,
1018 "text": "OK"
1019- },
1020- "lint-snap-v2:version_valid": {
1021- "manual_review": false,
1022- "text": "OK"
1023 }
1024 },
1025 "warn": {}
1026@@ -20591,10 +20347,6 @@ test-bad-unicode_0_all.snap: FAIL
1027 "lint-snap-v2:vcs_files": {
1028 "manual_review": false,
1029 "text": "OK"
1030- },
1031- "lint-snap-v2:version_valid": {
1032- "manual_review": false,
1033- "text": "OK"
1034 }
1035 },
1036 "warn": {}
1037@@ -20726,10 +20478,6 @@ test-base-devnull_1.0_all.snap: FAIL
1038 "lint-snap-v2:vcs_files": {
1039 "manual_review": false,
1040 "text": "OK"
1041- },
1042- "lint-snap-v2:version_valid": {
1043- "manual_review": false,
1044- "text": "OK"
1045 }
1046 },
1047 "warn": {}
1048@@ -20843,10 +20591,6 @@ test-base-devnull_1.0_all.snap: FAIL
1049 "lint-snap-v2:vcs_files": {
1050 "manual_review": false,
1051 "text": "OK"
1052- },
1053- "lint-snap-v2:version_valid": {
1054- "manual_review": false,
1055- "text": "OK"
1056 }
1057 },
1058 "warn": {}
1059@@ -21021,10 +20765,6 @@ test-base-disallowed_0_all.snap: FAIL
1060 "lint-snap-v2:vcs_files": {
1061 "manual_review": false,
1062 "text": "OK"
1063- },
1064- "lint-snap-v2:version_valid": {
1065- "manual_review": false,
1066- "text": "OK"
1067 }
1068 },
1069 "warn": {}
1070@@ -21193,10 +20933,6 @@ test-base-disallowed_0_all.snap: FAIL
1071 "lint-snap-v2:vcs_files": {
1072 "manual_review": false,
1073 "text": "OK"
1074- },
1075- "lint-snap-v2:version_valid": {
1076- "manual_review": false,
1077- "text": "OK"
1078 }
1079 },
1080 "warn": {}
1081@@ -21320,10 +21056,6 @@ test-base-missing-mountpoint_1.0_all.snap: FAIL
1082 "lint-snap-v2:vcs_files": {
1083 "manual_review": false,
1084 "text": "OK"
1085- },
1086- "lint-snap-v2:version_valid": {
1087- "manual_review": false,
1088- "text": "OK"
1089 }
1090 },
1091 "warn": {}
1092@@ -21432,10 +21164,6 @@ test-base-missing-mountpoint_1.0_all.snap: FAIL
1093 "lint-snap-v2:vcs_files": {
1094 "manual_review": false,
1095 "text": "OK"
1096- },
1097- "lint-snap-v2:version_valid": {
1098- "manual_review": false,
1099- "text": "OK"
1100 }
1101 },
1102 "warn": {}
1103@@ -21651,10 +21379,6 @@ test-base-slots-plugs_1.0_all.snap: FAIL
1104 "lint-snap-v2:vcs_files": {
1105 "manual_review": false,
1106 "text": "OK"
1107- },
1108- "lint-snap-v2:version_valid": {
1109- "manual_review": false,
1110- "text": "OK"
1111 }
1112 },
1113 "warn": {}
1114@@ -21857,10 +21581,6 @@ test-base-slots-plugs_1.0_all.snap: FAIL
1115 "lint-snap-v2:vcs_files": {
1116 "manual_review": false,
1117 "text": "OK"
1118- },
1119- "lint-snap-v2:version_valid": {
1120- "manual_review": false,
1121- "text": "OK"
1122 }
1123 },
1124 "warn": {}
1125@@ -22033,10 +21753,6 @@ test-check-notices-esm-apps_0.1_amd64.snap: pass
1126 "lint-snap-v2:vcs_files": {
1127 "manual_review": false,
1128 "text": "OK"
1129- },
1130- "lint-snap-v2:version_valid": {
1131- "manual_review": false,
1132- "text": "OK"
1133 }
1134 },
1135 "warn": {}
1136@@ -22204,10 +21920,6 @@ test-check-notices-esm-apps_0.1_amd64.snap: pass
1137 "lint-snap-v2:vcs_files": {
1138 "manual_review": false,
1139 "text": "OK"
1140- },
1141- "lint-snap-v2:version_valid": {
1142- "manual_review": false,
1143- "text": "OK"
1144 }
1145 },
1146 "warn": {}
1147@@ -22380,10 +22092,6 @@ test-check-notices-needed_0.1_amd64.snap: pass
1148 "lint-snap-v2:vcs_files": {
1149 "manual_review": false,
1150 "text": "OK"
1151- },
1152- "lint-snap-v2:version_valid": {
1153- "manual_review": false,
1154- "text": "OK"
1155 }
1156 },
1157 "warn": {}
1158@@ -22551,10 +22259,6 @@ test-check-notices-needed_0.1_amd64.snap: pass
1159 "lint-snap-v2:vcs_files": {
1160 "manual_review": false,
1161 "text": "OK"
1162- },
1163- "lint-snap-v2:version_valid": {
1164- "manual_review": false,
1165- "text": "OK"
1166 }
1167 },
1168 "warn": {}
1169@@ -22736,10 +22440,6 @@ test-check-notices-primed-stage-packages-needed_0.1_amd64.snap: FAIL
1170 "lint-snap-v2:vcs_files": {
1171 "manual_review": false,
1172 "text": "OK"
1173- },
1174- "lint-snap-v2:version_valid": {
1175- "manual_review": false,
1176- "text": "OK"
1177 }
1178 },
1179 "warn": {}
1180@@ -22912,10 +22612,6 @@ test-check-notices-primed-stage-packages-needed_0.1_amd64.snap: FAIL
1181 "lint-snap-v2:vcs_files": {
1182 "manual_review": false,
1183 "text": "OK"
1184- },
1185- "lint-snap-v2:version_valid": {
1186- "manual_review": false,
1187- "text": "OK"
1188 }
1189 },
1190 "warn": {}
1191@@ -23097,10 +22793,6 @@ test-check-notices-primed-stage-packages-needed_0.2_amd64.snap: FAIL
1192 "lint-snap-v2:vcs_files": {
1193 "manual_review": false,
1194 "text": "OK"
1195- },
1196- "lint-snap-v2:version_valid": {
1197- "manual_review": false,
1198- "text": "OK"
1199 }
1200 },
1201 "warn": {}
1202@@ -23273,10 +22965,6 @@ test-check-notices-primed-stage-packages-needed_0.2_amd64.snap: FAIL
1203 "lint-snap-v2:vcs_files": {
1204 "manual_review": false,
1205 "text": "OK"
1206- },
1207- "lint-snap-v2:version_valid": {
1208- "manual_review": false,
1209- "text": "OK"
1210 }
1211 },
1212 "warn": {}
1213@@ -23449,10 +23137,6 @@ test-check-notices-primed-stage-packages_0.1_amd64.snap: pass
1214 "lint-snap-v2:vcs_files": {
1215 "manual_review": false,
1216 "text": "OK"
1217- },
1218- "lint-snap-v2:version_valid": {
1219- "manual_review": false,
1220- "text": "OK"
1221 }
1222 },
1223 "warn": {}
1224@@ -23620,10 +23304,6 @@ test-check-notices-primed-stage-packages_0.1_amd64.snap: pass
1225 "lint-snap-v2:vcs_files": {
1226 "manual_review": false,
1227 "text": "OK"
1228- },
1229- "lint-snap-v2:version_valid": {
1230- "manual_review": false,
1231- "text": "OK"
1232 }
1233 },
1234 "warn": {}
1235@@ -23796,10 +23476,6 @@ test-check-notices_0.1_amd64.snap: pass
1236 "lint-snap-v2:vcs_files": {
1237 "manual_review": false,
1238 "text": "OK"
1239- },
1240- "lint-snap-v2:version_valid": {
1241- "manual_review": false,
1242- "text": "OK"
1243 }
1244 },
1245 "warn": {}
1246@@ -23967,10 +23643,6 @@ test-check-notices_0.1_amd64.snap: pass
1247 "lint-snap-v2:vcs_files": {
1248 "manual_review": false,
1249 "text": "OK"
1250- },
1251- "lint-snap-v2:version_valid": {
1252- "manual_review": false,
1253- "text": "OK"
1254 }
1255 },
1256 "warn": {}
1257@@ -24174,10 +23846,6 @@ test-classic_0_all.snap: FAIL
1258 "lint-snap-v2:vcs_files": {
1259 "manual_review": false,
1260 "text": "OK"
1261- },
1262- "lint-snap-v2:version_valid": {
1263- "manual_review": false,
1264- "text": "OK"
1265 }
1266 },
1267 "warn": {}
1268@@ -24375,10 +24043,6 @@ test-classic_0_all.snap: FAIL
1269 "lint-snap-v2:vcs_files": {
1270 "manual_review": false,
1271 "text": "OK"
1272- },
1273- "lint-snap-v2:version_valid": {
1274- "manual_review": false,
1275- "text": "OK"
1276 }
1277 },
1278 "warn": {}
1279@@ -24571,10 +24235,6 @@ test-command-with-args_0_all.snap: pass
1280 "lint-snap-v2:vcs_files": {
1281 "manual_review": false,
1282 "text": "OK"
1283- },
1284- "lint-snap-v2:version_valid": {
1285- "manual_review": false,
1286- "text": "OK"
1287 }
1288 },
1289 "warn": {}
1290@@ -24762,10 +24422,6 @@ test-command-with-args_0_all.snap: pass
1291 "lint-snap-v2:vcs_files": {
1292 "manual_review": false,
1293 "text": "OK"
1294- },
1295- "lint-snap-v2:version_valid": {
1296- "manual_review": false,
1297- "text": "OK"
1298 }
1299 },
1300 "warn": {}
1301@@ -24970,10 +24626,6 @@ test-common-id_0_all.snap: pass
1302 "lint-snap-v2:vcs_files": {
1303 "manual_review": false,
1304 "text": "OK"
1305- },
1306- "lint-snap-v2:version_valid": {
1307- "manual_review": false,
1308- "text": "OK"
1309 }
1310 },
1311 "warn": {}
1312@@ -25173,10 +24825,6 @@ test-common-id_0_all.snap: pass
1313 "lint-snap-v2:vcs_files": {
1314 "manual_review": false,
1315 "text": "OK"
1316- },
1317- "lint-snap-v2:version_valid": {
1318- "manual_review": false,
1319- "text": "OK"
1320 }
1321 },
1322 "warn": {}
1323@@ -25386,10 +25034,6 @@ test-completion_1.0_all.snap: pass
1324 "lint-snap-v2:vcs_files": {
1325 "manual_review": false,
1326 "text": "OK"
1327- },
1328- "lint-snap-v2:version_valid": {
1329- "manual_review": false,
1330- "text": "OK"
1331 }
1332 },
1333 "warn": {}
1334@@ -25594,10 +25238,6 @@ test-completion_1.0_all.snap: pass
1335 "lint-snap-v2:vcs_files": {
1336 "manual_review": false,
1337 "text": "OK"
1338- },
1339- "lint-snap-v2:version_valid": {
1340- "manual_review": false,
1341- "text": "OK"
1342 }
1343 },
1344 "warn": {}
1345@@ -25939,10 +25579,6 @@ test-content_0.1_all.snap: pass
1346 "lint-snap-v2:vcs_files": {
1347 "manual_review": false,
1348 "text": "OK"
1349- },
1350- "lint-snap-v2:version_valid": {
1351- "manual_review": false,
1352- "text": "OK"
1353 }
1354 },
1355 "warn": {}
1356@@ -26275,10 +25911,6 @@ test-content_0.1_all.snap: pass
1357 "lint-snap-v2:vcs_files": {
1358 "manual_review": false,
1359 "text": "OK"
1360- },
1361- "lint-snap-v2:version_valid": {
1362- "manual_review": false,
1363- "text": "OK"
1364 }
1365 },
1366 "warn": {}
1367@@ -26411,10 +26043,6 @@ test-core-with-primed-staged_16-2.37.2_amd64.snap: FAIL
1368 "lint-snap-v2:vcs_files": {
1369 "manual_review": false,
1370 "text": "OK"
1371- },
1372- "lint-snap-v2:version_valid": {
1373- "manual_review": false,
1374- "text": "OK"
1375 }
1376 },
1377 "warn": {}
1378@@ -26534,10 +26162,6 @@ test-core-with-primed-staged_16-2.37.2_amd64.snap: FAIL
1379 "lint-snap-v2:vcs_files": {
1380 "manual_review": false,
1381 "text": "OK"
1382- },
1383- "lint-snap-v2:version_valid": {
1384- "manual_review": false,
1385- "text": "OK"
1386 }
1387 },
1388 "warn": {}
1389@@ -26666,10 +26290,6 @@ test-core_16-2.37.2_amd64.snap: FAIL
1390 "lint-snap-v2:vcs_files": {
1391 "manual_review": false,
1392 "text": "OK"
1393- },
1394- "lint-snap-v2:version_valid": {
1395- "manual_review": false,
1396- "text": "OK"
1397 }
1398 },
1399 "warn": {}
1400@@ -26789,10 +26409,6 @@ test-core_16-2.37.2_amd64.snap: FAIL
1401 "lint-snap-v2:vcs_files": {
1402 "manual_review": false,
1403 "text": "OK"
1404- },
1405- "lint-snap-v2:version_valid": {
1406- "manual_review": false,
1407- "text": "OK"
1408 }
1409 },
1410 "warn": {}
1411@@ -27006,10 +26622,6 @@ test-desktop-file_1_all.snap: pass
1412 "lint-snap-v2:vcs_files": {
1413 "manual_review": false,
1414 "text": "OK"
1415- },
1416- "lint-snap-v2:version_valid": {
1417- "manual_review": false,
1418- "text": "OK"
1419 }
1420 },
1421 "warn": {}
1422@@ -27222,10 +26834,6 @@ test-desktop-file_1_all.snap: pass
1423 "lint-snap-v2:vcs_files": {
1424 "manual_review": false,
1425 "text": "OK"
1426- },
1427- "lint-snap-v2:version_valid": {
1428- "manual_review": false,
1429- "text": "OK"
1430 }
1431 },
1432 "warn": {}
1433@@ -27395,10 +27003,6 @@ test-dir-perms_0_amd64.snap: FAIL
1434 "lint-snap-v2:vcs_files": {
1435 "manual_review": false,
1436 "text": "OK"
1437- },
1438- "lint-snap-v2:version_valid": {
1439- "manual_review": false,
1440- "text": "OK"
1441 }
1442 },
1443 "warn": {}
1444@@ -27560,10 +27164,6 @@ test-dir-perms_0_amd64.snap: FAIL
1445 "lint-snap-v2:vcs_files": {
1446 "manual_review": false,
1447 "text": "OK"
1448- },
1449- "lint-snap-v2:version_valid": {
1450- "manual_review": false,
1451- "text": "OK"
1452 }
1453 },
1454 "warn": {}
1455@@ -27702,10 +27302,6 @@ test-dpkg-list-app_1.0_amd64.snap: pass
1456 "lint-snap-v2:vcs_files": {
1457 "manual_review": false,
1458 "text": "OK"
1459- },
1460- "lint-snap-v2:version_valid": {
1461- "manual_review": false,
1462- "text": "OK"
1463 }
1464 },
1465 "warn": {}
1466@@ -27833,10 +27429,6 @@ test-dpkg-list-app_1.0_amd64.snap: pass
1467 "lint-snap-v2:vcs_files": {
1468 "manual_review": false,
1469 "text": "OK"
1470- },
1471- "lint-snap-v2:version_valid": {
1472- "manual_review": false,
1473- "text": "OK"
1474 }
1475 },
1476 "warn": {}
1477@@ -28109,10 +27701,6 @@ test-env_0.1_all.snap: pass
1478 "lint-snap-v2:vcs_files": {
1479 "manual_review": false,
1480 "text": "OK"
1481- },
1482- "lint-snap-v2:version_valid": {
1483- "manual_review": false,
1484- "text": "OK"
1485 }
1486 },
1487 "warn": {}
1488@@ -28396,10 +27984,6 @@ test-env_0.1_all.snap: pass
1489 "lint-snap-v2:vcs_files": {
1490 "manual_review": false,
1491 "text": "OK"
1492- },
1493- "lint-snap-v2:version_valid": {
1494- "manual_review": false,
1495- "text": "OK"
1496 }
1497 },
1498 "warn": {}
1499@@ -28582,10 +28166,6 @@ test-execstack_0_amd64.snap: FAIL
1500 "lint-snap-v2:vcs_files": {
1501 "manual_review": false,
1502 "text": "OK"
1503- },
1504- "lint-snap-v2:version_valid": {
1505- "manual_review": false,
1506- "text": "OK"
1507 }
1508 },
1509 "warn": {}
1510@@ -28746,10 +28326,6 @@ test-execstack_0_amd64.snap: FAIL
1511 "lint-snap-v2:vcs_files": {
1512 "manual_review": false,
1513 "text": "OK"
1514- },
1515- "lint-snap-v2:version_valid": {
1516- "manual_review": false,
1517- "text": "OK"
1518 }
1519 },
1520 "warn": {}
1521@@ -28914,10 +28490,6 @@ test-grade-and-confinement_0.1_all.snap: pass
1522 "lint-snap-v2:vcs_files": {
1523 "manual_review": false,
1524 "text": "OK"
1525- },
1526- "lint-snap-v2:version_valid": {
1527- "manual_review": false,
1528- "text": "OK"
1529 }
1530 },
1531 "warn": {}
1532@@ -29077,10 +28649,6 @@ test-grade-and-confinement_0.1_all.snap: pass
1533 "lint-snap-v2:vcs_files": {
1534 "manual_review": false,
1535 "text": "OK"
1536- },
1537- "lint-snap-v2:version_valid": {
1538- "manual_review": false,
1539- "text": "OK"
1540 }
1541 },
1542 "warn": {}
1543@@ -29241,10 +28809,6 @@ test-gzip_1.snap: FAIL
1544 "lint-snap-v2:vcs_files": {
1545 "manual_review": false,
1546 "text": "OK"
1547- },
1548- "lint-snap-v2:version_valid": {
1549- "manual_review": false,
1550- "text": "OK"
1551 }
1552 },
1553 "warn": {}
1554@@ -29397,10 +28961,6 @@ test-gzip_1.snap: FAIL
1555 "lint-snap-v2:vcs_files": {
1556 "manual_review": false,
1557 "text": "OK"
1558- },
1559- "lint-snap-v2:version_valid": {
1560- "manual_review": false,
1561- "text": "OK"
1562 }
1563 },
1564 "warn": {}
1565@@ -29826,10 +29386,6 @@ test-hello-dbus_2_amd64.snap: FAIL
1566 "lint-snap-v2:vcs_files": {
1567 "manual_review": false,
1568 "text": "OK"
1569- },
1570- "lint-snap-v2:version_valid": {
1571- "manual_review": false,
1572- "text": "OK"
1573 }
1574 },
1575 "warn": {}
1576@@ -30259,10 +29815,6 @@ test-hello-dbus_2_amd64.snap: FAIL
1577 "lint-snap-v2:vcs_files": {
1578 "manual_review": false,
1579 "text": "OK"
1580- },
1581- "lint-snap-v2:version_valid": {
1582- "manual_review": false,
1583- "text": "OK"
1584 }
1585 },
1586 "warn": {}
1587@@ -30505,10 +30057,6 @@ test-home-read-attrib_0.1_amd64.snap: FAIL
1588 "lint-snap-v2:vcs_files": {
1589 "manual_review": false,
1590 "text": "OK"
1591- },
1592- "lint-snap-v2:version_valid": {
1593- "manual_review": false,
1594- "text": "OK"
1595 }
1596 },
1597 "warn": {}
1598@@ -30730,10 +30278,6 @@ test-home-read-attrib_0.1_amd64.snap: FAIL
1599 "lint-snap-v2:vcs_files": {
1600 "manual_review": false,
1601 "text": "OK"
1602- },
1603- "lint-snap-v2:version_valid": {
1604- "manual_review": false,
1605- "text": "OK"
1606 }
1607 },
1608 "warn": {}
1609@@ -31159,10 +30703,6 @@ test-hooks_0_all.snap: pass
1610 "lint-snap-v2:vcs_files": {
1611 "manual_review": false,
1612 "text": "OK"
1613- },
1614- "lint-snap-v2:version_valid": {
1615- "manual_review": false,
1616- "text": "OK"
1617 }
1618 },
1619 "warn": {}
1620@@ -31579,10 +31119,6 @@ test-hooks_0_all.snap: pass
1621 "lint-snap-v2:vcs_files": {
1622 "manual_review": false,
1623 "text": "OK"
1624- },
1625- "lint-snap-v2:version_valid": {
1626- "manual_review": false,
1627- "text": "OK"
1628 }
1629 },
1630 "warn": {}
1631@@ -31811,10 +31347,6 @@ test-install-stop-and-refresh-modes_0.1_all.snap: pass
1632 "lint-snap-v2:vcs_files": {
1633 "manual_review": false,
1634 "text": "OK"
1635- },
1636- "lint-snap-v2:version_valid": {
1637- "manual_review": false,
1638- "text": "OK"
1639 }
1640 },
1641 "warn": {}
1642@@ -32046,10 +31578,6 @@ test-install-stop-and-refresh-modes_0.1_all.snap: pass
1643 "lint-snap-v2:vcs_files": {
1644 "manual_review": false,
1645 "text": "OK"
1646- },
1647- "lint-snap-v2:version_valid": {
1648- "manual_review": false,
1649- "text": "OK"
1650 }
1651 },
1652 "warn": {}
1653@@ -32186,10 +31714,6 @@ test-link_0.1_all.snap: pass
1654 "lint-snap-v2:vcs_files": {
1655 "manual_review": false,
1656 "text": "OK"
1657- },
1658- "lint-snap-v2:version_valid": {
1659- "manual_review": false,
1660- "text": "OK"
1661 }
1662 },
1663 "warn": {}
1664@@ -32309,10 +31833,6 @@ test-link_0.1_all.snap: pass
1665 "lint-snap-v2:vcs_files": {
1666 "manual_review": false,
1667 "text": "OK"
1668- },
1669- "lint-snap-v2:version_valid": {
1670- "manual_review": false,
1671- "text": "OK"
1672 }
1673 },
1674 "warn": {}
1675@@ -32465,10 +31985,6 @@ test-lzo_1.snap: pass
1676 "lint-snap-v2:vcs_files": {
1677 "manual_review": false,
1678 "text": "OK"
1679- },
1680- "lint-snap-v2:version_valid": {
1681- "manual_review": false,
1682- "text": "OK"
1683 }
1684 },
1685 "warn": {}
1686@@ -32620,10 +32136,6 @@ test-lzo_1.snap: pass
1687 "lint-snap-v2:vcs_files": {
1688 "manual_review": false,
1689 "text": "OK"
1690- },
1691- "lint-snap-v2:version_valid": {
1692- "manual_review": false,
1693- "text": "OK"
1694 }
1695 },
1696 "warn": {}
1697@@ -32882,10 +32394,6 @@ test-mir-xwayland_0_all.snap: FAIL
1698 "lint-snap-v2:vcs_files": {
1699 "manual_review": false,
1700 "text": "OK"
1701- },
1702- "lint-snap-v2:version_valid": {
1703- "manual_review": false,
1704- "text": "OK"
1705 }
1706 },
1707 "warn": {}
1708@@ -33139,10 +32647,6 @@ test-mir-xwayland_0_all.snap: FAIL
1709 "lint-snap-v2:vcs_files": {
1710 "manual_review": false,
1711 "text": "OK"
1712- },
1713- "lint-snap-v2:version_valid": {
1714- "manual_review": false,
1715- "text": "OK"
1716 }
1717 },
1718 "warn": {}
1719@@ -33382,10 +32886,6 @@ test-missing-required-attributes_0_all.snap: FAIL
1720 "lint-snap-v2:vcs_files": {
1721 "manual_review": false,
1722 "text": "OK"
1723- },
1724- "lint-snap-v2:version_valid": {
1725- "manual_review": false,
1726- "text": "OK"
1727 }
1728 },
1729 "warn": {}
1730@@ -33608,10 +33108,6 @@ test-missing-required-attributes_0_all.snap: FAIL
1731 "lint-snap-v2:vcs_files": {
1732 "manual_review": false,
1733 "text": "OK"
1734- },
1735- "lint-snap-v2:version_valid": {
1736- "manual_review": false,
1737- "text": "OK"
1738 }
1739 },
1740 "warn": {}
1741@@ -33809,10 +33305,6 @@ test-mpris-name-matches_0_amd64.snap: FAIL
1742 "lint-snap-v2:vcs_files": {
1743 "manual_review": false,
1744 "text": "OK"
1745- },
1746- "lint-snap-v2:version_valid": {
1747- "manual_review": false,
1748- "text": "OK"
1749 }
1750 },
1751 "warn": {}
1752@@ -34001,10 +33493,6 @@ test-mpris-name-matches_0_amd64.snap: FAIL
1753 "lint-snap-v2:vcs_files": {
1754 "manual_review": false,
1755 "text": "OK"
1756- },
1757- "lint-snap-v2:version_valid": {
1758- "manual_review": false,
1759- "text": "OK"
1760 }
1761 },
1762 "warn": {}
1763@@ -34202,10 +33690,6 @@ test-mpris-name-mismatch_0_amd64.snap: FAIL
1764 "lint-snap-v2:vcs_files": {
1765 "manual_review": false,
1766 "text": "OK"
1767- },
1768- "lint-snap-v2:version_valid": {
1769- "manual_review": false,
1770- "text": "OK"
1771 }
1772 },
1773 "warn": {}
1774@@ -34394,10 +33878,6 @@ test-mpris-name-mismatch_0_amd64.snap: FAIL
1775 "lint-snap-v2:vcs_files": {
1776 "manual_review": false,
1777 "text": "OK"
1778- },
1779- "lint-snap-v2:version_valid": {
1780- "manual_review": false,
1781- "text": "OK"
1782 }
1783 },
1784 "warn": {}
1785@@ -34575,10 +34055,6 @@ test-mpris_0_amd64.snap: pass
1786 "lint-snap-v2:vcs_files": {
1787 "manual_review": false,
1788 "text": "OK"
1789- },
1790- "lint-snap-v2:version_valid": {
1791- "manual_review": false,
1792- "text": "OK"
1793 }
1794 },
1795 "warn": {}
1796@@ -34751,10 +34227,6 @@ test-mpris_0_amd64.snap: pass
1797 "lint-snap-v2:vcs_files": {
1798 "manual_review": false,
1799 "text": "OK"
1800- },
1801- "lint-snap-v2:version_valid": {
1802- "manual_review": false,
1803- "text": "OK"
1804 }
1805 },
1806 "warn": {}
1807@@ -34923,10 +34395,6 @@ test-no-fragments_4.snap: FAIL
1808 "lint-snap-v2:vcs_files": {
1809 "manual_review": false,
1810 "text": "OK"
1811- },
1812- "lint-snap-v2:version_valid": {
1813- "manual_review": false,
1814- "text": "OK"
1815 }
1816 },
1817 "warn": {}
1818@@ -35087,10 +34555,6 @@ test-no-fragments_4.snap: FAIL
1819 "lint-snap-v2:vcs_files": {
1820 "manual_review": false,
1821 "text": "OK"
1822- },
1823- "lint-snap-v2:version_valid": {
1824- "manual_review": false,
1825- "text": "OK"
1826 }
1827 },
1828 "warn": {}
1829@@ -35285,10 +34749,6 @@ test-personal-files_1_all.snap: FAIL
1830 "lint-snap-v2:vcs_files": {
1831 "manual_review": false,
1832 "text": "OK"
1833- },
1834- "lint-snap-v2:version_valid": {
1835- "manual_review": false,
1836- "text": "OK"
1837 }
1838 },
1839 "warn": {}
1840@@ -35473,10 +34933,6 @@ test-personal-files_1_all.snap: FAIL
1841 "lint-snap-v2:vcs_files": {
1842 "manual_review": false,
1843 "text": "OK"
1844- },
1845- "lint-snap-v2:version_valid": {
1846- "manual_review": false,
1847- "text": "OK"
1848 }
1849 },
1850 "warn": {}
1851@@ -35658,10 +35114,6 @@ test-plug-cmd_1_all.snap: FAIL
1852 "lint-snap-v2:vcs_files": {
1853 "manual_review": false,
1854 "text": "OK"
1855- },
1856- "lint-snap-v2:version_valid": {
1857- "manual_review": false,
1858- "text": "OK"
1859 }
1860 },
1861 "warn": {}
1862@@ -35834,10 +35286,6 @@ test-plug-cmd_1_all.snap: FAIL
1863 "lint-snap-v2:vcs_files": {
1864 "manual_review": false,
1865 "text": "OK"
1866- },
1867- "lint-snap-v2:version_valid": {
1868- "manual_review": false,
1869- "text": "OK"
1870 }
1871 },
1872 "warn": {}
1873@@ -35989,10 +35437,6 @@ test-plug-hook-gadget_1_all.snap: FAIL
1874 "lint-snap-v2:vcs_files": {
1875 "manual_review": false,
1876 "text": "OK"
1877- },
1878- "lint-snap-v2:version_valid": {
1879- "manual_review": false,
1880- "text": "OK"
1881 }
1882 },
1883 "warn": {}
1884@@ -36129,10 +35573,6 @@ test-plug-hook-gadget_1_all.snap: FAIL
1885 "lint-snap-v2:vcs_files": {
1886 "manual_review": false,
1887 "text": "OK"
1888- },
1889- "lint-snap-v2:version_valid": {
1890- "manual_review": false,
1891- "text": "OK"
1892 }
1893 },
1894 "warn": {}
1895@@ -36322,10 +35762,6 @@ test-plug-hook_1_all.snap: FAIL
1896 "lint-snap-v2:vcs_files": {
1897 "manual_review": false,
1898 "text": "OK"
1899- },
1900- "lint-snap-v2:version_valid": {
1901- "manual_review": false,
1902- "text": "OK"
1903 }
1904 },
1905 "warn": {}
1906@@ -36510,10 +35946,6 @@ test-plug-hook_1_all.snap: FAIL
1907 "lint-snap-v2:vcs_files": {
1908 "manual_review": false,
1909 "text": "OK"
1910- },
1911- "lint-snap-v2:version_valid": {
1912- "manual_review": false,
1913- "text": "OK"
1914 }
1915 },
1916 "warn": {}
1917@@ -36673,10 +36105,6 @@ test-plug-reference-hook-gadget_1_all.snap: FAIL
1918 "lint-snap-v2:vcs_files": {
1919 "manual_review": false,
1920 "text": "OK"
1921- },
1922- "lint-snap-v2:version_valid": {
1923- "manual_review": false,
1924- "text": "OK"
1925 }
1926 },
1927 "warn": {}
1928@@ -36821,10 +36249,6 @@ test-plug-reference-hook-gadget_1_all.snap: FAIL
1929 "lint-snap-v2:vcs_files": {
1930 "manual_review": false,
1931 "text": "OK"
1932- },
1933- "lint-snap-v2:version_valid": {
1934- "manual_review": false,
1935- "text": "OK"
1936 }
1937 },
1938 "warn": {}
1939@@ -37022,10 +36446,6 @@ test-plug-reference-hook_1_all.snap: FAIL
1940 "lint-snap-v2:vcs_files": {
1941 "manual_review": false,
1942 "text": "OK"
1943- },
1944- "lint-snap-v2:version_valid": {
1945- "manual_review": false,
1946- "text": "OK"
1947 }
1948 },
1949 "warn": {}
1950@@ -37218,10 +36638,6 @@ test-plug-reference-hook_1_all.snap: FAIL
1951 "lint-snap-v2:vcs_files": {
1952 "manual_review": false,
1953 "text": "OK"
1954- },
1955- "lint-snap-v2:version_valid": {
1956- "manual_review": false,
1957- "text": "OK"
1958 }
1959 },
1960 "warn": {}
1961@@ -37411,10 +36827,6 @@ test-plug-reference_1_all.snap: FAIL
1962 "lint-snap-v2:vcs_files": {
1963 "manual_review": false,
1964 "text": "OK"
1965- },
1966- "lint-snap-v2:version_valid": {
1967- "manual_review": false,
1968- "text": "OK"
1969 }
1970 },
1971 "warn": {}
1972@@ -37595,10 +37007,6 @@ test-plug-reference_1_all.snap: FAIL
1973 "lint-snap-v2:vcs_files": {
1974 "manual_review": false,
1975 "text": "OK"
1976- },
1977- "lint-snap-v2:version_valid": {
1978- "manual_review": false,
1979- "text": "OK"
1980 }
1981 },
1982 "warn": {}
1983@@ -37780,10 +37188,6 @@ test-refresh-schedule_0.1_all.snap: FAIL
1984 "lint-snap-v2:vcs_files": {
1985 "manual_review": false,
1986 "text": "OK"
1987- },
1988- "lint-snap-v2:version_valid": {
1989- "manual_review": false,
1990- "text": "OK"
1991 }
1992 },
1993 "warn": {}
1994@@ -37956,10 +37360,6 @@ test-refresh-schedule_0.1_all.snap: FAIL
1995 "lint-snap-v2:vcs_files": {
1996 "manual_review": false,
1997 "text": "OK"
1998- },
1999- "lint-snap-v2:version_valid": {
2000- "manual_review": false,
2001- "text": "OK"
2002 }
2003 },
2004 "warn": {}
2005@@ -38155,10 +37555,6 @@ test-resquash-minimal_0.snap: FAIL
2006 "lint-snap-v2:vcs_files": {
2007 "manual_review": false,
2008 "text": "OK"
2009- },
2010- "lint-snap-v2:version_valid": {
2011- "manual_review": false,
2012- "text": "OK"
2013 }
2014 },
2015 "warn": {}
2016@@ -38344,10 +37740,6 @@ test-resquash-minimal_0.snap: FAIL
2017 "lint-snap-v2:vcs_files": {
2018 "manual_review": false,
2019 "text": "OK"
2020- },
2021- "lint-snap-v2:version_valid": {
2022- "manual_review": false,
2023- "text": "OK"
2024 }
2025 },
2026 "warn": {}
2027@@ -38530,10 +37922,6 @@ test-slot-cmd_1_all.snap: FAIL
2028 "lint-snap-v2:vcs_files": {
2029 "manual_review": false,
2030 "text": "OK"
2031- },
2032- "lint-snap-v2:version_valid": {
2033- "manual_review": false,
2034- "text": "OK"
2035 }
2036 },
2037 "warn": {}
2038@@ -38706,10 +38094,6 @@ test-slot-cmd_1_all.snap: FAIL
2039 "lint-snap-v2:vcs_files": {
2040 "manual_review": false,
2041 "text": "OK"
2042- },
2043- "lint-snap-v2:version_valid": {
2044- "manual_review": false,
2045- "text": "OK"
2046 }
2047 },
2048 "warn": {}
2049@@ -38903,10 +38287,6 @@ test-slot-hook_1_all.snap: FAIL
2050 "lint-snap-v2:vcs_files": {
2051 "manual_review": false,
2052 "text": "OK"
2053- },
2054- "lint-snap-v2:version_valid": {
2055- "manual_review": false,
2056- "text": "OK"
2057 }
2058 },
2059 "warn": {}
2060@@ -39091,10 +38471,6 @@ test-slot-hook_1_all.snap: FAIL
2061 "lint-snap-v2:vcs_files": {
2062 "manual_review": false,
2063 "text": "OK"
2064- },
2065- "lint-snap-v2:version_valid": {
2066- "manual_review": false,
2067- "text": "OK"
2068 }
2069 },
2070 "warn": {}
2071@@ -39296,10 +38672,6 @@ test-slot-reference-hook_1_all.snap: FAIL
2072 "lint-snap-v2:vcs_files": {
2073 "manual_review": false,
2074 "text": "OK"
2075- },
2076- "lint-snap-v2:version_valid": {
2077- "manual_review": false,
2078- "text": "OK"
2079 }
2080 },
2081 "warn": {}
2082@@ -39492,10 +38864,6 @@ test-slot-reference-hook_1_all.snap: FAIL
2083 "lint-snap-v2:vcs_files": {
2084 "manual_review": false,
2085 "text": "OK"
2086- },
2087- "lint-snap-v2:version_valid": {
2088- "manual_review": false,
2089- "text": "OK"
2090 }
2091 },
2092 "warn": {}
2093@@ -39685,10 +39053,6 @@ test-slot-reference_1_all.snap: FAIL
2094 "lint-snap-v2:vcs_files": {
2095 "manual_review": false,
2096 "text": "OK"
2097- },
2098- "lint-snap-v2:version_valid": {
2099- "manual_review": false,
2100- "text": "OK"
2101 }
2102 },
2103 "warn": {}
2104@@ -39869,10 +39233,6 @@ test-slot-reference_1_all.snap: FAIL
2105 "lint-snap-v2:vcs_files": {
2106 "manual_review": false,
2107 "text": "OK"
2108- },
2109- "lint-snap-v2:version_valid": {
2110- "manual_review": false,
2111- "text": "OK"
2112 }
2113 },
2114 "warn": {}
2115@@ -40058,10 +39418,6 @@ test-slot-toplevel_1_all.snap: FAIL
2116 "lint-snap-v2:vcs_files": {
2117 "manual_review": false,
2118 "text": "OK"
2119- },
2120- "lint-snap-v2:version_valid": {
2121- "manual_review": false,
2122- "text": "OK"
2123 }
2124 },
2125 "warn": {}
2126@@ -40238,10 +39594,6 @@ test-slot-toplevel_1_all.snap: FAIL
2127 "lint-snap-v2:vcs_files": {
2128 "manual_review": false,
2129 "text": "OK"
2130- },
2131- "lint-snap-v2:version_valid": {
2132- "manual_review": false,
2133- "text": "OK"
2134 }
2135 },
2136 "warn": {}
2137@@ -40410,10 +39762,6 @@ test-snapcraft-manifest-package-in-installed-snaps_0_amd64.snap: pass
2138 "lint-snap-v2:vcs_files": {
2139 "manual_review": false,
2140 "text": "OK"
2141- },
2142- "lint-snap-v2:version_valid": {
2143- "manual_review": false,
2144- "text": "OK"
2145 }
2146 },
2147 "warn": {}
2148@@ -40577,10 +39925,6 @@ test-snapcraft-manifest-package-in-installed-snaps_0_amd64.snap: pass
2149 "lint-snap-v2:vcs_files": {
2150 "manual_review": false,
2151 "text": "OK"
2152- },
2153- "lint-snap-v2:version_valid": {
2154- "manual_review": false,
2155- "text": "OK"
2156 }
2157 },
2158 "warn": {}
2159@@ -40749,10 +40093,6 @@ test-snapcraft-manifest-snapcraft-updated_0_amd64.snap: pass
2160 "lint-snap-v2:vcs_files": {
2161 "manual_review": false,
2162 "text": "OK"
2163- },
2164- "lint-snap-v2:version_valid": {
2165- "manual_review": false,
2166- "text": "OK"
2167 }
2168 },
2169 "warn": {}
2170@@ -40916,10 +40256,6 @@ test-snapcraft-manifest-snapcraft-updated_0_amd64.snap: pass
2171 "lint-snap-v2:vcs_files": {
2172 "manual_review": false,
2173 "text": "OK"
2174- },
2175- "lint-snap-v2:version_valid": {
2176- "manual_review": false,
2177- "text": "OK"
2178 }
2179 },
2180 "warn": {}
2181@@ -41088,10 +40424,6 @@ test-snapcraft-manifest-snapcraft-version-needed_0_amd64.snap: pass
2182 "lint-snap-v2:vcs_files": {
2183 "manual_review": false,
2184 "text": "OK"
2185- },
2186- "lint-snap-v2:version_valid": {
2187- "manual_review": false,
2188- "text": "OK"
2189 }
2190 },
2191 "warn": {}
2192@@ -41255,10 +40587,6 @@ test-snapcraft-manifest-snapcraft-version-needed_0_amd64.snap: pass
2193 "lint-snap-v2:vcs_files": {
2194 "manual_review": false,
2195 "text": "OK"
2196- },
2197- "lint-snap-v2:version_valid": {
2198- "manual_review": false,
2199- "text": "OK"
2200 }
2201 },
2202 "warn": {}
2203@@ -41427,10 +40755,6 @@ test-snapcraft-manifest-snapcraft-version_0_amd64.snap: pass
2204 "lint-snap-v2:vcs_files": {
2205 "manual_review": false,
2206 "text": "OK"
2207- },
2208- "lint-snap-v2:version_valid": {
2209- "manual_review": false,
2210- "text": "OK"
2211 }
2212 },
2213 "warn": {}
2214@@ -41594,10 +40918,6 @@ test-snapcraft-manifest-snapcraft-version_0_amd64.snap: pass
2215 "lint-snap-v2:vcs_files": {
2216 "manual_review": false,
2217 "text": "OK"
2218- },
2219- "lint-snap-v2:version_valid": {
2220- "manual_review": false,
2221- "text": "OK"
2222 }
2223 },
2224 "warn": {}
2225@@ -41766,10 +41086,6 @@ test-snapcraft-manifest-unittest_0_amd64.snap: pass
2226 "lint-snap-v2:vcs_files": {
2227 "manual_review": false,
2228 "text": "OK"
2229- },
2230- "lint-snap-v2:version_valid": {
2231- "manual_review": false,
2232- "text": "OK"
2233 }
2234 },
2235 "warn": {}
2236@@ -41933,10 +41249,6 @@ test-snapcraft-manifest-unittest_0_amd64.snap: pass
2237 "lint-snap-v2:vcs_files": {
2238 "manual_review": false,
2239 "text": "OK"
2240- },
2241- "lint-snap-v2:version_valid": {
2242- "manual_review": false,
2243- "text": "OK"
2244 }
2245 },
2246 "warn": {}
2247@@ -42105,10 +41417,6 @@ test-snapcraft-manifest_0_amd64.snap: pass
2248 "lint-snap-v2:vcs_files": {
2249 "manual_review": false,
2250 "text": "OK"
2251- },
2252- "lint-snap-v2:version_valid": {
2253- "manual_review": false,
2254- "text": "OK"
2255 }
2256 },
2257 "warn": {}
2258@@ -42272,10 +41580,6 @@ test-snapcraft-manifest_0_amd64.snap: pass
2259 "lint-snap-v2:vcs_files": {
2260 "manual_review": false,
2261 "text": "OK"
2262- },
2263- "lint-snap-v2:version_valid": {
2264- "manual_review": false,
2265- "text": "OK"
2266 }
2267 },
2268 "warn": {}
2269@@ -42500,10 +41804,6 @@ test-snapd-layout_1.0_all.snap: pass
2270 "lint-snap-v2:vcs_files": {
2271 "manual_review": false,
2272 "text": "OK"
2273- },
2274- "lint-snap-v2:version_valid": {
2275- "manual_review": false,
2276- "text": "OK"
2277 }
2278 },
2279 "warn": {}
2280@@ -42723,10 +42023,6 @@ test-snapd-layout_1.0_all.snap: pass
2281 "lint-snap-v2:vcs_files": {
2282 "manual_review": false,
2283 "text": "OK"
2284- },
2285- "lint-snap-v2:version_valid": {
2286- "manual_review": false,
2287- "text": "OK"
2288 }
2289 },
2290 "warn": {}
2291@@ -42903,10 +42199,6 @@ test-snapd-with-default-configure_3.snap: pass
2292 "lint-snap-v2:vcs_files": {
2293 "manual_review": false,
2294 "text": "OK"
2295- },
2296- "lint-snap-v2:version_valid": {
2297- "manual_review": false,
2298- "text": "OK"
2299 }
2300 },
2301 "warn": {}
2302@@ -43078,10 +42370,6 @@ test-snapd-with-default-configure_3.snap: pass
2303 "lint-snap-v2:vcs_files": {
2304 "manual_review": false,
2305 "text": "OK"
2306- },
2307- "lint-snap-v2:version_valid": {
2308- "manual_review": false,
2309- "text": "OK"
2310 }
2311 },
2312 "warn": {}
2313@@ -43211,10 +42499,6 @@ test-state-base_1_amd64.snap: FAIL
2314 "lint-snap-v2:vcs_files": {
2315 "manual_review": false,
2316 "text": "OK"
2317- },
2318- "lint-snap-v2:version_valid": {
2319- "manual_review": false,
2320- "text": "OK"
2321 }
2322 },
2323 "warn": {}
2324@@ -43331,10 +42615,6 @@ test-state-base_1_amd64.snap: FAIL
2325 "lint-snap-v2:vcs_files": {
2326 "manual_review": false,
2327 "text": "OK"
2328- },
2329- "lint-snap-v2:version_valid": {
2330- "manual_review": false,
2331- "text": "OK"
2332 }
2333 },
2334 "warn": {}
2335@@ -43512,10 +42792,6 @@ test-superprivileged-cmd_1_all.snap: FAIL
2336 "lint-snap-v2:vcs_files": {
2337 "manual_review": false,
2338 "text": "OK"
2339- },
2340- "lint-snap-v2:version_valid": {
2341- "manual_review": false,
2342- "text": "OK"
2343 }
2344 },
2345 "warn": {}
2346@@ -43688,10 +42964,6 @@ test-superprivileged-cmd_1_all.snap: FAIL
2347 "lint-snap-v2:vcs_files": {
2348 "manual_review": false,
2349 "text": "OK"
2350- },
2351- "lint-snap-v2:version_valid": {
2352- "manual_review": false,
2353- "text": "OK"
2354 }
2355 },
2356 "warn": {}
2357@@ -43881,10 +43153,6 @@ test-superprivileged-reference_1_all.snap: FAIL
2358 "lint-snap-v2:vcs_files": {
2359 "manual_review": false,
2360 "text": "OK"
2361- },
2362- "lint-snap-v2:version_valid": {
2363- "manual_review": false,
2364- "text": "OK"
2365 }
2366 },
2367 "warn": {}
2368@@ -44065,10 +43333,6 @@ test-superprivileged-reference_1_all.snap: FAIL
2369 "lint-snap-v2:vcs_files": {
2370 "manual_review": false,
2371 "text": "OK"
2372- },
2373- "lint-snap-v2:version_valid": {
2374- "manual_review": false,
2375- "text": "OK"
2376 }
2377 },
2378 "warn": {}
2379@@ -44262,10 +43526,6 @@ test-superprivileged-sneaky_1_all.snap: FAIL
2380 "lint-snap-v2:vcs_files": {
2381 "manual_review": false,
2382 "text": "OK"
2383- },
2384- "lint-snap-v2:version_valid": {
2385- "manual_review": false,
2386- "text": "OK"
2387 }
2388 },
2389 "warn": {}
2390@@ -44451,10 +43711,6 @@ test-superprivileged-sneaky_1_all.snap: FAIL
2391 "lint-snap-v2:vcs_files": {
2392 "manual_review": false,
2393 "text": "OK"
2394- },
2395- "lint-snap-v2:version_valid": {
2396- "manual_review": false,
2397- "text": "OK"
2398 }
2399 },
2400 "warn": {}
2401@@ -44649,10 +43905,6 @@ test-superprivileged-toplevel_1_all.snap: FAIL
2402 "lint-snap-v2:vcs_files": {
2403 "manual_review": false,
2404 "text": "OK"
2405- },
2406- "lint-snap-v2:version_valid": {
2407- "manual_review": false,
2408- "text": "OK"
2409 }
2410 },
2411 "warn": {}
2412@@ -44833,10 +44085,6 @@ test-superprivileged-toplevel_1_all.snap: FAIL
2413 "lint-snap-v2:vcs_files": {
2414 "manual_review": false,
2415 "text": "OK"
2416- },
2417- "lint-snap-v2:version_valid": {
2418- "manual_review": false,
2419- "text": "OK"
2420 }
2421 },
2422 "warn": {}
2423@@ -45009,10 +44257,6 @@ test-system-usernames_0_all.snap: pass
2424 "lint-snap-v2:vcs_files": {
2425 "manual_review": false,
2426 "text": "OK"
2427- },
2428- "lint-snap-v2:version_valid": {
2429- "manual_review": false,
2430- "text": "OK"
2431 }
2432 },
2433 "warn": {}
2434@@ -45180,10 +44424,6 @@ test-system-usernames_0_all.snap: pass
2435 "lint-snap-v2:vcs_files": {
2436 "manual_review": false,
2437 "text": "OK"
2438- },
2439- "lint-snap-v2:version_valid": {
2440- "manual_review": false,
2441- "text": "OK"
2442 }
2443 },
2444 "warn": {}
2445@@ -45439,10 +44679,6 @@ test-top-level-dbus-slot_1_amd64.snap: FAIL
2446 "lint-snap-v2:vcs_files": {
2447 "manual_review": false,
2448 "text": "OK"
2449- },
2450- "lint-snap-v2:version_valid": {
2451- "manual_review": false,
2452- "text": "OK"
2453 }
2454 },
2455 "warn": {}
2456@@ -45691,10 +44927,6 @@ test-top-level-dbus-slot_1_amd64.snap: FAIL
2457 "lint-snap-v2:vcs_files": {
2458 "manual_review": false,
2459 "text": "OK"
2460- },
2461- "lint-snap-v2:version_valid": {
2462- "manual_review": false,
2463- "text": "OK"
2464 }
2465 },
2466 "warn": {}
2467@@ -45815,10 +45047,6 @@ test-topdir-ro_1.0_all.snap: pass
2468 "lint-snap-v2:vcs_files": {
2469 "manual_review": false,
2470 "text": "OK"
2471- },
2472- "lint-snap-v2:version_valid": {
2473- "manual_review": false,
2474- "text": "OK"
2475 }
2476 },
2477 "warn": {}
2478@@ -45926,10 +45154,6 @@ test-topdir-ro_1.0_all.snap: pass
2479 "lint-snap-v2:vcs_files": {
2480 "manual_review": false,
2481 "text": "OK"
2482- },
2483- "lint-snap-v2:version_valid": {
2484- "manual_review": false,
2485- "text": "OK"
2486 }
2487 },
2488 "warn": {}
2489@@ -46115,10 +45339,6 @@ test-unity7-home_0.1_all.snap: pass
2490 "lint-snap-v2:vcs_files": {
2491 "manual_review": false,
2492 "text": "OK"
2493- },
2494- "lint-snap-v2:version_valid": {
2495- "manual_review": false,
2496- "text": "OK"
2497 }
2498 },
2499 "warn": {}
2500@@ -46303,10 +45523,6 @@ test-unity7-home_0.1_all.snap: pass
2501 "lint-snap-v2:vcs_files": {
2502 "manual_review": false,
2503 "text": "OK"
2504- },
2505- "lint-snap-v2:version_valid": {
2506- "manual_review": false,
2507- "text": "OK"
2508 }
2509 },
2510 "warn": {}
2511@@ -46468,10 +45684,6 @@ test-void-dir_0.1_all.snap: FAIL
2512 "lint-snap-v2:vcs_files": {
2513 "manual_review": false,
2514 "text": "OK"
2515- },
2516- "lint-snap-v2:version_valid": {
2517- "manual_review": false,
2518- "text": "OK"
2519 }
2520 },
2521 "warn": {}
2522@@ -46625,10 +45837,6 @@ test-void-dir_0.1_all.snap: FAIL
2523 "lint-snap-v2:vcs_files": {
2524 "manual_review": false,
2525 "text": "OK"
2526- },
2527- "lint-snap-v2:version_valid": {
2528- "manual_review": false,
2529- "text": "OK"
2530 }
2531 },
2532 "warn": {}
2533@@ -46816,10 +46024,6 @@ test-x11-home_0.1_all.snap: pass
2534 "lint-snap-v2:vcs_files": {
2535 "manual_review": false,
2536 "text": "OK"
2537- },
2538- "lint-snap-v2:version_valid": {
2539- "manual_review": false,
2540- "text": "OK"
2541 }
2542 },
2543 "warn": {}
2544@@ -47000,10 +46204,6 @@ test-x11-home_0.1_all.snap: pass
2545 "lint-snap-v2:vcs_files": {
2546 "manual_review": false,
2547 "text": "OK"
2548- },
2549- "lint-snap-v2:version_valid": {
2550- "manual_review": false,
2551- "text": "OK"
2552 }
2553 },
2554 "warn": {}
2555@@ -47173,10 +46373,6 @@ test-x11-no-desktop_0.1_all.snap: pass
2556 "lint-snap-v2:vcs_files": {
2557 "manual_review": false,
2558 "text": "OK"
2559- },
2560- "lint-snap-v2:version_valid": {
2561- "manual_review": false,
2562- "text": "OK"
2563 }
2564 },
2565 "warn": {}
2566@@ -47341,10 +46537,6 @@ test-x11-no-desktop_0.1_all.snap: pass
2567 "lint-snap-v2:vcs_files": {
2568 "manual_review": false,
2569 "text": "OK"
2570- },
2571- "lint-snap-v2:version_valid": {
2572- "manual_review": false,
2573- "text": "OK"
2574 }
2575 },
2576 "warn": {}
2577@@ -47456,10 +46648,6 @@ ubuntu-core_16.04.1+test1_amd64.snap: pass
2578 "lint-snap-v2:vcs_files": {
2579 "manual_review": false,
2580 "text": "OK"
2581- },
2582- "lint-snap-v2:version_valid": {
2583- "manual_review": false,
2584- "text": "OK"
2585 }
2586 },
2587 "warn": {}
2588@@ -47562,10 +46750,6 @@ ubuntu-core_16.04.1+test1_amd64.snap: pass
2589 "lint-snap-v2:vcs_files": {
2590 "manual_review": false,
2591 "text": "OK"
2592- },
2593- "lint-snap-v2:version_valid": {
2594- "manual_review": false,
2595- "text": "OK"
2596 }
2597 },
2598 "warn": {}
2599@@ -47831,10 +47015,6 @@ vlc_daily+test1_amd64.snap: pass
2600 "lint-snap-v2:vcs_files": {
2601 "manual_review": false,
2602 "text": "OK"
2603- },
2604- "lint-snap-v2:version_valid": {
2605- "manual_review": false,
2606- "text": "OK"
2607 }
2608 },
2609 "warn": {}
2610@@ -48099,10 +47279,6 @@ vlc_daily+test1_amd64.snap: pass
2611 "lint-snap-v2:vcs_files": {
2612 "manual_review": false,
2613 "text": "OK"
2614- },
2615- "lint-snap-v2:version_valid": {
2616- "manual_review": false,
2617- "text": "OK"
2618 }
2619 },
2620 "warn": {}
2621@@ -48299,10 +47475,6 @@ test-classic_0_all.snap: pass
2622 "lint-snap-v2:vcs_files": {
2623 "manual_review": false,
2624 "text": "OK"
2625- },
2626- "lint-snap-v2:version_valid": {
2627- "manual_review": false,
2628- "text": "OK"
2629 }
2630 },
2631 "warn": {}
2632@@ -48498,10 +47670,6 @@ test-classic_0_all.snap: pass
2633 "lint-snap-v2:vcs_files": {
2634 "manual_review": false,
2635 "text": "OK"
2636- },
2637- "lint-snap-v2:version_valid": {
2638- "manual_review": false,
2639- "text": "OK"
2640 }
2641 },
2642 "warn": {}
2643@@ -48690,10 +47858,6 @@ test-classic_0_all.snap: pass
2644 "lint-snap-v2:vcs_files": {
2645 "manual_review": false,
2646 "text": "OK"
2647- },
2648- "lint-snap-v2:version_valid": {
2649- "manual_review": false,
2650- "text": "OK"
2651 }
2652 },
2653 "warn": {}
2654@@ -125798,10 +124962,6 @@ hello-world_25.snap: FAIL
2655 "lint-snap-v2:vcs_files": {
2656 "manual_review": false,
2657 "text": "OK"
2658- },
2659- "lint-snap-v2:version_valid": {
2660- "manual_review": false,
2661- "text": "OK"
2662 }
2663 },
2664 "warn": {}
2665@@ -126113,10 +125273,6 @@ hello-world_25.snap: FAIL
2666 "lint-snap-v2:vcs_files": {
2667 "manual_review": false,
2668 "text": "OK"
2669- },
2670- "lint-snap-v2:version_valid": {
2671- "manual_review": false,
2672- "text": "OK"
2673 }
2674 },
2675 "warn": {}

Subscribers

People subscribed via source and target branches