review-tools

Merge ~jslarraz/review-tools:add-metasploit-execstack-override into review-tools:master

  1. Git
  2. lp:~jslarraz/review-tools
  3. add-metasploit-execstack-override
  4. Merge into master
Proposed by Jorge Sancho Larraz
Status: Merged
Merged at revision: 61c942d1df9fd9cbbc2607e6b9ffebf9facfd6df
Proposed branch: ~jslarraz/review-tools:add-metasploit-execstack-override
Merge into: review-tools:master
Diff against target: 12 lines (+1/-0)
1 file modified
reviewtools/overrides.py (+1/-0)
Reviewer Review Type Date Requested Status
Alex Murray Approve
Review via email: mp+466129@code.launchpad.net

Commit message

overrides.py: add new path to execstack overrides for metasploit as per https://forum.snapcraft.io/t/request-for-adding-execstack-override-for-metasploit-framework-snap/31865/13

To post a comment you must log in.
Revision history for this message
Alex Murray (alexmurray) wrote :

LGTM!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/reviewtools/overrides.py b/reviewtools/overrides.py
2index 60d833b..cf8437e 100644
3--- a/reviewtools/overrides.py
4+++ b/reviewtools/overrides.py
5@@ -1020,6 +1020,7 @@ func_execstack_skipped_pats = [
6 "opt/metasploit-framework/embedded/lib/ruby/gems/[0-9].*/gems/metasploit_payloads-mettle-[0-9].*/build/mips-linux-muslsf/bin/sniffer",
7 "opt/metasploit-framework/embedded/lib/ruby/gems/[0-9].*/gems/metasploit_payloads-mettle-[0-9].*/build/mipsel-linux-muslsf/bin/mettle",
8 "opt/metasploit-framework/embedded/lib/ruby/gems/[0-9].*/gems/metasploit_payloads-mettle-[0-9].*/build/mipsel-linux-muslsf/bin/sniffer",
9+ "opt/metasploit-framework/embedded/framework/data/exploits/redis/exp/exp.so",
10 ]
11
12 # Most base snaps require certain mountpoints to be present. Snaps listed here

Subscribers

People subscribed via source and target branches