review-tools

Merge ~jslarraz/review-tools:update-override-build into review-tools:master

  1. Git
  2. lp:~jslarraz/review-tools
  3. update-override-build
  4. Merge into master
Proposed by Jorge Sancho Larraz
Status: Merged
Merged at revision: 9597ca675f29711688907827fa9b3b6022ea071a
Proposed branch: ~jslarraz/review-tools:update-override-build
Merge into: review-tools:master
Diff against target: 33 lines (+3/-1)
2 files modified
override-build.sh (+1/-1)
snapcraft.yaml (+2/-0)
Reviewer Review Type Date Requested Status
Paulo Flabiano Smorigo Approve
Review via email: mp+466041@code.launchpad.net

Commit message

add-pre-commit-hook and initial-schema-support broke snap generation. This change is suppose to make it to work again

To post a comment you must log in.
Revision history for this message
Paulo Flabiano Smorigo (pfsmorigo) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/override-build.sh b/override-build.sh
2index d86fc64..e6e9bb0 100755
3--- a/override-build.sh
4+++ b/override-build.sh
5@@ -16,7 +16,7 @@ if [ -z "$RT_IGNORE_TESTS" ]; then
6
7 make coverage
8 make coverage-report
9- make syntax-check
10+ make check-syntax
11 # eventually
12 #make style-check
13 fi
14diff --git a/snapcraft.yaml b/snapcraft.yaml
15index f594b7c..227aed0 100644
16--- a/snapcraft.yaml
17+++ b/snapcraft.yaml
18@@ -79,6 +79,7 @@ parts:
19 - flake8
20 - pylint3
21 - python3-coverage
22+ - python3-jsonschema
23 - python3-magic
24 - python3-ruamel.yaml
25 - python3-requests
26@@ -95,6 +96,7 @@ parts:
27 - libmagic-mgc
28 - libmagic1
29 - python3-coverage
30+ - python3-jsonschema
31 - python3-magic
32 - python3-requests
33 - python3-ruamel.yaml

Subscribers

People subscribed via source and target branches