review-tools

Code review comment for ~jslarraz/review-tools:initial-schema-support

  1. Git
  2. lp:~jslarraz/review-tools
  3. initial-schema-support
  4. Merge into master
Revision history for this message
Jorge Sancho Larraz (jslarraz) wrote :

tests/test.sh.expected updated in https://git.launchpad.net/~jslarraz/review-tools/commit/?id=c50b51dbe818c6790ab7b378fa1ef9a3f5f14a75

Remove info when the schema is properly validated. Errors are now more generic for the whole schema validation. Change look as follows:

 = test-check-notices-primed-stage-packages-needed_0.1_amd64.snap =
 Errors
 ------
- - lint-snap-v2:name_valid
- malformed 'name': 'test-check-notices-primed-stage-packages-needed' (length '47' exceeds store limit '40')
+ - lint-snap-v2:snap_schema
+ Error found in snap.yaml while validating $.name: 'test-check-notices-primed-stage-packages-needed' is too long
 test-check-notices-primed-stage-packages-needed_0.1_amd64.snap: FAIL

« Back to merge proposal