Code review comment for ~jslarraz/review-tools:fix-pylintrc

Revision history for this message
Jorge Sancho Larraz (jslarraz) wrote :

Hey Alex, It seems I didn't save the inline commentaries :(

You are right in newer releases pylint complain about it. I've just tested in focal and using `builtin.Exception` seems to work properly.

However, as stated in the (non-previously-saved) inline commentary, I would still prefer to remove this configuration option and fallback to its default `builtin.BaseException, builtin.Exception` if there is no specific reason to prevent the use of `builtin.BaseException`.

Thanks for the review!

« Back to merge proposal