Code review comment for ~jslarraz/review-tools:fix-pylintrc

Revision history for this message
Alex Murray (alexmurray) wrote :

Running this on Noble I see the following:

± ./run-pylint
= pylint =
Checking ./reviewtools/__init__.py
pylint: Command line or configuration file:1: UserWarning: 'Exception' is not a proper value for the 'overgeneral-exceptions' option. Use fully qualified name (maybe 'builtins.Exception' ?) instead. This will cease to be checked at runtime when the configuration upgrader is released.
....

Do you know if it would be backwards compatible to change this to:

diff --git a/pylintrc b/pylintrc
index 1ccf6e17e5..2ea3aa0ec3 100644
--- a/pylintrc
+++ b/pylintrc
@@ -87,4 +87,4 @@ valid-metaclass-classmethod-first-arg=mcs
 # Exceptions that will emit a warning when being caught. Defaults to
 # "BaseException, Exception".
 #overgeneral-exceptions=BaseException, Exception
-overgeneral-exceptions=Exception
\ No newline at end of file
+overgeneral-exceptions=builtin.Exception

« Back to merge proposal