Merge ~jslarraz/review-tools:fix-custom-device-info into review-tools:master

[Jorge Sancho Larraz]

correct custom-device base declaration and attributes

[Jorge Sancho Larraz (jslarraz)]

Info updated according to https://snapcraft.io/docs/custom-device-interface and https://github.com/snapcore/snapd/blob/master/interfaces/builtin/custom_device.go

[Alex Murray (alexmurray)]

Thanks for this @jslarraz - but I still see the read-devices slot attribute referenced in upstream snapd - https://github.com/snapcore/snapd/blob/master/interfaces/builtin/custom_device.go#L246 - so I think this should be retained - but the change from content to custom-device for the plug attribute looks right.

review: Needs Fixing

f7fd05a... by Jorge Sancho Larraz on 2024-02-13

retain devices-read/slot

[Jorge Sancho Larraz (jslarraz)]

Thanks Alex for the review. devices-read/slot retained in commit https://git.launchpad.net/~jslarraz/review-tools/commit/?id=f7fd05ad122c55eccc5f3db924160567868b9420

Whilst there a reference to devices-read in https://snapcraft.io/docs/custom-device-interface, it is not listed in the attributes section. Is is something we want/can address?

[Alex Murray (alexmurray)]

Thanks @jslarraz - we should reach out to ~morrisong about that documentation issue - or perhaps just add a comment on the associated forum page for that documentation https://forum.snapcraft.io/t/the-custom-device-interface/29487

review: Approve

[Jorge Sancho Larraz (jslarraz)]

Thanks Alex, I created a commentary in the related forum topic

diff --git a/reviewtools/data/snapd-base-declaration.yaml b/reviewtools/data/snapd-base-declaration.yaml
index b3729e2..20c78eb 100644
--- a/reviewtools/data/snapd-base-declaration.yaml
+++ b/reviewtools/data/snapd-base-declaration.yaml
@@ -316,7 +316,7 @@
     allow-installation: false
     allow-connection:
       plug-attributes:
-        content: $SLOT(custom-device)
+        custom-device: $SLOT(custom-device)
     deny-auto-connection: true
   daemon-notify:
     allow-installation:
diff --git a/reviewtools/sr_common.py b/reviewtools/sr_common.py
index c6db26c..49890be 100644
--- a/reviewtools/sr_common.py
+++ b/reviewtools/sr_common.py
@@ -242,7 +242,6 @@ class SnapReview(Review):
         },
         "cups": {"cups-socket-directory/slots": ""},
         "custom-device": {
-            "content/plugs": "",
             "devices/slots": [],
             "read-devices/slots": [],
             "files/slots": {},