Ubuntu
couchdb package

Code review comment for lp:~jsjgruber/ubuntu/oneiric/couchdb/couchdb.fix780972.r1039345

  1. Oneiric (11.10)
  2. couchdb.fix780972.r1039345
  3. Merge into oneiric
Revision history for this message
dobey (dobey) wrote :

I'm voting my disapproval of this branch, not because I think the patch is bad, but because of how it is applied. Patches need to be files under debian/patches/ (like all the other patches in this package), and not direct changes in the tree. You also should not include your PPA ~version piece in the changelog version string for an upload into Ubuntu proper.

Since it was quick to do, I've went ahead and made another branch and proposed it, by making the changes into a proper patch, and tweaking the changelog entry, while still properly attributing the fix to you. It is at https://code.launchpad.net/~dobey/ubuntu/oneiric/couchdb/fix-780972/+merge/75238

Thanks.

review: Disapprove

« Back to merge proposal