Merge lp:~jsjgruber/lernid/lernid-proposed into lp:lernid

Proposed by John S. Gruber
Status: Merged
Merged at revision: 228
Proposed branch: lp:~jsjgruber/lernid/lernid-proposed
Merge into: lp:lernid
Diff against target: 142 lines (+39/-7)
8 files modified
bin/lernid (+8/-2)
data/stylesheet (+1/-0)
debian/changelog (+18/-0)
lernid/lernidconfig.py (+1/-1)
lernid/widgets/Browser.py (+5/-1)
lernid/widgets/Schedule.py (+4/-1)
lernid/widgets/Slide.py (+1/-1)
setup.py (+1/-1)
To merge this branch: bzr merge lp:~jsjgruber/lernid/lernid-proposed
Reviewer Review Type Date Requested Status
John S. Gruber Pending
Review via email: mp+68631@code.launchpad.net

Description of the change

Proposed changes to lp:lernid and ppa:lernid-devs/lernid-releases

To post a comment you must log in.
lp:~jsjgruber/lernid/lernid-proposed updated
228. By John S. Gruber

* Note that LP: #808982 is fixed
* Allow anyone (with voice) to change slides or switch browser if channel
    is moderated.
* Wrap notification requests in try: clause so failure doesn't cause lernid to
    error. Fixes LP: #808982
* Set user-stylesheet-uri in webkit settings to circumvent webkit problem
    with webkit-box-shadow. Fixes LP: #793780. Thanks to the Midori
    project for covering this in their FAQ at http://wiki.xfce.org/midori/faq

* Set new version number

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'bin/lernid'
--- bin/lernid 2011-06-29 00:23:41 +0000
+++ bin/lernid 2011-07-21 05:26:00 +0000
@@ -154,7 +154,10 @@
154 def event_interrupted(self, event):154 def event_interrupted(self, event):
155 logging.error("event interrupted")155 logging.error("event interrupted")
156 n=pynotify.Notification(_('Event Connection Interrupted'), _('Please reestablish your Internet connection\nand reconnect to the event'), 'lernid')156 n=pynotify.Notification(_('Event Connection Interrupted'), _('Please reestablish your Internet connection\nand reconnect to the event'), 'lernid')
157 n.show()157 try:
158 n.show()
159 except:
160 logging.error("Notification failed to show for Interrupted Event Message")
158 Statusbar.push_message(_('Event Connection Interrupted -- '161 Statusbar.push_message(_('Event Connection Interrupted -- '
159 'Please reestablish your Internet connection and reconnect to the event'))162 'Please reestablish your Internet connection and reconnect to the event'))
160 self.emit('event-disconnect', event)163 self.emit('event-disconnect', event)
@@ -215,7 +218,10 @@
215 'Add "Question:" to the beginning of your query '218 'Add "Question:" to the beginning of your query '
216 'to direct it to the classroom instructor.')219 'to direct it to the classroom instructor.')
217 notification = pynotify.Notification(message1, message2, 'lernid')220 notification = pynotify.Notification(message1, message2, 'lernid')
218 notification.show()221 try:
222 notification.show()
223 except:
224 logging.error("Notification failed for Interaction Message")
219225
220 self._eventman.connect('event-connect', event_connected)226 self._eventman.connect('event-connect', event_connected)
221227
222228
=== added file 'data/stylesheet'
--- data/stylesheet 1970-01-01 00:00:00 +0000
+++ data/stylesheet 2011-07-21 05:26:00 +0000
@@ -0,0 +1,1 @@
1* {-webkit-box-shadow: none !important;}
02
=== modified file 'debian/changelog'
--- debian/changelog 2011-07-06 20:12:53 +0000
+++ debian/changelog 2011-07-21 05:26:00 +0000
@@ -1,3 +1,21 @@
1lernid (0.8.1.5) natty; urgency=low
2
3 * Note that LP: #808982 is fixed
4
5 * Allow anyone (with voice) to change slides or switch browser if channel
6 is moderated.
7
8 * Wrap notification requests in try: clause so failure doesn't cause lernid to
9 error. Fixes LP: #808982
10
11 * Set user-stylesheet-uri in webkit settings to circumvent webkit problem
12 with webkit-box-shadow. Fixes LP: #793780. Thanks to the Midori
13 project for covering this in their FAQ at http://wiki.xfce.org/midori/faq
14
15 * Set new version number
16
17 -- John S Gruber <JohnSGruber@gmail.com> Thu, 21 Jul 2011 01:14:04 -0400
18
1lernid (0.8.1.4.1) natty; urgency=low19lernid (0.8.1.4.1) natty; urgency=low
220
3 No change entry to note fixed bugs in bazaar. 21 No change entry to note fixed bugs in bazaar.
422
=== modified file 'lernid/lernidconfig.py'
--- lernid/lernidconfig.py 2011-06-27 23:02:17 +0000
+++ lernid/lernidconfig.py 2011-07-21 05:26:00 +0000
@@ -31,7 +31,7 @@
3131
32def _(message): return message32def _(message): return message
3333
34VERSION = '0.8.1.4'34VERSION = '0.8.1.5'
35DESCRIPTION = _('Connect to a world of online tutorials quickly and easily.')35DESCRIPTION = _('Connect to a world of online tutorials quickly and easily.')
36WEBSITE = 'http://wiki.ubuntu.com/Lernid'36WEBSITE = 'http://wiki.ubuntu.com/Lernid'
37CONTRIBUTORS = [37CONTRIBUTORS = [
3838
=== modified file 'lernid/widgets/Browser.py'
--- lernid/widgets/Browser.py 2011-06-27 16:39:33 +0000
+++ lernid/widgets/Browser.py 2011-07-21 05:26:00 +0000
@@ -25,6 +25,7 @@
2525
26from lernid.widgets.Widget import Widget26from lernid.widgets.Widget import Widget
27from lernid.LernidOptions import Options27from lernid.LernidOptions import Options
28from lernid.lernidconfig import get_data_path
2829
29class Browser(Widget):30class Browser(Widget):
3031
@@ -82,6 +83,9 @@
8283
83 self._toolbar.set_sensitive(False)84 self._toolbar.set_sensitive(False)
8485
86 self._browser_settings = self._browser.get_settings()
87 self._browser_settings.set_property('user-stylesheet-uri', 'file://'+get_data_path()+'/stylesheet')
88
85 def do_event_connect(self, eventman, event):89 def do_event_connect(self, eventman, event):
86 classroom = eventman.get_widget_by_name('classroom')90 classroom = eventman.get_widget_by_name('classroom')
87 self.event_connect_signal(classroom, 'message-received', self._classroom_msg_received)91 self.event_connect_signal(classroom, 'message-received', self._classroom_msg_received)
@@ -182,7 +186,7 @@
182 self.set_location(url)186 self.set_location(url)
183187
184 def _classroom_msg_received(self, classroom, chan, sender, text):188 def _classroom_msg_received(self, classroom, chan, sender, text):
185 if not Options.get('unsafe-override') and not self._on_faculty(sender):189 if not Options.get('unsafe-override') and not chan.is_moderated() and not self._on_faculty(sender):
186 return190 return
187 load, ignore = self._parse_urls(text)191 load, ignore = self._parse_urls(text)
188 if load and not self._paused:192 if load and not self._paused:
189193
=== modified file 'lernid/widgets/Schedule.py'
--- lernid/widgets/Schedule.py 2011-06-27 23:02:17 +0000
+++ lernid/widgets/Schedule.py 2011-07-21 05:26:00 +0000
@@ -211,4 +211,7 @@
211211
212 def show_notification(self, summary, body):212 def show_notification(self, summary, body):
213 n = pynotify.Notification(summary, body, 'lernid')213 n = pynotify.Notification(summary, body, 'lernid')
214 n.show()214 try:
215 n.show()
216 except:
217 logging.debug("Notification failed from Schedule Widget")
215218
=== modified file 'lernid/widgets/Slide.py'
--- lernid/widgets/Slide.py 2011-06-27 23:02:17 +0000
+++ lernid/widgets/Slide.py 2011-07-21 05:26:00 +0000
@@ -93,7 +93,7 @@
93 def _classroom_msg_received(self, classroom, chan, sender, text):93 def _classroom_msg_received(self, classroom, chan, sender, text):
94 matches = re.search(r'\[SLIDE (\d+)\]', text.upper())94 matches = re.search(r'\[SLIDE (\d+)\]', text.upper())
95 if matches and self._session_slide_downloaded:95 if matches and self._session_slide_downloaded:
96 if self._on_faculty(sender):96 if chan.is_moderated() or self._on_faculty(sender):
97 self._change_slide_page(int(matches.groups()[0]))97 self._change_slide_page(int(matches.groups()[0]))
9898
99 def _change_slide_page(self, pagenumber):99 def _change_slide_page(self, pagenumber):
100100
=== modified file 'setup.py'
--- setup.py 2011-06-27 15:06:48 +0000
+++ setup.py 2011-07-21 05:26:00 +0000
@@ -68,7 +68,7 @@
6868
69setup(69setup(
70 name = 'lernid',70 name = 'lernid',
71 version = '0.8.1.4',71 version = '0.8.1.5',
72 license = 'GPL-3',72 license = 'GPL-3',
73 author = 'John S Gruber',73 author = 'John S Gruber',
74 author_email = 'johnsgruber@gmail.com',74 author_email = 'johnsgruber@gmail.com',

Subscribers

People subscribed via source and target branches