Merge lp:~jsjgruber/lernid/lernid-proposed into lp:lernid

Proposed by John S. Gruber
Status: Merged
Merged at revision: 228
Proposed branch: lp:~jsjgruber/lernid/lernid-proposed
Merge into: lp:lernid
Diff against target: 142 lines (+39/-7)
8 files modified
bin/lernid (+8/-2)
data/stylesheet (+1/-0)
debian/changelog (+18/-0)
lernid/lernidconfig.py (+1/-1)
lernid/widgets/Browser.py (+5/-1)
lernid/widgets/Schedule.py (+4/-1)
lernid/widgets/Slide.py (+1/-1)
setup.py (+1/-1)
To merge this branch: bzr merge lp:~jsjgruber/lernid/lernid-proposed
Reviewer Review Type Date Requested Status
John S. Gruber Pending
Review via email: mp+68631@code.launchpad.net

Description of the change

Proposed changes to lp:lernid and ppa:lernid-devs/lernid-releases

To post a comment you must log in.
lp:~jsjgruber/lernid/lernid-proposed updated
228. By John S. Gruber

* Note that LP: #808982 is fixed
* Allow anyone (with voice) to change slides or switch browser if channel
    is moderated.
* Wrap notification requests in try: clause so failure doesn't cause lernid to
    error. Fixes LP: #808982
* Set user-stylesheet-uri in webkit settings to circumvent webkit problem
    with webkit-box-shadow. Fixes LP: #793780. Thanks to the Midori
    project for covering this in their FAQ at http://wiki.xfce.org/midori/faq

* Set new version number

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'bin/lernid'
2--- bin/lernid 2011-06-29 00:23:41 +0000
3+++ bin/lernid 2011-07-21 05:26:00 +0000
4@@ -154,7 +154,10 @@
5 def event_interrupted(self, event):
6 logging.error("event interrupted")
7 n=pynotify.Notification(_('Event Connection Interrupted'), _('Please reestablish your Internet connection\nand reconnect to the event'), 'lernid')
8- n.show()
9+ try:
10+ n.show()
11+ except:
12+ logging.error("Notification failed to show for Interrupted Event Message")
13 Statusbar.push_message(_('Event Connection Interrupted -- '
14 'Please reestablish your Internet connection and reconnect to the event'))
15 self.emit('event-disconnect', event)
16@@ -215,7 +218,10 @@
17 'Add "Question:" to the beginning of your query '
18 'to direct it to the classroom instructor.')
19 notification = pynotify.Notification(message1, message2, 'lernid')
20- notification.show()
21+ try:
22+ notification.show()
23+ except:
24+ logging.error("Notification failed for Interaction Message")
25
26 self._eventman.connect('event-connect', event_connected)
27
28
29=== added file 'data/stylesheet'
30--- data/stylesheet 1970-01-01 00:00:00 +0000
31+++ data/stylesheet 2011-07-21 05:26:00 +0000
32@@ -0,0 +1,1 @@
33+* {-webkit-box-shadow: none !important;}
34
35=== modified file 'debian/changelog'
36--- debian/changelog 2011-07-06 20:12:53 +0000
37+++ debian/changelog 2011-07-21 05:26:00 +0000
38@@ -1,3 +1,21 @@
39+lernid (0.8.1.5) natty; urgency=low
40+
41+ * Note that LP: #808982 is fixed
42+
43+ * Allow anyone (with voice) to change slides or switch browser if channel
44+ is moderated.
45+
46+ * Wrap notification requests in try: clause so failure doesn't cause lernid to
47+ error. Fixes LP: #808982
48+
49+ * Set user-stylesheet-uri in webkit settings to circumvent webkit problem
50+ with webkit-box-shadow. Fixes LP: #793780. Thanks to the Midori
51+ project for covering this in their FAQ at http://wiki.xfce.org/midori/faq
52+
53+ * Set new version number
54+
55+ -- John S Gruber <JohnSGruber@gmail.com> Thu, 21 Jul 2011 01:14:04 -0400
56+
57 lernid (0.8.1.4.1) natty; urgency=low
58
59 No change entry to note fixed bugs in bazaar.
60
61=== modified file 'lernid/lernidconfig.py'
62--- lernid/lernidconfig.py 2011-06-27 23:02:17 +0000
63+++ lernid/lernidconfig.py 2011-07-21 05:26:00 +0000
64@@ -31,7 +31,7 @@
65
66 def _(message): return message
67
68-VERSION = '0.8.1.4'
69+VERSION = '0.8.1.5'
70 DESCRIPTION = _('Connect to a world of online tutorials quickly and easily.')
71 WEBSITE = 'http://wiki.ubuntu.com/Lernid'
72 CONTRIBUTORS = [
73
74=== modified file 'lernid/widgets/Browser.py'
75--- lernid/widgets/Browser.py 2011-06-27 16:39:33 +0000
76+++ lernid/widgets/Browser.py 2011-07-21 05:26:00 +0000
77@@ -25,6 +25,7 @@
78
79 from lernid.widgets.Widget import Widget
80 from lernid.LernidOptions import Options
81+from lernid.lernidconfig import get_data_path
82
83 class Browser(Widget):
84
85@@ -82,6 +83,9 @@
86
87 self._toolbar.set_sensitive(False)
88
89+ self._browser_settings = self._browser.get_settings()
90+ self._browser_settings.set_property('user-stylesheet-uri', 'file://'+get_data_path()+'/stylesheet')
91+
92 def do_event_connect(self, eventman, event):
93 classroom = eventman.get_widget_by_name('classroom')
94 self.event_connect_signal(classroom, 'message-received', self._classroom_msg_received)
95@@ -182,7 +186,7 @@
96 self.set_location(url)
97
98 def _classroom_msg_received(self, classroom, chan, sender, text):
99- if not Options.get('unsafe-override') and not self._on_faculty(sender):
100+ if not Options.get('unsafe-override') and not chan.is_moderated() and not self._on_faculty(sender):
101 return
102 load, ignore = self._parse_urls(text)
103 if load and not self._paused:
104
105=== modified file 'lernid/widgets/Schedule.py'
106--- lernid/widgets/Schedule.py 2011-06-27 23:02:17 +0000
107+++ lernid/widgets/Schedule.py 2011-07-21 05:26:00 +0000
108@@ -211,4 +211,7 @@
109
110 def show_notification(self, summary, body):
111 n = pynotify.Notification(summary, body, 'lernid')
112- n.show()
113+ try:
114+ n.show()
115+ except:
116+ logging.debug("Notification failed from Schedule Widget")
117
118=== modified file 'lernid/widgets/Slide.py'
119--- lernid/widgets/Slide.py 2011-06-27 23:02:17 +0000
120+++ lernid/widgets/Slide.py 2011-07-21 05:26:00 +0000
121@@ -93,7 +93,7 @@
122 def _classroom_msg_received(self, classroom, chan, sender, text):
123 matches = re.search(r'\[SLIDE (\d+)\]', text.upper())
124 if matches and self._session_slide_downloaded:
125- if self._on_faculty(sender):
126+ if chan.is_moderated() or self._on_faculty(sender):
127 self._change_slide_page(int(matches.groups()[0]))
128
129 def _change_slide_page(self, pagenumber):
130
131=== modified file 'setup.py'
132--- setup.py 2011-06-27 15:06:48 +0000
133+++ setup.py 2011-07-21 05:26:00 +0000
134@@ -68,7 +68,7 @@
135
136 setup(
137 name = 'lernid',
138- version = '0.8.1.4',
139+ version = '0.8.1.5',
140 license = 'GPL-3',
141 author = 'John S Gruber',
142 author_email = 'johnsgruber@gmail.com',

Subscribers

People subscribed via source and target branches