Code review comment for lp:~jsing/juju-deployer/resources-support

Revision history for this message
Tim Van Steenburgh (tvansteenburgh) wrote :

This LGTM but I hit one error in the tests:

======================================================================
ERROR: test_importer_with_resources (deployer.tests.test_importer.ImporterTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/tvansteenburgh/src/juju-deployer/.tox/py35/lib/python3.5/site-packages/mock/mock.py", line 1305, in patched
    return func(*args, **keywargs)
  File "/home/tvansteenburgh/src/juju-deployer/deployer/tests/test_importer.py", line 74, in test_importer_with_resources
    os.path.join(self.test_data_dir, 'wiki-resources.yaml')])
  File "/home/tvansteenburgh/src/juju-deployer/deployer/config.py", line 34, in __init__
    self.load()
  File "/home/tvansteenburgh/src/juju-deployer/deployer/config.py", line 92, in load
    for fp in self._resolve_included():
  File "/home/tvansteenburgh/src/juju-deployer/deployer/config.py", line 141, in _resolve_included
    [files.extend(self._includes(cf)) for cf in self.config_files]
  File "/home/tvansteenburgh/src/juju-deployer/deployer/config.py", line 141, in <listcomp>
    [files.extend(self._includes(cf)) for cf in self.config_files]
  File "/home/tvansteenburgh/src/juju-deployer/deployer/config.py", line 123, in _includes
    d = self._yaml_load(config_file)
  File "/home/tvansteenburgh/src/juju-deployer/deployer/config.py", line 51, in _yaml_load
    with open(config_file) as fh:
FileNotFoundError: [Errno 2] No such file or directory: '/home/tvansteenburgh/src/juju-deployer/deployer/tests/test_data/wiki-resources.yaml'

Is there a wiki-resources.yaml file that didn't get included in the commit?

review: Needs Fixing

« Back to merge proposal