Merge lp:~jshepher/glance/lp798749 into lp:~hudson-openstack/glance/trunk

Proposed by Justin Shepherd
Status: Merged
Approved by: Jay Pipes
Approved revision: 171
Merged at revision: 172
Proposed branch: lp:~jshepher/glance/lp798749
Merge into: lp:~hudson-openstack/glance/trunk
Diff against target: 41 lines (+13/-13)
1 file modified
bin/glance-upload (+13/-13)
To merge this branch: bzr merge lp:~jshepher/glance/lp798749
Reviewer Review Type Date Requested Status
Jay Pipes (community) Approve
Devin Carlen (community) Approve
Review via email: mp+69874@code.launchpad.net

Description of the change

Use of "%default" in help string does not work, have to use "%(default)s". Per the 4th example http://docs.python.org/dev/library/argparse.html#prog

To post a comment you must log in.
Revision history for this message
Devin Carlen (devcamcar) wrote :

lgtm

review: Approve
Revision history for this message
Jay Pipes (jaypipes) wrote :

thx Shep!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'bin/glance-upload'
--- bin/glance-upload 2011-03-05 17:04:43 +0000
+++ bin/glance-upload 2011-07-30 04:35:49 +0000
@@ -73,25 +73,25 @@
73 parser.add_argument('filename', help='file to upload into Glance')73 parser.add_argument('filename', help='file to upload into Glance')
74 parser.add_argument('name', help='name of image')74 parser.add_argument('name', help='name of image')
75 parser.add_argument('--host', metavar='HOST', default='127.0.0.1',75 parser.add_argument('--host', metavar='HOST', default='127.0.0.1',
76 help='Location of Glance Server (default: %default)')76 help='Location of Glance Server (default: %(default)s)')
77 parser.add_argument('--port', metavar='PORT', type=int, default=9292,77 parser.add_argument('--port', metavar='PORT', type=int, default=9292,
78 help='Port of Glance Server (default: %default)')78 help='Port of Glance Server (default: %(default)s)')
79 parser.add_argument('--type', metavar='TYPE', default='raw',79 parser.add_argument('--type', metavar='TYPE', default='raw',
80 help='Type of Image [kernel, ramdisk, machine, raw] '80 help='Type of Image [kernel, ramdisk, machine, raw] '
81 '(default: %default)')81 '(default: %(default)s)')
82 parser.add_argument('--disk-format', metavar='DISK_FORMAT', default=None,82 parser.add_argument('--disk-format', metavar='DISK_FORMAT', default=None,
83 choices=DISK_FORMATS,83 choices=DISK_FORMATS,
84 help='Disk format of Image [%s] '84 help='Disk format of Image [%s] '
85 '(default: %%default)' % ','.join(DISK_FORMATS))85 '(default: %%(default)s)' % ','.join(DISK_FORMATS))
86 parser.add_argument('--container-format', metavar='CONTAINER_FORMAT',86 parser.add_argument('--container-format', metavar='CONTAINER_FORMAT',
87 default=None, choices=CONTAINER_FORMATS,87 default=None, choices=CONTAINER_FORMATS,
88 help='Disk format of Image [%s] '88 help='Disk format of Image [%s] '
89 '(default: %%default)' % ','.join(CONTAINER_FORMATS))89 '(default: %%(default)s)' % ','.join(CONTAINER_FORMATS))
90 parser.add_argument('--kernel', metavar='KERNEL',90 parser.add_argument('--kernel', metavar='KERNEL',
91 help='ID of kernel associated with this machine image')91 help='ID of kernel associated with this machine image')
92 parser.add_argument('--ramdisk', metavar='RAMDISK',92 parser.add_argument('--ramdisk', metavar='RAMDISK',
93 help='ID of ramdisk associated with this machine '93 help='ID of ramdisk associated with this machine '
94 'image')94 'image')
95 args = parser.parse_args()95 args = parser.parse_args()
96 return args96 return args
9797

Subscribers

People subscribed via source and target branches