Code review comment for lp:~jseutter/landscape-client/srv-autodiscover

Revision history for this message
Thomas Herve (therve) wrote :

[14]
+ SRV_RESPONSE = args["srv_response"]
+ A_RESPONSE = args["a_response"]

This means you always need to pass the options, the defaults defined above aren't used.

[15]
+ name = row.payload.target

The type of target is a dns.Name instance, not a simple string (it works because they have a correct __str__). Can you return name.name instead, and fix the tests?

I guess what remains is the customization of the service name and the hostname? You plan to do that in the next branch?

Thanks:

review: Approve

« Back to merge proposal