Code review comment for lp:~jr/bzr/i18n-unoverride-no-i18n-tests

Revision history for this message
Vincent Ladeuil (vila) wrote :

Thanks for following up on this !

70 + self.enableI18n()
71 from bzrlib import help
72 i18n.install()
73 self.overrideAttr(i18n, '_translations', ZzzTranslations())

Since these tests are already installing a specific translation, do they really need enable18n() ? Isn't there some possible simplification across:

- i18n.installed (disable multiple installs)
- TestCase.enable18n() (restore the ability to install, err, really?)
- i18n._translations (backdoor to install anyway)

In fact, I think the tests do not care about i18n.installed no ?

review: Needs Information

« Back to merge proposal