Code review comment for lp:~jr/bzr/i18n-options

Revision history for this message
Vincent Ladeuil (vila) wrote :

Some of the problems you're encountering were already mentioned in https://code.launchpad.net/~songofacandy/bzr/i18n-command/+merge/62752

Some of the proposed solutions (which couldn't be applied at that time) may also apply here.

Mainly, OptionParser use HelpFormatter and using our own derived class (instead of overriding lower level methods) should address the import issues by delaying the help formatting until our i18n framework is installed.

As said in the review above, this may require a bit more work upfront but should result in less code in the end and simplify the maintenance in the long term.

Also if "imports config which imports commands" is probably fixable.

I can help on both points if you want.

review: Needs Information

« Back to merge proposal