Code review comment for lp:~jr/bzr/bzr-gpgme

Thanks for taking this on.. it's one of the oldest unfinished features in bzr I think :) Not a full review, but some quick notes:

VerifyFailed seems a bit too generic a name for something that applies only to verifying signatures. Perhaps something like SignatureVerificationFailed ?

GpgmeNotInstalled should probably derive from DependencyNotPresent (see also ParamikoNotPresent in bzrlib.errors).

Tests that use this should probably call self.requireFeature(GPGMeFeature) or something along those lines to make sure the tests are skipped for people that do not have gpgme installed.