Code review comment for lp:~jr/bzr-explorer/781204-fix-deprecated-usage

Revision history for this message
John A Meinel (jameinel) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 6/3/2011 5:41 PM, Jonathan Riddell wrote:
> Jonathan Riddell has proposed merging lp:~jr/bzr-explorer/781204-fix-deprecated-usage into lp:bzr-explorer.
>
> Requested reviews:
> Bazaar Explorer Developers (bzr-explorer-dev)
> Related bugs:
> Bug #781204 in Bazaar Explorer: "deprecated API usage"
> https://bugs.launchpad.net/bzr-explorer/+bug/781204
>
> For more details, see:
> https://code.launchpad.net/~jr/bzr-explorer/781204-fix-deprecated-usage/+merge/63398
>
> Use cmdline.split() instead
>

Is there a version compatibility concern here? I'm not positive, but it
looks like these sort of commands showed up around 2.1/2.2. Which could
be old enough qbzr doesn't care.

The changes are certainly good vs bzr trunk.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk3s4WsACgkQJdeBCYSNAANlKQCgvpMY/XqvPf8y9irepPLDg5oH
Z0EAnA92lw5RMSx9mgQcuu16M8yaoZ9K
=Uwue
-----END PGP SIGNATURE-----

« Back to merge proposal