Code review comment for lp:~jr/bzr-builddeb/changelog-closes-bugs

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

We generally try to avoid doing more imports than necessary in the __init__.py of plugins, as everything there gets imported every time bzr is started. "bzrlib.bugtracker" is usually not loaded on startup, so it would make sense to import it only in debian_changelog_commit when it is actually used.

commit.builder._revprops should be public if plugins have to touch it; this should probably be part of adding the set_commit_message hook.

Oh, and the really nitpicky bit.. PEP8 requires two empty lines around top-level things, so you need an extra newline above and an extra newline below debian_changelog_commit.

A basic test would be nice, even if just exercises debian_changelog_commit directly.

« Back to merge proposal