Code review comment for lp:~jr/bzr-builddeb/862188-get-tar

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

Thanks! Some more minor comments:

Please use four-space indentation in new files - I realize some of the existing bzr-builddeb tests still use two-space indentation, but we should slowly get rid of that rather than add more files with two-space indentation.

When would provide() return an empty list? Also, I think the other entries in the list should also be displayed, not just the first one.

get-tar seems fairly generic for something that is a bzr subcommand - it could mean a lot of things, e.g. be confused with "bzr export foo.tar.gz". What about something like get-orig-source, deb-orig-source ?

 + "get_tar": ["bd"],

This register "bd" as an alias for get_tar, but it is also already registered for "bzr builddeb".

« Back to merge proposal