Code review comment for lp:~jr/bzr-builddeb/862188-get-tar

Thanks for adding this.

give_instruction doesn't appear to be used.

This should have tests, as well as an entry in debian/changelog.

UpstreamProvider.provide() can raise exceptions - in particular, it could raise an exception if the current version is not available, in which case a sane error message should be printed rather than a backtrace.

It would be nice if it could print where exactly it has generated a file.

The call to generate build_source_dir seems pointless as get_parent_dir will return the dirname.