Merge lp:~jpds/do-plugins/notification-error-messages into lp:do-plugins

[Alex Launi]

[Jonathan Davies (jpds)]

Instead of returning Do saying that there was an error pasting text, throw a notification bubble if no text is provided.

[Chris S. (cszikszoy)]

review: Approve

[Chris S. (cszikszoy)]

We should formalize how plugins interact with the user. Using the notification system seems to be a great way to gracefully display errors or small messages.

review: Approve

=== modified file 'LocateFiles/src/LocateFilesAction.cs'
--- LocateFiles/src/LocateFilesAction.cs	2009-02-28 18:23:20 +0000
+++ LocateFiles/src/LocateFilesAction.cs	2009-03-14 14:26:14 +0000
@@ -67,6 +67,13 @@
 				
 			files = new List<Item> ();
 			query = (items.First () as ITextItem).Text;
+
+			if (string.IsNullOrEmpty(query))
+			{
+				Services.Notifications.Notify("Locate Files",
+					"No text provided for searching.");
+				yield break;
+			}
 			
 			locate = new System.Diagnostics.Process ();
 			locate.StartInfo.FileName = "locate";
@@ -90,13 +97,16 @@
 				results++;
 				files.Add (Services.UniverseFactory.NewFileItem (path) as Item);
 			}
+			
 			if (results > 0) {
 				files.Sort (new IFileItemNameComparer (query));
 				foreach (Item file in files)
 					yield return file;
+			} else {
+				Services.Notifications.Notify("Locate Files",
+					Error + query);
+				yield break;
 			}
-			else
-				yield return new TextItem (Error + query);
 		}
 
 		// Order files by (A) position of query in the file name and
 
=== modified file 'Pastebin/src/Pastebin.cs'
--- Pastebin/src/Pastebin.cs	2009-01-22 04:43:21 +0000
+++ Pastebin/src/Pastebin.cs	2009-03-13 23:11:47 +0000
@@ -65,7 +65,9 @@
 			catch (Exception e)
 			{
 				Log<Pastebin>.Error (e.ToString ());
-				url = "An error occured while pasting.";
+				Services.Notifications.Notify("Pastebin",
+					"An error occured while pasting.");
+				yield break;
 			}
 			
 			return url;
 
=== modified file 'Pastebin/src/PastebinAction.cs'
--- Pastebin/src/PastebinAction.cs	2009-01-02 06:17:21 +0000
+++ Pastebin/src/PastebinAction.cs	2009-03-13 23:00:12 +0000
@@ -96,6 +96,13 @@
 				text += titem.Text;
 			}
 			
+			if (string.IsNullOrEmpty(text))
+			{
+				Services.Notifications.Notify("Pastebin",
+					"No text provided for pasting.");
+				yield break;
+			}
+			
 			IPastebinProvider pastebinProvider = null;
 					
 			if (modifierItems.Any ()) {
 
=== modified file 'RememberTheMilk/src/RTMNewTask.cs'
--- RememberTheMilk/src/RTMNewTask.cs	2009-01-29 16:58:01 +0000
+++ RememberTheMilk/src/RTMNewTask.cs	2009-03-16 12:53:58 +0000
@@ -78,6 +78,12 @@
         {
             string listId = String.Empty;
             string taskData = (items.First () as ITextItem).Text;
+            
+            if (string.IsNullOrEmpty(taskData)) {
+            	Services.Notifications.Notify("Remember The Milk",
+            		"No title provided for new task.");
+            	yield break;
+            }
 			
 			if (modifierItems.FirstOrDefault () != null)
 				listId = (modifierItems.FirstOrDefault () as RTMListItem).Id;