Code review comment for lp:~jpakkane/xorg-gtest/autofix

The line

  xorg_gtest_example_LDFLAGS = libxorg-gtest.la libxorg-gtest_main.la -lgtest -lpthread -lX11

is wrong. It should be using the symbols for libraries found in the configuration run, like this.

  xorg_gtest_example_LDFLAGS = libxorg-gtest.la libxorg-gtest_main.la $(GTEST_LDFLAGS) $(XSERVER_LIBS)

except, of course, GTEST_LDFLAGS is not set in configure.ac, only GTEST_CPPFLAGS is, so that particular library can wait for another patch later. I'd like to point out that on my machine, $(XSERVER_LIBS) does not yield the same string as '-lX11'.