Code review comment for lp:~jpakkane/unity-scopes-api/randomstuff

Revision history for this message
Jussi Pakkanen (jpakkane) wrote :

I can see why that would be useful. However:

- CMake documentation recommends against using link_directories

- for consistency we should do this for every dependency

- Debian packagers discourage the use of rpath

- if you want to add stuff to rpath, it should be done explicitly with set_target_properties

- when you have the .so both in a system directory and a custom dir, LD_LIBRARY_PATH is the only sane way to select which one is chosen (and which can be changed without recompiling)

- the simple way of solving this is to have a daily build PPA of unity-api that you can use, which is the way most projects do it

If you still feel it should be there, I can add it back in.

« Back to merge proposal