Code review comment for lp:~jpakkane/unity-notifications/simpleqml

Revision history for this message
Antti Kaijanmäki (kaijanmaki) wrote :

136 + SimpleQmlSender *cl = new SimpleQmlSender(engine);
137 + engine->rootContext()->setContextProperty("unity.notifications", cl);

I probably mentioned this before, but IMO our QML components should not mess with the QML engine directly if at all possible, but this is just my opinion. You might want to sync with the SDK team and ask if this is OK for them.

173 + QString app_name("client");
178 + QString app_icon;

So, there is no way for the app developer to set the app_name of app_icon? I guess these will not be visible on the notification bubble then.

« Back to merge proposal