Code review comment for lp:~jpakkane/unity-lens-shopping/coverage

Revision history for this message
Paweł Stołowski (stolowski) wrote :

Could you also update test_markup_cleaner_SOURCES in tests/unit/Makefile.am to include all vala files from src/ (except for config.vala and main.vala)? That way coverage report will be more accurate, as for now it's based on the only class that is unit-tested, and this results in unrealistic 100% function coverage...).

Apart from that it works fine.

review: Needs Fixing

« Back to merge proposal