Merge lp:~jpakkane/notify-osd/builddir into lp:notify-osd

Proposed by Jussi Pakkanen
Status: Needs review
Proposed branch: lp:~jpakkane/notify-osd/builddir
Merge into: lp:notify-osd
Diff against target: 26 lines (+3/-2)
2 files modified
configure.in (+1/-1)
tests/Makefile.am (+2/-1)
To merge this branch: bzr merge lp:~jpakkane/notify-osd/builddir
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Indicator Applet Developers Pending
Review via email: mp+150311@code.launchpad.net

Commit message

Make it build in a separate build directory.

Description of the change

Make it build in a separate build directory. Tests will not pass because TEMPORARY_ICON_PREFIX_WORKAROUND borkage.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Unmerged revisions

462. By Jussi Pakkanen

Enable separate build directory and fixed incorrect use of AM_MAINTAINER_MODE.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'configure.in'
--- configure.in 2012-03-23 14:35:42 +0000
+++ configure.in 2013-02-25 12:41:23 +0000
@@ -9,7 +9,7 @@
9GNOME_COMMON_INIT9GNOME_COMMON_INIT
10GNOME_COMPILE_WARNINGS(maximum)10GNOME_COMPILE_WARNINGS(maximum)
1111
12AM_MAINTAINER_MODE12AM_MAINTAINER_MODE([enable])
13AM_DISABLE_STATIC13AM_DISABLE_STATIC
14AM_PROG_LIBTOOL14AM_PROG_LIBTOOL
15AC_SUBST(ACLOCAL_AMFLAGS, "$ACLOCAL_FLAGS -I m4")15AC_SUBST(ACLOCAL_AMFLAGS, "$ACLOCAL_FLAGS -I m4")
1616
=== modified file 'tests/Makefile.am'
--- tests/Makefile.am 2011-11-01 12:45:48 +0000
+++ tests/Makefile.am 2013-02-25 12:41:23 +0000
@@ -63,7 +63,8 @@
63 $(LIBNOTIFY_CFLAGS) \63 $(LIBNOTIFY_CFLAGS) \
64 -DSRCDIR=\""$(top_srcdir)"\" \64 -DSRCDIR=\""$(top_srcdir)"\" \
65 -I$(top_srcdir)/src \65 -I$(top_srcdir)/src \
66 -I$(top_srcdir)/66 -I$(top_srcdir)/ \
67 -I$(top_builddir)/src
6768
68test_modules_LDADD = \69test_modules_LDADD = \
69 $(LIBM) \70 $(LIBM) \

Subscribers

People subscribed via source and target branches