Code review comment for lp:~jpakkane/mediascanner/immutable-mediafile

Revision history for this message
Jussi Pakkanen (jpakkane) wrote :

[1] This is something I thought about for a long time. It you make instance variables const, you can't copy them. Meaning you can't do this:

mf = some_func();

This would make Mediafile assigment atomic but not constant. Sometimes this is what you need. But I see the const issue as well. I guess we could start by making them const and unconsting them if necessary.

[2]

I'm a bit on the fence about this. I like being able to explicitly instantiate objects without other helper objects. This is a potential source of bugs, though.

[3]

Yes, change coming up.

« Back to merge proposal