Code review comment for lp:~jpakkane/grail/touchviewer

I guess I'm confused. After looking through the diff, it doesn't appear that there is any interaction with grail here. (I just re-read the proposal description, it's plainly obvious there, my mistake. :)

If I understand correctly, you created this eventviewer to show events that are recorded in an evemu recording, the purpose of which is to verify that evemu recorded the events properly? I was assuming it was a viewer tool with the sole purpose of showing what the data in the recording is.

If we want to verify that utouch-evemu is recording properly, we should have unit tests that check input vs output.

If we want a viewer tool to visually show what the data in a recording is, we should build it on top of utouch-evemu itself. Otherwise, if we need to change the format of recordings, we would need to update this parser instead of letting the evemu library handle it internally.

And this should all be proposed against utouch-evemu instead of utouch-grail :).