Merge lp:~jpakkane/dbus-cpp/depfix into lp:dbus-cpp

Proposed by Jussi Pakkanen
Status: Needs review
Proposed branch: lp:~jpakkane/dbus-cpp/depfix
Merge into: lp:dbus-cpp
Diff against target: 28 lines (+7/-4)
1 file modified
tests/CMakeLists.txt (+7/-4)
To merge this branch: bzr merge lp:~jpakkane/dbus-cpp/depfix
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Ubuntu Phablet Team Pending
Review via email: mp+165314@code.launchpad.net

Commit message

Error out if dependencies are not found.

Description of the change

Error out if dependencies are not found.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

is this going to land?

Unmerged revisions

5. By Jussi Pakkanen

Break with an error immediately if dependencies are not found.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'tests/CMakeLists.txt'
--- tests/CMakeLists.txt 2013-05-21 09:49:21 +0000
+++ tests/CMakeLists.txt 2013-05-23 09:09:29 +0000
@@ -20,11 +20,11 @@
20add_subdirectory(/usr/src/gtest gtest)20add_subdirectory(/usr/src/gtest gtest)
21set (CMAKE_CXX_FLAGS ${OLD_CMAKE_CXX_FLAGS})21set (CMAKE_CXX_FLAGS ${OLD_CMAKE_CXX_FLAGS})
2222
23find_package(PkgConfig)23find_package(PkgConfig REQUIRED)
24find_package(Boost COMPONENTS system)24find_package(Boost COMPONENTS system REQUIRED)
25find_package(Threads)25find_package(Threads REQUIRED)
2626
27pkg_check_modules(DBUS dbus-1)27pkg_check_modules(DBUS dbus-1 REQUIRED)
2828
29option(29option(
30 DBUS_CPP_ENABLE_DBUS_TEST_RUNNER 30 DBUS_CPP_ENABLE_DBUS_TEST_RUNNER
@@ -34,6 +34,9 @@
3434
35if (DBUS_CPP_ENABLE_DBUS_TEST_RUNNER)35if (DBUS_CPP_ENABLE_DBUS_TEST_RUNNER)
36 find_program(DBUS_TEST_RUNNER_EXECUTABLE dbus-test-runner)36 find_program(DBUS_TEST_RUNNER_EXECUTABLE dbus-test-runner)
37 if(NOT DBUS_TEST_RUNNER_EXECUTABLE)
38 message(FATAL_ERROR "Could not find dbus-test-runner executable.")
39 endif()
37 message(STATUS "Executing test suite under dbus-test-runner")40 message(STATUS "Executing test suite under dbus-test-runner")
38endif (DBUS_CPP_ENABLE_DBUS_TEST_RUNNER)41endif (DBUS_CPP_ENABLE_DBUS_TEST_RUNNER)
3942

Subscribers

People subscribed via source and target branches