Code review comment for lp:~jp-ellis/mg5amcnlo/allow-absolute-model-path

Revision history for this message
Olivier Mattelaer (olivier-mattelaer) wrote :

No I also return “model_name” exactly like you.
No difference on that.

> On Aug 25, 2016, at 13:45, Joshua Ellis <email address hidden> wrote:
>
> But, doesn't your patch still load the model from the MadGraph5 path, seeing as it is concatenating it with the model path?
>
> What happens if the model is outside of the MadGraph5 path entirely?
>
> Also, it is correct that I don't have the PYTHONPATH environment variable set (I'm not entirely sure why I should have it set...)
> --
> https://code.launchpad.net/~jp-ellis/mg5amcnlo/allow-absolute-model-path/+merge/303914
> You are reviewing the proposed merge of lp:~jp-ellis/mg5amcnlo/allow-absolute-model-path into lp:mg5amcnlo.

« Back to merge proposal