Merge lp:~josvaz/vmbuilder/jenkins_kvm-wala-autoupdates into lp:~ubuntu-on-ec2/vmbuilder/jenkins_kvm

[Jose L. VG]

Walinuxagent 2.2.4 includes AutoUpdate.Enable=y in the following way:

* The archive package has autoupdate OFF be default, so security reasons.

* The walinuxagent >=2.2.4 ubuntu package adds include file/fonder config overrides and enforces AutoUpdate.Enable on upgrades.

* The CPC image building process enables autoupdates for the Azure image. THIS MP takes care of it.

UPDATE:
Turns out the include support was dropped after chatting with Microsoft and instead the package will have the auto-updates on by default from the archive, so this is not needed anymore.

[lp:~josvaz/vmbuilder/jenkins_kvm-wala-autoupdates]

786. By Jose L. VG on 2017-03-01

Enable walinuxagent AutoUpdate for Azure.

[Łukasz Zemczak (sil2100)]

Don't know the image building bits, but this looks good.

One question though: this part of code is executed *after* all required packages are installed for the image, right? If that's the case, we also install this config file for all walinuxagent 2.2.4+ packages to /usr/share/walinuxagent/conf, so in theory this could be a file-copy operation instead. Not sure what the ${CLOUD_IMG_STR} is for, since that would have to be appended probably if it's needed still...

Anyway, no approving since we still need to wait for a final consensus from Microsoft, as they still didn't approve the general approach we're trying to use.

[Jose L. VG (josvaz)]

On your question: yes & no
It will eventually be done after the walinuxagent 2.2.4 or later gets installed, but for now, as the archive has 2.2.2 it will install that, set the file and later upgrade to 2.2.4, which will NOT step on it.

I do prefer this solution to a file copy cause it:
- Allows testing the image BEFORE we hit proposed.
- Having a different file header makes it clear that it was the cloudware image building and NOT the package itself who place the config there.

I understand this is blocked by Microsoft, as you say.

But I would like to have other CPC folks review and approve. Don't merge, I will sync with Lukasz before that.

[Chris Glass (tribaal)]

Looks good. One thing I couldn't easily check is that the config folder is actually picked up by walinuxagent (/etc/waagent.conf.d), but I trust it's correct.

+1

review: Approve

[Dan Watkins (oddbloke)]

+1 conditional on the support landing in walinuxagent.

review: Approve

[Jose L. VG (josvaz)]

Turns out the include support was dropped after chatting with Microsoft and instead the package will have the auto-updates on by default from the archive, so this is not needed anymore.

Unmerged revisions

786. By Jose L. VG on 2017-03-01

Enable walinuxagent AutoUpdate for Azure.

=== modified file 'templates/img-azure.tmpl'
--- templates/img-azure.tmpl	2017-02-17 11:21:39 +0000
+++ templates/img-azure.tmpl	2017-03-01 09:23:21 +0000
@@ -227,6 +227,14 @@
 xchroot apt-get -y clean
 debug "Package operations complete"
 
+# Set AutoUpdate ON in walinuxagent
+mkdir -p "${mp}/etc/waagent.conf.d"
+cat << EOF >> "${mp}/etc/waagent.conf.d/enable-autoupdate.conf"
+${CLOUD_IMG_STR}
+# This file is only loaded with walinuxagent include support (version>=2.2.4)
+AutoUpdate.Enabled=y
+EOF
+
 # Modify boot settings
 debug "Modifying in-image settings for Azure"
 xchroot sed -i "s,LABEL=cloudimg-rootfs,UUID=${dev_uuid},g" /etc/fstab