Juju Charms Collection
bip package

Code review comment for lp:~josvaz/charms/trusty/bip/client_side_ssl-with_helper-lp1604894

  1. Trusty Tahr (14.04)
  2. client_side_ssl-with_helper-lp1604894
  3. Merge into trunk
Revision history for this message
Pen Gale (pengale) wrote :

Hello Jose,

Thank you for all your work on this. The new test looks great, and passes when I run bundletester. :-)

I am +1 on this.

There is an outstanding issue with merging and promulgating this, which I noted in the related PR: the bip charm is currently own by ~charmers, rather than a specific maintainer. I can't fix that myself, but I am poking people about it; I'll ping this ticket when the issue is fixed.

review: Approve
Reply

« Back to merge proposal