Code review comment for lp:~josharenson/unity8/qa_helpers

Thanks Josh.
A couple of things.

The idea is to use these helpers before autopilot comes to play, so it's better to keep them at the module level instead of getting them as methods in the greeter autopilot custom proxy object.
The namespace of helpers is currently a little mess, so I would put them in tests/autopilot/unity8/greeter/__init__.py instead of where you put them. I have a branch in progress to solve the mess:
https://code.launchpad.net/~canonical-platform-qa/unity8/fix1306340-deprecate_emulators/+merge/257812

Next, I think we can remove the other part of unlock calling wait_for_greeter. But I'm not quite sure about this.
Take a look at my diff: http://paste.ubuntu.com/11014223/
Be warned that I didn't have time to run it, so my assumptions might be wrong or I might have left a stupid mistake.

Last think, please make sure that the code you touch passes the static checks. Call:

python3 -m flake8 .

I'm leaving for lunch, but I'll have time later and tomorrow, in case you need me.