Code review comment for lp:~josharenson/unity8/doc_args

Revision history for this message
Albert Astals Cid (aacid) wrote :

> > This breaks the -windowgeometry param, i.e.
> >
> > ./builddir/src/unity8 -windowgeometry 400x400
> >
> > Doesn't work anymore
> Pushed a small hack to WAR this. Let me know if you have an idea for something
> more elegant.

I think i'd prefer if you move the parsing of the argument to main.cpp and only pass to ApplicationArguments the already parsed size instead of the list of args

« Back to merge proposal