Code review comment for lp:~josharenson/unity8/dashboard-manager
Revision history for this message
| Josh Arenson (josharenson) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
Added some, cmake magic (that is either neat, or unacceptable...) that serves up graphics using the qt resource system. This allowed for deleting the nastyness in the qml view. There are a few options here:
1. You like this idea and keep it as is
1a. Refactor tests that depend on tests/graphics to use qrc
2. Ditch the cmake magic, keep a hardcoded qrc file
2a. Do this and implement 1a.
3. Something else entirely
As for the margins, I saw that they were in dragItem and not really thinking about how thats an entirely different use case, added them here. I'll remove them in the next commit.