Mir

Code review comment for lp:~josharenson/mir/command_line_config

Revision history for this message
Alberto Aguirre (albaguirre) wrote :

Just some more minor nits:

~~~
23 +#ifndef COMMAND_LINE_SERVER_CONFIGURATION
~~~

Like Alan mentioned, the convention is:

MIR_TEST_FRAMEWORK_COMMAND_LINE_SERVER_CONFIGURATION_H_

~~~
78 +#include "mir/default_configuration.h"
~~~
Not needed.

~~~
100 + return make_shared<mo::DefaultConfiguration>(::argc, ::argv);
~~~
Per the style guide: http://unity.ubuntu.com/mir/cppguide/index.html?showone=Spaces_vs._Tabs#Spaces_vs._Tabs

It should be indented 4 spaces from the curly bracket.

review: Needs Fixing

« Back to merge proposal