Just some more minor nits:
~~~ 23 +#ifndef COMMAND_LINE_SERVER_CONFIGURATION ~~~
Like Alan mentioned, the convention is:
MIR_TEST_FRAMEWORK_COMMAND_LINE_SERVER_CONFIGURATION_H_
~~~ 78 +#include "mir/default_configuration.h" ~~~ Not needed.
~~~ 100 + return make_shared<mo::DefaultConfiguration>(::argc, ::argv); ~~~ Per the style guide: http://unity.ubuntu.com/mir/cppguide/index.html?showone=Spaces_vs._Tabs#Spaces_vs._Tabs
It should be indented 4 spaces from the curly bracket.
« Back to merge proposal
Just some more minor nits:
~~~ LINE_SERVER_ CONFIGURATION
23 +#ifndef COMMAND_
~~~
Like Alan mentioned, the convention is:
MIR_TEST_ FRAMEWORK_ COMMAND_ LINE_SERVER_ CONFIGURATION_ H_
~~~ configuration. h"
78 +#include "mir/default_
~~~
Not needed.
~~~ mo::DefaultConf iguration> (::argc, ::argv); unity.ubuntu. com/mir/ cppguide/ index.html? showone= Spaces_ vs._Tabs# Spaces_ vs._Tabs
100 + return make_shared<
~~~
Per the style guide: http://
It should be indented 4 spaces from the curly bracket.