Merge lp:~josephjamesmills/ubuntu-packaging-guide/fixed-bug975026 into lp:ubuntu-packaging-guide

Proposed by Joseph Mills on 2012-05-23
Status: Rejected
Rejected by: Simon Quigley on 2017-09-07
Proposed branch: lp:~josephjamesmills/ubuntu-packaging-guide/fixed-bug975026
Merge into: lp:ubuntu-packaging-guide
Diff against target: 45 lines (+18/-9)
2 files modified
debian/changelog (+6/-0)
ubuntu-packaging-guide/getting-set-up.rst (+12/-9)
To merge this branch: bzr merge lp:~josephjamesmills/ubuntu-packaging-guide/fixed-bug975026
Reviewer Review Type Date Requested Status
Daniel Holbach 2012-05-23 Needs Fixing on 2012-05-23
Review via email: mp+106950@code.launchpad.net

Description of the change

Made gpg section more clear

To post a comment you must log in.
Daniel Holbach (dholbach) wrote :

A few small things I noticed.

 - can you add a space (" ") after each sentence and closed parentheses?
 - I'm not sure we'd want to recommend "testing emails" - if we do, we
   should also explain how to add new key IDs or remove ones you don't
   like any more
 - maybe we should link to some password advice instead of giving it
   ourselves - I immediately thought of http://xkcd.com/936/ :-)
 - personally I think I'd prefer "which" to "what" in the first
   sentence, but I'm not a native speaker, so somebody else might want
   to weigh in.

Thanks for your work on this, you made this easier to read! :)

review: Needs Fixing
Daniel Holbach (dholbach) wrote :

I'll mark these merge proposals as 'work in progress' to get them off the review list.

Simon Quigley (tsimonq2) wrote :

Rejecting due to the fact that this has been rewritten and feedback was requested but nothing was done to fix it.

Unmerged revisions

100. By Joseph Mills on 2012-05-19

Bug Bug #975026 changed lines Changed lines 82 thou 93 in the file ubuntu-packaging-guide/getting-set-up.rst

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2012-03-12 22:28:59 +0000
3+++ debian/changelog 2012-05-23 07:22:19 +0000
4@@ -1,3 +1,9 @@
5+ubuntu-packaging-guide (0.1ubuntu1) quantal; urgency=low
6+
7+ * ubuntu-packaging-guide/getting-set-up.rst: Changed lines 82 thou 93 and made backup called getting-set-up.rst~ (LP: #975026)
8+
9+ -- Joseph Mills <josephjamesmills@gmail.com> Sat, 19 May 2012 02:28:39 -0400
10+
11 ubuntu-packaging-guide (0.1) UNRELEASED; urgency=low
12
13 * Initial release.
14
15=== modified file 'ubuntu-packaging-guide/getting-set-up.rst'
16--- ubuntu-packaging-guide/getting-set-up.rst 2012-03-20 22:02:49 +0000
17+++ ubuntu-packaging-guide/getting-set-up.rst 2012-05-23 07:22:19 +0000
18@@ -79,15 +79,18 @@
19
20 $ gpg --gen-key
21
22-GPG will first ask you which kind of key you want to generate. Choosing the
23-default (RSA and DSA) is fine. Next it will ask you about the keysize. The
24-default (currently 2048) is fine, but 4096 is more secure. Afterwards, it will
25-ask you if you want it to expire the key at some stage. It is safe to say "0",
26-which means the key will never expire. The last questions will be about your
27-name and email address. Just pick the ones you are going to use for Ubuntu
28-development here, you can add additional email addresses later on. Adding a
29-comment is not necessary. Then you will have to set a passphrase, choose a
30-safe one (a passphrase is just a password which is allowed to include spaces).
31+GPG will first ask you what kind of key you would like to generate. Choosing
32+the default RSA and DSA (options 1)is fine.GPG will now ask you about the
33+keysize, that you would like to create. The default (currently 2048) is fine,
34+but 4096 is better because it is more secure. GPG will now ask how long you
35+would like to keep this GPG key. It is safe to say “0”, which means the key
36+will never expire.GPG will now ask for your email address.It is best that you
37+enter in the email address that you use to sign into Launchpad. Or if you
38+like you may pick a "testing" one for now, As you can add additional email
39+addresses later on.Next GPG will ask if you would like too add a comment but
40+this is not necessary.You will now have to set a passphrase. A passphrase is
41+a fancy word for a password that can contain spaces and charecters like *#)&:.
42+Please choose a strong password.
43
44 Now GPG will create a key for you, which can take a little bit of time; it
45 needs random bytes, so if you give the system some work to do it will be

Subscribers

People subscribed via source and target branches