Code review comment for lp:~josephjamesmills/ubuntu-packaging-guide/fixed-bug975026

Revision history for this message
Daniel Holbach (dholbach) wrote :

A few small things I noticed.

 - can you add a space (" ") after each sentence and closed parentheses?
 - I'm not sure we'd want to recommend "testing emails" - if we do, we
   should also explain how to add new key IDs or remove ones you don't
   like any more
 - maybe we should link to some password advice instead of giving it
   ourselves - I immediately thought of http://xkcd.com/936/ :-)
 - personally I think I'd prefer "which" to "what" in the first
   sentence, but I'm not a native speaker, so somebody else might want
   to weigh in.

Thanks for your work on this, you made this easier to read! :)

review: Needs Fixing

« Back to merge proposal