Merge lp:~jose/summit/1152168-fix into lp:summit

Proposed by José Antonio Rey
Status: Merged
Approved by: Chris Johnston
Approved revision: 507
Merged at revision: 515
Proposed branch: lp:~jose/summit/1152168-fix
Merge into: lp:summit
Diff against target: 32 lines (+8/-1)
2 files modified
summit/schedule/templates/schedule/meeting.html (+4/-1)
summit/schedule/templates/schedule/virtual_meeting.html (+4/-0)
To merge this branch: bzr merge lp:~jose/summit/1152168-fix
Reviewer Review Type Date Requested Status
Chris Johnston Approve
Review via email: mp+153493@code.launchpad.net

Commit message

Changed etherpad embed to the latest version (static) when summit is set as public.

Description of the change

Changed meeting.html and virtual_meeting.html. I added an if summit.state == 'public' in each one, and changed the etherpad embed to statically show the last version if true.

To post a comment you must log in.
Revision history for this message
Chris Johnston (cjohnston) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'summit/schedule/templates/schedule/meeting.html'
2--- summit/schedule/templates/schedule/meeting.html 2013-03-04 17:47:31 +0000
3+++ summit/schedule/templates/schedule/meeting.html 2013-03-15 03:00:31 +0000
4@@ -109,8 +109,11 @@
5 {% if meeting.private %}
6 <h3>WARNING: Contents of this pad may not be private, and may be searcheable by non-attendees!</h3>
7 {% endif %}
8-
9+ {% if summit.state == 'public' %}
10+ <iframe width=100% height=700 src="{{ meeting.edit_link_to_pad }}"></iframe>
11+ {% else %}
12 <iframe width=100% height=700 src="{{ meeting.link_to_pad }}"></iframe>
13+ {% endif %}
14 </div>
15 </div>
16 <div class="row">
17
18=== modified file 'summit/schedule/templates/schedule/virtual_meeting.html'
19--- summit/schedule/templates/schedule/virtual_meeting.html 2013-03-09 22:37:04 +0000
20+++ summit/schedule/templates/schedule/virtual_meeting.html 2013-03-15 03:00:31 +0000
21@@ -132,7 +132,11 @@
22 {% if meeting.private %}
23 <h3>WARNING: Contents of this pad may not be private, and may be searcheable by non-attendees!</h3>
24 {% endif %}
25+ {% if summit.state == 'public' %}
26+ <iframe width "100%" height="700" src="{{ meeting.edit_link_to_pad }}"></iframe>
27+ {% else %}
28 <iframe width="100%" height="700" src="{{ meeting.link_to_pad }}"></iframe>
29+ {% endif %}
30 </section>
31 </div>
32 <div class="row">

Subscribers

People subscribed via source and target branches

to all changes: