Summit

Merge lp:~jose/summit/1101346-fix into lp:summit

  1. 1101346-fix
  2. Merge into trunk
Proposed by José Antonio Rey
Status: Merged
Approved by: Michael Hall
Approved revision: 477
Merged at revision: 477
Proposed branch: lp:~jose/summit/1101346-fix
Merge into: lp:summit
Diff against target: 12 lines (+1/-1)
1 file modified
summit/schedule/models/summitmodel.py (+1/-1)
To merge this branch: bzr merge lp:~jose/summit/1101346-fix
Reviewer Review Type Date Requested Status
Michael Hall (community) Approve
Review via email: mp+143952@code.launchpad.net

Commit message

Exposed LP authorization cookie via settings

Description of the change

Fixing bug #1101346 as specified in the bug's description.

To post a comment you must log in.
Revision history for this message
Michael Hall (mhall119) wrote :

Approving on the assumption that the value of LP_AUTH_COOKIE won't expire

review: Approve
Revision history for this message
Michael Hall (mhall119) wrote :

Change & to %

review: Needs Fixing
lp:~jose/summit/1101346-fix updated
477. By José Antonio Rey

Fixed typo

Revision history for this message
Michael Hall (mhall119) wrote :

Looks good now

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'summit/schedule/models/summitmodel.py'
2--- summit/schedule/models/summitmodel.py 2012-10-27 14:59:34 +0000
3+++ summit/schedule/models/summitmodel.py 2013-01-18 23:09:23 +0000
4@@ -251,7 +251,7 @@
5 while trycounter <= retrytotal:
6 req = urllib2.Request(url)
7 req.add_header("Cache-Control", "no-cache")
8- req.add_header("Cookie", "please-don't-cache-me")
9+ req.add_header("Cookie", "lp=%s" % getattr(settings, "LP_AUTH_COOKIE", "please-don't-cache-me"))
10 try:
11 export = urllib2.urlopen(req)
12 except urllib2.HTTPError, e:

Subscribers

People subscribed via source and target branches

to all changes: