Merge lp:~jose/summit/1030187-fix into lp:summit

Proposed by José Antonio Rey
Status: Merged
Approved by: Chris Johnston
Approved revision: 420
Merge reported by: Chris Johnston
Merged at revision: not available
Proposed branch: lp:~jose/summit/1030187-fix
Merge into: lp:summit
Diff against target: 173 lines (+39/-20)
5 files modified
summit/sponsor/templates/sponsor/done.html (+4/-2)
summit/sponsor/templates/sponsor/nonlaunchpadstep0.html (+8/-4)
summit/sponsor/templates/sponsor/step0.html (+13/-8)
summit/sponsor/templates/sponsor/step1.html (+6/-2)
summit/sponsor/templates/sponsor/suggeststep0.html (+8/-4)
To merge this branch: bzr merge lp:~jose/summit/1030187-fix
Reviewer Review Type Date Requested Status
Chris Johnston Approve
José Antonio Rey (community) Approve
Review via email: mp+117365@code.launchpad.net

This proposal supersedes a proposal from 2012-07-30.

Commit message

Sponsorship application and suggestion CSS error (bug # 1030187) fix. Classes updated as per ~chrisjohnston request.

To post a comment you must log in.
Revision history for this message
Chris Johnston (cjohnston) wrote : Posted in a previous version of this proposal

There are more pages that I believe will have the issue. Could you please update the sponsorship template files to follow the new layout by using:

<div class="row">
    <article class="span-8">

review: Needs Fixing
Revision history for this message
José Antonio Rey (jose) wrote : Posted in a previous version of this proposal

Classes updated as requested.

review: Needs Resubmitting
Revision history for this message
José Antonio Rey (jose) :
review: Approve
Revision history for this message
Chris Johnston (cjohnston) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'summit/sponsor/templates/sponsor/done.html'
2--- summit/sponsor/templates/sponsor/done.html 2012-02-01 04:25:13 +0000
3+++ summit/sponsor/templates/sponsor/done.html 2012-07-31 00:25:22 +0000
4@@ -5,7 +5,8 @@
5 {% block sub_nav %}{% endblock %}
6
7 {% block content %}
8- <article class="main-content alone">
9+ <div class="row">
10+ <article class="span-8">
11 <h1>Request Sponsorship</h1>
12 <p>
13 Thanks very much for requesting sponsorship to {{ summit.name }}. If you have any queries about your request, please e-mail <a href="mailto:mhall119@ubuntu.com">mhall119@ubuntu.com</a>.
14@@ -14,5 +15,6 @@
15 <p>
16 We'll let you know whether or not your request has been accepted soon via email.
17 </p>
18- </article>
19+ </article>
20+ </div>
21 {% endblock %}
22
23=== modified file 'summit/sponsor/templates/sponsor/nonlaunchpadstep0.html'
24--- summit/sponsor/templates/sponsor/nonlaunchpadstep0.html 2012-03-25 14:00:41 +0000
25+++ summit/sponsor/templates/sponsor/nonlaunchpadstep0.html 2012-07-31 00:25:22 +0000
26@@ -7,7 +7,8 @@
27 {% endblock %}
28
29 {% block content %}
30- <article class="main-content alone">
31+ <div class="row">
32+ <article class="span-8">
33 <h1>Suggest Sponsorship</h1>
34 <p>
35 To suggest sponsorship for someone, we need a few details about your suggestion, such as where they'll be travelling from. We also need to know a bit about them so that we can judge your suggestion. Please take the time to tell us about them in your own words a bit about them.
36@@ -20,9 +21,11 @@
37 <p>
38 If you have any problems with Summit, please <a href="https://bugs.launchpad.net/summit/+filebug">file a bug</a>.
39 </p>
40- </article>
41+ </article>
42+ </div>
43
44- <article class='main-content'>
45+ <div class="row">
46+ <article class="span-8">
47 <form method="post">
48 {% csrf_token %}
49 <table>
50@@ -38,5 +41,6 @@
51 {{ previous_fields|safe }}
52 <input type="submit" value="Next"/>
53 </form>
54- </article>
55+ </article>
56+ </div>
57 {% endblock %}
58
59=== modified file 'summit/sponsor/templates/sponsor/step0.html'
60--- summit/sponsor/templates/sponsor/step0.html 2012-01-23 01:18:55 +0000
61+++ summit/sponsor/templates/sponsor/step0.html 2012-07-31 00:25:22 +0000
62@@ -11,7 +11,8 @@
63
64 {% block content %}
65 {% ifequal summit.state "sponsor" %}
66- <article class="main-content alone">
67+ <div class="row">
68+ <article class="span-8">
69 <h1>Request Sponsorship</h1>
70 <p>
71 To request sponsorship we need to get a few details from you, such as where you'll be travelling from. We also need to know a bit about you so that we can judge your request. We'll get some of that from Launchpad, but please take the time to tell us about yourself in your own words.
72@@ -20,10 +21,11 @@
73 <p>
74 If you have any problems with Summit, please <a href="https://bugs.launchpad.net/summit/+filebug">file a bug</a>.
75 </p>
76- </article>
77-
78- <article class='main-content'>
79-
80+ </article>
81+ </div>
82+
83+ <div class="row">
84+ <article class="span-8">
85 <form method="post">
86 {% csrf_token %}
87 <table>
88@@ -37,11 +39,14 @@
89 {{ previous_fields|safe }}
90 <input type="submit" value="Next"/>
91 </form>
92- </article>
93+ </article>
94+ </div>
95 {% else %}
96- <article class="main-content alone">
97+ <div class="row">
98+ <article class="span-8">
99 <h1>UDS Sponsorship</h1>
100 <p>We are not currently accepting sponsorship applications for {{ summit.name }} in {{ summit.location }}. Please check back again later!</p>
101- </article>
102+ </article>
103+ </div>
104 {% endifequal %}
105 {% endblock %}
106
107=== modified file 'summit/sponsor/templates/sponsor/step1.html'
108--- summit/sponsor/templates/sponsor/step1.html 2012-01-23 01:18:55 +0000
109+++ summit/sponsor/templates/sponsor/step1.html 2012-07-31 00:25:22 +0000
110@@ -10,7 +10,8 @@
111 {% block sub_nav %}{% endblock %}
112
113 {% block content %}
114-<article class="main-content alone">
115+<div class="row">
116+<article class="span-8">
117 <h1>Request Sponsorship</h1>
118
119 <br />
120@@ -21,8 +22,10 @@
121 judging your request.
122 </p>
123 </article>
124+</div>
125
126-<article class="main-content">
127+<div class="row">
128+<article class="span-8">
129 <form method="post">
130 {% csrf_token %}
131 <table>
132@@ -33,4 +36,5 @@
133 <input type="submit" value="Finish"/>
134 </form>
135 </article>
136+</div>
137 {% endblock %}
138
139=== modified file 'summit/sponsor/templates/sponsor/suggeststep0.html'
140--- summit/sponsor/templates/sponsor/suggeststep0.html 2012-03-25 14:00:41 +0000
141+++ summit/sponsor/templates/sponsor/suggeststep0.html 2012-07-31 00:25:22 +0000
142@@ -9,7 +9,8 @@
143 {% block sub_nav %}{% endblock %}
144
145 {% block content %}
146- <article class="main-content alone">
147+ <div class="row">
148+ <article class="span-8">
149 <h1>Suggest Sponsorship</h1>
150 <p>
151 To suggest sponsorship for someone, we need a few details about your suggestion, such as where they'll be travelling from. We also need to know a bit about them so that we can judge your suggestion, we'll get some of that from Launchpad, but please take the time to tell us about them in your own words.
152@@ -22,9 +23,11 @@
153 <p>
154 If you have any problems with Summit, please <a href="https://bugs.launchpad.net/summit/+filebug">file a bug</a>.
155 </p>
156- </article>
157+ </article>
158+ </div>
159
160- <article class='main-content'>
161+ <div class="row">
162+ <article class="span-8">
163 <form method="post">
164 {% csrf_token %}
165 <table>
166@@ -40,5 +43,6 @@
167 {{ previous_fields|safe }}
168 <input type="submit" value="Next"/>
169 </form>
170- </article>
171+ </article>
172+ </div>
173 {% endblock %}

Subscribers

People subscribed via source and target branches

to all changes: