Code review comment for lp:~jose/charms/precise/tracks/fixes

Jose,

Thank you very much for your contribution to this charm. Unfortunately, I was unable to deploy the charm, so I was unable to properly test your changes, though the error doesn't seem to be related to your changes here. The error I got was:

    INFO install Errno::ENOENT: No such file or directory - /Users/eweaver/p/configuration/gem_certificates/evan_weaver-original-private_key.pem
    INFO install An error occurred while installing has_many_polymorphs (2.13), and Bundler
    INFO install cannot continue.
    INFO install Make sure that `gem install has_many_polymorphs -v '2.13'` succeeds before
    INFO install bundling.
    ERROR juju.worker.uniter uniter.go:490 hook failed: exit status 5

I tried on two different environments and got the same error. If you were able to deploy the charm, was there anything you did differently to avoid this error?

Regarding your changes, they seem good, though I would suggest that you add indentation for the if blocks in the config-changed and db-relation-changed hooks, to make them more readable.

Again, thank you for this improvement, and if you can assist me getting this deployed, I can test it to give it my +1.