Juju Charms Collection
teamspeak3 package

Code review comment for lp:~jose/charms/precise/teamspeak3/1297650-fix

  1. Precise Pangolin (12.04)
  2. 1297650-fix
  3. Merge into trunk
Revision history for this message
Charles Butler (lazypower) wrote :

Jose,

Thanks for the quick turn around on this. There's a problem with this MP however. By deleting configuration values, this breaks backwords compatibility. They need to remain in the config.yaml, and be noted that they are deprecated in the description.

Thanks again for the submission. I'm going to change status of this MP to "needs work" and when you're ready for another review please click the "Request another review" button in the upper right hand corner of the commit message.

If you have any questions/comments/concerns about the review contact us in #juju on irc.freenode.net or email the mailing list <email address hidden>

review: Needs Fixing

« Back to merge proposal