© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
35a32c5
(Get the code!)
Hello Jose,
Thank you for working on this merge proposal! Your commitment to the communit is very impressive.
The current charm store policy does recommend that all configuration values have default values. However some older charms got in before this was a rule and consiquently some code actually depends on the value not being set. Since the hooks are python that is realized as a value of None in the code. When you default it to "" the configuration option is not None. We should be very careful with these kind of changes, to not break the code.
I followed all 4 configuration values through the code and believe that 3 of them are OK. But the login-help configuration value has the following code:
if login_help is None:
So when the login-help configuration option is "" it misses this block of code and the hard coded text is never set. I was able to see this text if you deploy the current juju-gui charm on the login page. If you deploy the juju-gui with your code the login text is empty and I do not believe this is what we want to happen.
Please leave the login-help configuration value without a default. I realize that charm proof will still report a warning here but this is a rare case where that is OK.
Thanks again for your work here! Keep being awesome Jose!