Code review comment for lp:~jose/charms/precise/joomla/fix-various

Revision history for this message
Marco Ceppi (marcoceppi) wrote :

I don't think creating an empty config-changed addresses the issue that proof is bringing up. Because the charm doesn't react to configuration changes that configuration option becomes immutable and breaks the core concept of configuration for a charm. Your other changes seem fine but I can't accept this given that config-changed hook doesn't actually address the warning from charm proof.

Once you're ready for another review, select the "Request another review" and assign it to charmers.

review: Needs Fixing

« Back to merge proposal