Code review comment for lp:~jose/charms/precise/buildbot-master/1297558-fix

Revision history for this message
Charles Butler (lazypower) wrote :

Thanks for the submission Jose!

In the readme, the deployment example still makes several references to oneric, and this readme is attached to a precise series charm. This needs to be updated.

When I attempt to deploy buildbot-slave which is listed as a required dependency for buildbot-master I receive the following output:

charles@Bushido:/tmp/charms/precise$ juju deploy buildbot-slave bb-slave
ERROR cannot download charm "cs:precise/buildbot-slave-0": charm "buildbot-slave" using a duplicated relation name: "buildbot"

Thanks again for the submission. I'm going to change status of this MP to "needs fixing" and when you're ready for another review please click the "Request another review" button in the upper right hand corner of the commit message.

If you have any questions/comments/concerns about the review contact us in #juju on irc.freenode.net or email the mailing list <email address hidden>

review: Needs Fixing

« Back to merge proposal