Code review comment for lp:~jose-exposito89/ubuntuone-ios-files/social-networking

Revision history for this message
José Expósito (jose-exposito89) wrote :

Hello Paul,

(1) In order to be able to share links, I have added the ShareKit dependency, that includes into their dependencies JSONKit, for this reason the libs are not removed, they are in other directories.

(2) I have incorporated the trunk because it adds more share services. Anyway, it's possible to change it for the only tag of the project:
https://github.com/ShareKit/ShareKit/tags
But I can say that the trunk is very stable, I use it in my work, in a "real application" without any problem... Anyway, I can change it if you prefer

(3) In my opinion this is the better way of integrate dependencies, in fact, in my ARC branch I have integrating all the dependencies as universal frameworks (a bundle with the library and the headers) to easy make it ARC compatible and easy to update, add, or remove:

http://bazaar.launchpad.net/~jose-exposito89/ubuntuone-ios-files/arc/files/head:/Dependencies/

The ARC branch is mature, but I'm waiting for instructions or help to update the core data to proporse it for merge...
https://lists.launchpad.net/ubuntuone-users/msg00749.html

« Back to merge proposal